#nintendoengineer
viscid saddleBOT
Hello! We'll be with you shortly. Below are links to other discussions we've had with you in the past week in case you want to review that information. If your question is related to one of these previous discussions, please provide a comprehensive summary of the current state and what you need help with now. We help many users simultaneously, so a summary allows us to resolve your issue as soon as possible.
- nintendoengineer, 3 days ago, 30 messages
cosmic rain
Hi there 👋 taking a look.
cosmic rain
😄 we do! hope your day is going well
honest bloom
I cannot complain, my Stripe integrations so far are all going splendidly
Minus this one KYC flow 🤣
How is your day? Any Jerry's come your way?
cosmic rain
That's good to hear!
Haha, nah, it's been a pretty good day.
Hm, I think I see what you're saying, looks like it's just a string that it supports. This part here?
https://github.com/stripe/stripe-node/blob/91d8dec48c0d539d287cb35724f204529e01b05e/types/AccountsResource.d.ts#L2592
honest bloom
Absolutely correct. The API reference mentions a dictionary as possibility, which is the one I was interested in using: https://stripe.com/docs/api/external_account_bank_accounts/create#account_create_bank_account-external_account
Toby, don't abandon me, I need your guidance
cosmic rain
Ah, sorry, trying to do too many things at once. I think you're right and that is a problem with how we generated the types, and there isn't much to do until we can get that fixed. Let me get a teammte to double check that.
honest bloom
You seem quite busy, yeah. I happen to be in the market for a new assignment/job, in case you guys need an extra set of hands? 🤣
vale yew
Yep, that looks to be the issue. We can file with the team that makes the library to get this fixed.
Do you have an idea on what you may be able to do as a workaround in the meantime? I'm not the most familiar with TS but am happy to take a look
honest bloom
Well, if you can confirm for me that if I forcibly jam the dictionary in there, that everything will work properly on your end, then I can force the TS compiler to ignore this specific line
vale yew
I mean from a REST API standpoint that should work as long as we get the data in the format of a json dictionary. Would you mind trying that in test mode? My node setup is broken at the moment so it would take some time for me to test myself
honest bloom
Also @vale yew apologies for almost responding on your other thread regarding the lines/shipping_cost, it was just so obvious I almost reacted to it
I can try that in test mode. It's part of my larger KYC flow, so I would have to tweak a little here and there to get it running in the next 15 minutes. But I have to do that anyway, so if you can keep this thread alive I would gladly test and report back
vale yew
No worries, appreciate the thought. Did you spot that amount was needed in that thread? That one took me a bit to get
viscid saddleBOT
honest bloom
O I did not see that, I went back to this thread in anticipation, but that's a sneaky one.
Okay, so just a quickie in between. I am about to deploy my stack to AWS, which should take about 15 minutes in total to deploy to dev, upon which I can test it.
However, another note is that in stripe.accounts.update there is also an external_account in there I want to fill. I casted the result of createExternalAccount to the interface Stripe.BankAccount, which should have all the properties I put in. However this interface seems to be missing the account_number property.
Sorry for adding a different one in this thread, but since they're related and we're already talking, I figured I'd give it a go.
I am going to deploy and test and let you know in about 15-20 minutes how that part goes
mighty orbit
Hi there 👋 taking over, as my colleague needs to step away
Give me a few minutes to get caught up.
honest bloom
Take all my deployment minutes, my man
honest bloom
Indeed, and we established earlier that the npm package is missing the dictionary type, so I have filled the property manually and had TS compiler ignore the error for now. Your colleague Pompey asked me to test it, so I am doing that and reporting back in a bit. My last point, however is that the Stripe.BankAccount interface is missing this account_number property on it. It's unrelated to my test, but I wanted to mention it, since it seems like a missing property that should be there
cosmic rain
Once the accounts are created the account numbers should be obfuscated to just last4
https://stripe.com/docs/api/external_account_bank_accounts/object#account_bank_account_object-last4
honest bloom
Ah yeah, that is indeed so!