nickhatter | Stripe Developers | Page 1

next roseBOT Jul 28, 2023, 4:32 PM

#

primal ginkgo Jul 28, 2023, 4:32 PM

#

Hi 👋

onyx trench Jul 28, 2023, 4:32 PM

#

Hello! 🙂

primal ginkgo Jul 28, 2023, 4:32 PM

#

Can you describe what API you are using?

onyx trench Jul 28, 2023, 4:32 PM

#

using Stripe Connect - Express

#

with NodeJS

primal ginkgo Jul 28, 2023, 4:35 PM

#

Okay but none of those are APIs specifically. What API are you using?

onyx trench Jul 28, 2023, 4:35 PM

#

oh which endpoint

#

https://api.stripe.com/v1/account_links

#

as far as I can see there's only return and refresh url

#

would be great if stripe could give some kind of flag or callback to indicate successful onboarding, or user cancelled, etc.

primal ginkgo Jul 28, 2023, 4:38 PM

#

That doesn't exist. The closest we have is the account.updated webhook event: https://stripe.com/docs/api/events/types#event_types-account.updated

onyx trench Jul 28, 2023, 4:39 PM

#

yeah I just saw that now

primal ginkgo Jul 28, 2023, 4:39 PM

#

This will contain the Account object and you can then inspect the requirements hash to identify if the Account still needs to provide information to complete onboarding
https://stripe.com/docs/api/accounts/object#account_object-requirements

onyx trench Jul 28, 2023, 4:39 PM

#

I guess I'll have to use that

#

developer request:

add optional:
cancel_url
success_url

#

🙌

#

would make express integration faster 😄

#

thanks for the tip @primal ginkgo !

primal ginkgo Jul 28, 2023, 4:41 PM

#

But what is to stop a user from just dimissing the window/closing the browser?

#

IF they click a Cancel button they are returned to the return_url

onyx trench Jul 28, 2023, 4:41 PM

#

yes

#

would be good if there was similar for cancel and success state

#

just giving feedback as a developer 🙂

#

(and trying to minimise future work for your other dev clients - the less code we have to write to get it up and running, the better 😉 )

#

thanks again

#

you could have cancel_url, pending_url, success_url, etc. 🙂

#

return_url is a bit too broad, just my two cents

primal ginkgo Jul 28, 2023, 4:45 PM

#

I can put in a feature request but, to me, I don't see a clear functionality this unlocks. It seems to rely on the user clicking a specific button and that just isn't reliable

onyx trench Jul 28, 2023, 4:46 PM

#

it would be good to handle the states in an easy way... to me it makes sense. but that's just me!

#

eg. if user clicks cancel
a cancel page which says, "hey you need to complete Stripe onboarding before we can activate you account - try agan here"

#

a finishh/success page => "Thanks, your details have been submitted to Stripe. We'll let you know if anything else is required"

primal ginkgo Jul 28, 2023, 4:48 PM

#

But what if they just close their browser

#

For reference this is a "cancel" behavior we see all the time

onyx trench Jul 28, 2023, 4:48 PM

#

sure if they cancel that way, you obviously might have to handle that

#

but to me I dont see the problem or difficulty in adding additional urls to define 'return' better

#

anyway, I guess I'll have to add something which checks the stripe status on the return_url... and then aappropriately redirects either back to stripe, or to next step in onboarding

primal ginkgo Jul 28, 2023, 4:52 PM

#

I've logged your feedback as a feature request

#

But, since malicious actors can manipulate the URLs provided on the client-side, I would always recommend retrieving the Account object and verifying the state of onboarding that way

#nickhatter