yordis-tax-calculation | Stripe Developers | Page 1

whole ferryBOT Jun 28, 2023, 10:32 PM

#

onyx ledge Jun 28, 2023, 10:33 PM

#

yordis-tax-calculation

#

@vital ocean I don't think so. I think you're supposed to create a Tax Transaction from that calculation https://stripe.com/docs/api/tax/transactions/create_from_calculation
but the Calculation itself is "ephemeral" today

#

I agree it's a bit weird if we let you list the line items so it feels like a miss on our end, I'll flag as a feature request but you can do the same to our support team https://support.stripe.com/contact

vital ocean Jun 28, 2023, 10:39 PM

#

Oh no no no 😭 I want to copy the original tax amount later on

onyx ledge Jun 28, 2023, 10:39 PM

#

yeah that's just not possible today

vital ocean Jun 28, 2023, 10:39 PM

#

I copied the tax_calc_id into the metdata to then use it to attach the tax record but also save it in my side

#

I just copied the amount from the initial workflow step so isnt a big deal

#

being said, scares me out a bit since I am gonna be using it to link the payments to some Tax service you are offering as far as I can tell

#

I wouldnt like my processors to get stuck and you removing the data MonkaSL

onyx ledge Jun 28, 2023, 10:41 PM

#

but you're supposed to use https://stripe.com/docs/api/tax/transactions/create_from_calculation?lang=curl for that part where it's recorded and that has a Retrieve/List

vital ocean Jun 28, 2023, 10:45 PM

#

eehhh

#

curl https://api.stripe.com/v1/tax/transactions/tax_1NO6wG2eZvKYlo2CsttUiHIE \
  -u sk_test_...:

#

that one you mean?

#

I am a bit confused! Hold on

#

Picture the following,

defmodule Umbrella.Web.Api.Graphql.InitiateCoursePayment do
  def resolve(_, args, resolution) do
    ...
    {:ok, tax_calculation} = get_course_taxes(args.course_id, payment_amount, args.address)

    metadata =
      %{
        # Infrastructure
        workflow_id: "COURSE_PAYMENT:INITIAL_PAYMENT",
        correlation_id: Umbrella.id().new(),
        causation_id: Umbrella.id().new(),
        # Args
        confirmation_code: confirmation_code,
        tax_calculation_id: tax_calculation.id,
        course_id: args.course_id,
        payment_mode: args.payment_mode,
        identity_id: identity.id,
        course_price: course_price.amount,
        course_price_currency: course_price.currency,
        payment_amount: payment_amount.amount,
        payment_amount_currency: payment_amount.currency,
        tax_amount: tax_calculation.tax_amount_exclusive,
        tax_amount_currency: tax_calculation.currency
      }

    Stripe.PaymentIntent.create(%{
      confirm: true,
      amount: tax_calculation.amount_total,
      currency: tax_calculation.currency,
      metadata: metadata,
      # ...
    })
  end
  
  defp get_course_taxes(course_id, payment_amount, address) do
    Stripe.V1.Tax.Calculations.create(%{
      line_items: [
        %{
          tax_code: "txcd_20060052",
          amount: payment_amount.amount,
          reference: "course_id:#{course_id}",
          quantity: 1,
          tax_behavior: "exclusive"
        }
      ],
      customer_details: %{address_source: "billing", address: address},
      currency: payment_amount.currency
    })
  end
end

#

Notice in the metadata I keep copying the original course base payment, and I added the tax_calc_id and also copy at that moment the tax_amount info, just in case

#

I am gonna be using https://stripe.com/docs/api/tax/transactions/create_from_calculation?lang=curl

lately on to create that Tax Transaction, yes! Maybe I should put into the metadata ther reference value as well?!

#

Talking about it, I dont get the following

reference
REQUIRED
A custom order or sale identifier, such as ‘myOrder_123’. Must be unique across all transactions, including reversals.

#

That is unique across literally everything, so is my reference kind of broken today?

#

I have reference: "course_id:#{course_id}", as you can see before

onyx ledge Jun 28, 2023, 10:52 PM

#

I'm sorry I'm struggling to grasp what you're asking

#

Like earlier you asked about retrieve a Tax Calculation, which you shouldn't need. Are you asking something else?

vital ocean Jun 28, 2023, 10:53 PM

#

yeah, now it is related to https://stripe.com/docs/api/tax/transactions/create_from_calculation?lang=curl that you shared!

#

I am reading about it, and the reference value got my attention

onyx ledge Jun 28, 2023, 10:54 PM

#

okay so mostly this is a reference that needs to be unique. I am not sure. I get the question. IF you have a unique string then it's fine it will work. But if it's not unique it won't

vital ocean Jun 28, 2023, 10:55 PM

#

Right, but unique across what?

#

Like all possible Payments in the system?

onyx ledge Jun 28, 2023, 10:56 PM

#

unique across every tax transaction you will create forever in your account

#

it's completely unrelated to the PaymentIntent. There isn't really any link betwen a Tax Calculation, a Tax Transaction and a PaymentIntent in our API/systems today

vital ocean Jun 28, 2023, 10:57 PM

#

Got it, probably a UUID is a safe move here, then. What do you think?

#yordis-tax-calculation