jvheaney | Stripe Developers | Page 1

gilded fiberBOT Jun 12, 2023, 6:20 PM

#

lapis apex Jun 12, 2023, 6:20 PM

#

Hello! Can you share your request ID making the update with me?

desert bison Jun 12, 2023, 6:21 PM

#

Sure, can I get that from the stripe dashboard?

lapis apex Jun 12, 2023, 6:21 PM

#

Yup! https://dashboard.stripe.com/test/logs

#

Alternatively, the Subscription ID would also work

desert bison Jun 12, 2023, 6:23 PM

#

This should be the subscription ID: sub_1NHX1qIMivMon7GPUVdFTe1d

lapis apex Jun 12, 2023, 6:23 PM

#

and were you trying to create a new subscription? or were you trying to update an existing one?

desert bison Jun 12, 2023, 6:23 PM

#

Should be updating an existing one

#

I can send you a pastebin of the endpoint code, if you'd like. It's pretty much identical to the documentation (as far as I can tell)

lapis apex Jun 12, 2023, 6:25 PM

#

Can you clarify really quick - what were you trying to update about this subscription? I do see that you're making the update request successfully, but you passed in the same price ID that it already had, so nothing on the subscriptoin actually changed (see https://dashboard.stripe.com/test/logs/req_ryQ3sbg8l9RTBY)

Stripe Login | Sign in to the Stripe Dashboard

Sign in to the Stripe Dashboard to manage business payments and operations in your account. Manage payments and refunds, respond to disputes and more.

desert bison Jun 12, 2023, 6:27 PM

#

I was trying to update to another price ID, but it's entirely possible that it's actually incorrect data being passed on the frontend... do you mind if I take a quick peak and get back to you in a few minutes?

lapis apex Jun 12, 2023, 6:30 PM

#

Yeah go ahead, but let me also explain the larger issue here

#

You never actually successfully paid this subscription when it was created because you created it with payment_behavior: default_incomplete . You need to actually confirm the PaymentIntent generated during subscription creation to complete payment

#

(you're missing everything described in this section - https://stripe.com/docs/billing/subscriptions/build-subscriptions?ui=elements#collect-payment)

desert bison Jun 12, 2023, 6:35 PM

#

Is this for updating a subscription as well? We have the integrated for subscription creation (when the user isn't already subscribed)

lapis apex Jun 12, 2023, 6:36 PM

#

Yes, you can use a similar flow with updating, but it'd be slightly different because you'd use the PaymentMethod that you already created earlier during Subscription creation

#

Really, I'd recommend backing up a step and getting Subscriptoin creation to work end-to-end and then layering up updating

desert bison Jun 12, 2023, 6:37 PM

#

Subscription creation should be working as far as I can tell, here's another subscription I just tested:
sub_1NIFWKIMivMon7GP32eXTXaL

lapis apex Jun 12, 2023, 6:38 PM

#

That subscription isn't active either - it also has a status of incomplete

desert bison Jun 12, 2023, 6:39 PM

#

The initial plan with Price ID price_1NBN2uIMivMon7GPidotrPbA is active

#

Which was the one I created the subscription with, it's the update one that is incomplete. Is that what you're seeing as well?

#

Or am I confused?

lapis apex Jun 12, 2023, 6:40 PM

#

Let me clarify - a Price being active has nothing to do with the Subscription being active or not. An active price just means that you can use it to create new Subscriptions.

What you really need to be looking at is the status of the Subscription itself (https://stripe.com/docs/api/subscriptions/object#subscription_object-status), which in this case is incomplete

#

You can see in that subscription creation request as well - https://dashboard.stripe.com/test/logs/req_zFaOqPvRO3E5Sk the status is incomplete

desert bison Jun 12, 2023, 6:42 PM

#

Sure, I see that, that was the one we updated with. The one we initially created it with seems to be successful (again, unless I am sorely confused):
https://dashboard.stripe.com/test/subscriptions/sub_1NIFVaIMivMon7GPNc10YHu7

Stripe Login | Sign in to the Stripe Dashboard

Sign in to the Stripe Dashboard to manage business payments and operations in your account. Manage payments and refunds, respond to disputes and more.

#

"Premium test plan" is active. Is that not an active subscription then?

#

Apologies if I am missing something, I really am all new to this

lapis apex Jun 12, 2023, 6:43 PM

#

That subscription's active because afer it was created the underlying PaymetnIntent was confirmed and paid for (https://dashboard.stripe.com/test/logs/req_WZI4zWSKf1jjsJ), which transitioned the Subscription to active

#

Which is exactly what we recommend in our docs here (https://stripe.com/docs/billing/subscriptions/build-subscriptions?ui=elements#collect-payment)

desert bison Jun 12, 2023, 6:44 PM

#

Perfect, okay. So then when we try to update our subscription, we call an endpoint as described in your docs here:
https://stripe.com/docs/billing/subscriptions/upgrade-downgrade

#

We get a 200 from the endpoint, but the invoice remains unpaid and subscription updated webhook never called.

gilded fiberBOT Jun 12, 2023, 6:45 PM

#

desert bison Jun 12, 2023, 6:45 PM

#

Is there an additional payment intent or something that needs to be completed for updating the plan? I don't see that anywhere in the documentation unless I missed something

lapis apex Jun 12, 2023, 6:46 PM

#

You're likely not getting the subscription update webhook because of what I described earlier - the request I looked at passed in the same price, so there was no actual change to the subscription

#

Here's the example I was looking at -

#

https://dashboard.stripe.com/test/logs/req_ryQ3sbg8l9RTBY

desert bison Jun 12, 2023, 6:47 PM

#

I have a new request for you to look at that did different prices and still failed:
req_Uwcb6pzNvkgqps

#

I am going from $20/mo to $8/mo and it still fails

trail forum Jun 12, 2023, 6:47 PM

#

👋 I'm stepping in as Karbi needs to step away. Give me a moment to catch up

desert bison Jun 12, 2023, 6:47 PM

#

Sure thing, thank you for your help so far Karbi. I really do appreciate it!

lapis apex Jun 12, 2023, 6:48 PM

#

^^ I'll let bismarck take over, but just want to quickly flag - that request has the same issue. The subscription originally has price_1NBjnGIMivMon7GPiDDOGO78 and the update request is just passing in the same price

desert bison Jun 12, 2023, 6:51 PM

#

That is very confusing because the payment intent of the subscription creation is this:
https://dashboard.stripe.com/test/payments/pi_3NIFVbIMivMon7GP1kgCDBgU

which was for our $20/mo price ID (as it says the card was charged for $20). Then we try to update to $8/mo with this request ID:
req_Uwcb6pzNvkgqps (price ID in this request is price_1NBjnGIMivMon7GPiDDOGO78 which is $8)

Stripe Login | Sign in to the Stripe Dashboard

Sign in to the Stripe Dashboard to manage business payments and operations in your account. Manage payments and refunds, respond to disputes and more.

trail forum Jun 12, 2023, 6:52 PM

#

I think you are mixing up objects and Subscriptions here.

#

pi_3NIFVbIMivMon7GP1kgCDBgU is associated with in_1NIFVaIMivMon7GPBFCC4jXR which is associated with sub_1NIFVaIMivMon7GPNc10YHu7

The request you provided for the update (req_Uwcb6pzNvkgqps) is for updating sub_1NIFWKIMivMon7GP32eXTXaL which is a different Subsription than the above.

desert bison Jun 12, 2023, 6:59 PM

#

Let me confirm my flow then here, maybe the issue is in my initial subscription creation:

User calls payment intent endpoint, I create a payment intent and return that ID to the frontend along with needed details
User completes request with the payment intent on the frontend
My webhook gets called with "customer.subscription.created", and I save the subscription ID from there into my database
My webhook gets called with "invoice.paid" and I update that user's information for my app accordingly in the database

then when a user wants to update:

The user makes a call to my update endpoint with their new price ID
I get their subscription ID from the database according to their userid
I update the subscription with that subscription ID and set the price ID with Stripe's API library
Return a 200 to the frontend
-- Beyond this I don't get any other info

#

Is that all correct?

trail forum Jun 12, 2023, 7:01 PM

#

Why are you creating a PaymentIntent initially prior to creating the Subscription?

desert bison Jun 12, 2023, 7:03 PM

#

Let's say a user buys plan 1 of our app, do we not create a payment intent initially to start the subscription? Like this (https://stripe.com/docs/billing/subscriptions/build-subscriptions?ui=elements&element=payment#create-subscription)

Build a subscriptions integration

Create and manage subscriptions to accept recurring payments.

#

I am following that guide step by step and it seems like all is well until updating

trail forum Jun 12, 2023, 7:04 PM

#

Okay then you likely mispoke. You are creating a Subscription which then creates an Invoice and you are grabbing the PaymentIntent associated with that Invoice and passing its client_secret to the frontend to handle the initial payment, correct?

#

You aren't actually creating a PaymentIntent directly.

desert bison Jun 12, 2023, 7:04 PM

#

Ah yes, that's correct

#

Apologies for the confusion there

trail forum Jun 12, 2023, 7:04 PM

#

Okay just making sure 🙂

#

No worries

#

Okay can you show me your code for how you are updating the Subscription?

desert bison Jun 12, 2023, 7:05 PM

#

Sure, is pastebin okay?

trail forum Jun 12, 2023, 7:06 PM

#

Yeah or just pasting the relevant parts here between 3 backticks works: like this

desert bison Jun 12, 2023, 7:06 PM

#

Sure:

@RequestMapping(value = "/gw/billing/update", method = RequestMethod.POST)
    public ResponseEntity< String > updatePlan(@RequestParam("priceId") String priceId, HttpServletRequest request) throws StripeException {
        String authToken = jtp.resolveToken(request);
        String userid = jtp.getUseridFromJWT(authToken);
        
        String subscriptionId = upr.getSubscriptionId(userid);
        
        try {
            
            Subscription subscription = Subscription.retrieve(subscriptionId);
            
            SubscriptionUpdateParams params = SubscriptionUpdateParams
                      .builder()
                      .addItem(
                        SubscriptionUpdateParams
                          .Item.builder()
                          .setId(subscription.getItems().getData().get(0).getId())
                          .setPrice(priceId)
                          .build()
                      )
                      .setCancelAtPeriodEnd(false)
                      .setProrationBehavior(SubscriptionUpdateParams.ProrationBehavior.ALWAYS_INVOICE)
                      .build();
 
                    subscription.update(params);
            
            return new ResponseEntity<String>(new ResponseData(true, "Upgraded.").toResponse(), HttpStatus.OK);
 
        }
        catch(Exception e) {
            e.printStackTrace();
            return new ResponseEntity<String>(new ResponseData(false, "Server error.").toResponse(), HttpStatus.INTERNAL_SERVER_ERROR);
        }
                
    }

trail forum Jun 12, 2023, 7:07 PM

#

Okay all that looks fine to me. So my guess is, based on the above object misalignment, that you aren't getting the right Subscription ID via String subscriptionId = upr.getSubscriptionId(userid);

#

So what does upr.getSubscriptionId(userid); do exactly?

#

I assume it calls your database?

desert bison Jun 12, 2023, 7:08 PM

#

Yup, just calls for the subscription ID for that user

trail forum Jun 12, 2023, 7:08 PM

#

The other thing you could do real quick to verify that is to hardcode in the Subscription ID

#

So let's do that first

#

Using your above example, let's hardcode that with sub_1NIFVaIMivMon7GPNc10YHu7

desert bison Jun 12, 2023, 7:09 PM

#

Sure

trail forum Jun 12, 2023, 7:09 PM

#

Then that should update it from price_1NBN2uIMivMon7GPidotrPbA to price_1NBjnGIMivMon7GPiDDOGO78

desert bison Jun 12, 2023, 7:11 PM

#

Let me build and deploy that on the test machine, just need 2 minutes here

trail forum Jun 12, 2023, 7:11 PM

#

Sure no rush

desert bison Jun 12, 2023, 7:14 PM

#

I've just tried it again and it hasn't seemed to work: req_97CXfdlIfcdizl

Here is the customer page with that status as incomplete: cus_O4OITH2A4bq4Fu

trail forum Jun 12, 2023, 7:15 PM

#

Think you are looking at the wrong Sub. It did work. You updated: https://dashboard.stripe.com/test/subscriptions/sub_1NIFVaIMivMon7GPNc10YHu7

#

You can see an Invoice was generated and paid via the proration adjustment

#

And the Sub is now on the $8/month Price

desert bison Jun 12, 2023, 7:16 PM

#

Screen_Shot_2023-06-12_at_3.16.43_PM.png

#

Really?

#

Is there some other area I should be checking

trail forum Jun 12, 2023, 7:17 PM

#

Those are three different Subscriptions you are looking at

#

As you have created 3 different Subscriptions for that Customer

#

We do not de-duplicate Subscription creation for Customers. A Customer can have multiple Subscriptions and multiple for the same Price. This is all under your control

desert bison Jun 12, 2023, 7:18 PM

#

I see... Okay

#

I do see the proration applied

#

No webhook calls when that happens?

trail forum Jun 12, 2023, 7:18 PM

#

For which part specifically?

desert bison Jun 12, 2023, 7:18 PM

#

Once the subscription is updated accordingly

trail forum Jun 12, 2023, 7:19 PM

#

If you click on the Subscription and scroll to the bottom of that Dashboard page then you can see all the Events (Webhooks) generated for that Subscription

#

So for instance a customer.subscription.updated Event is created whenever you do one of these updates. For example: https://dashboard.stripe.com/test/events/evt_1NIGArIMivMon7GPqecMAjlW

desert bison Jun 12, 2023, 7:21 PM

#

I see

#

and does that subscription event contain the price ID of the plan the user subscribed to?

#

I usually got that from invoice.paid previously

trail forum Jun 12, 2023, 7:22 PM

#

Yep it does. It will contain the entire Subscription object.

desert bison Jun 12, 2023, 7:25 PM

#

Okay, I am going to dig into what parts may be misconfigured on my end here. One other question, if someone purchases a 30 days subscription and cancels after 17 days, let's say, I get a subscription cancelled event on the webhook and remove the subscription ID from their user record. Will I get a webhook call on the 30th day to remove their subscription level? Or am I to keep track of those days?

trail forum Jun 12, 2023, 7:27 PM

#

Are you using cancel_at_period_end?

desert bison Jun 12, 2023, 7:28 PM

#

Is that a configuration I make in the subscription object? I don't currently use that anywhere

trail forum Jun 12, 2023, 7:31 PM

#

How do you cancel the Subscription?

#

Are you just calling the cancel endpoint: https://stripe.com/docs/api/subscriptions/cancel ?

Stripe API reference – Cancel a subscription – curl

Complete reference documentation for the Stripe API. Includes code snippets and examples for our Python, Java, PHP, Node.js, Go, Ruby, and .NET libraries.

desert bison Jun 12, 2023, 7:31 PM

#

Subscription subscription = Subscription.retrieve(subscriptionId);

            Subscription deletedSubscription = subscription.cancel();

#

That's basically the applicable code

trail forum Jun 12, 2023, 7:34 PM

#

Yep okay then that cancels immediately.

#

So do you still want to provision access to your product until the end of the period though?

desert bison Jun 12, 2023, 7:35 PM

#

If that's possible, yes

trail forum Jun 12, 2023, 7:37 PM

#

Yep then you want to update the Subscription instead and set cancel_at_period_end: true. See: https://stripe.com/docs/billing/subscriptions/cancel?dashboard-or-api=api#cancel-at-the-end-of-the-current-billing-cycle

desert bison Jun 12, 2023, 7:38 PM

#

Got it. And at that point (the end of the period) would it call customer.subscription.cancel?

trail forum Jun 12, 2023, 7:39 PM

#

Yes it will cancel automatically and a customer.subscription.deleted webhook will be emitted

desert bison Jun 12, 2023, 7:39 PM

#

at the end of the period?

trail forum Jun 12, 2023, 7:39 PM

#

Yep

desert bison Jun 12, 2023, 7:39 PM

#

Awesome, okay

#

I am going to tackle this then. Thank you for all your help today, and thank Karbi for me if you speak to him! 🙂

trail forum Jun 12, 2023, 7:40 PM

#

We are happy to help! And will do 🙂

#jvheaney