fallen-subscription-discount | Stripe Developers | Page 1

primal dockBOT Jan 30, 2023, 5:11 PM

#

near snow Jan 30, 2023, 5:12 PM

#

Hi 👋

always_invoice does not create prorations but instead cuts an invoice at the time of the change, so the charges cover everything up to the change to the Subscription.

#

Prorations + discounts is a very tricky subject and the way Stripe handles it is counter-intuitive

late scroll Jan 30, 2023, 5:13 PM

#

oh boy, im sure im going to hate this explanation 😆

near snow Jan 30, 2023, 5:15 PM

#

Well that's about all I've got so far

late scroll Jan 30, 2023, 5:15 PM

#

okay, so here's a senario...

near snow Jan 30, 2023, 5:15 PM

#

Please just send me the API request ID

late scroll Jan 30, 2023, 5:15 PM

#

👍 one sec

near snow Jan 30, 2023, 5:16 PM

#

for the change with create_prorations that doesn't do what you expect

late scroll Jan 30, 2023, 5:17 PM

#

req_iBnEQGFXwOEvbj

#

where as req_uWT0DRM9SqLAZb gives me the prorated amounts i expect but not the discount amount for the coupon

near snow Jan 30, 2023, 5:22 PM

#

Wait...so which one is the problem you are describing? Let's focus on one scenario at a time here

late scroll Jan 30, 2023, 5:23 PM

#

the root issue is when i preview an update with always-invoice for the proration behavior the total_discount_amounts.amount field is 0

#

but if i set it to create_prorations the discounts are returned but the amounts are not prorated as i'd expect.

near snow Jan 30, 2023, 5:25 PM

#

Those settings perform entirely different actions, as I explained.

#

We explain this in this doc: https://stripe.com/docs/billing/subscriptions/prorations

late scroll Jan 30, 2023, 5:26 PM

#

so i guess the question is.... is there a way i can do "always-invoice" and get back the correct discount amount fields for my coupons?

near snow Jan 30, 2023, 5:31 PM

#

Are these coupons that were applied before the change you are attempting to make?

late scroll Jan 30, 2023, 5:31 PM

#

yes

near snow Jan 30, 2023, 5:36 PM

#

And that is the first request ID?

late scroll Jan 30, 2023, 5:36 PM

#

both already have the coupon applied to the customer

#

but yeah the first request id has the correct total_discount_amounts value

#

if i need to i can calculate the discount amount on my end but my goal is to have stripe as the source of truth

near snow Jan 30, 2023, 5:39 PM

#

Ah wait you are talking about the previewing upcoming invoices. Unfortunately I cannot see the output there

late scroll Jan 30, 2023, 5:39 PM

#

correct

#

one sec i can send you the output

#

this is with always_invoice set

#

📎 message.txt

#

this is with create_prorations set

#

📎 message.txt

near snow Jan 30, 2023, 5:46 PM

#

I don't need to see most of this, right?

#

You are saying the issue is with the discount property?

late scroll Jan 30, 2023, 5:46 PM

#

what im seeking is the top response but with the total_discount_amounts property to have values

#

or really anywhere, i just need to know how much that coupon took off

near snow Jan 30, 2023, 5:55 PM

#

Okay so these outputs are too big for me to even see what you are referring to

late scroll Jan 30, 2023, 5:56 PM

#

first request...

#

    "total_discount_amounts": [
        {
            "amount": 0,
            "discount": {
                "checkout_session": "",
                "coupon": null,
                "customer": null,
                "deleted": false,
                "end": 0,
                "id": "di_1MUyi8KjI0M1O6BOixz64pIT",
                "invoice": "",
                "invoice_item": "",
                "object": "",
                "promotion_code": null,
                "start": 0,
                "subscription": ""
            }
        }
    ],```

#

second request...

#

    "total_discount_amounts": [
        {
            "amount": 14400,
            "discount": {
                "checkout_session": "",
                "coupon": null,
                "customer": null,
                "deleted": false,
                "end": 0,
                "id": "di_1MUyi8KjI0M1O6BOixz64pIT",
                "invoice": "",
                "invoice_item": "",
                "object": "",
                "promotion_code": null,
                "start": 0,
                "subscription": ""
            }
        }
    ],```

near snow Jan 30, 2023, 5:59 PM

#

Okay and in this case the second request shows the 20% off coupon being applied

late scroll Jan 30, 2023, 6:00 PM

#

so is it just that the coupon has no affect on the proration being requested?

near snow Jan 30, 2023, 6:00 PM

#

What is the change you are making here?

late scroll Jan 30, 2023, 6:01 PM

#

altering the units on the subscription to a higher amount

near snow Jan 30, 2023, 6:04 PM

#

Okay so you've got a 20% off coupon that is being applied to all prices for a given customer.

#

And you are increasing the quantity in two subscription items

late scroll Jan 30, 2023, 6:04 PM

#

correct

near snow Jan 30, 2023, 6:05 PM

#

So the prorations should be the difference between the old quantities +discountfor the full billing period and the new quantities + discount for the full billing period

#

Does the amount appear incorrect?

late scroll Jan 30, 2023, 6:06 PM

#

the new discount amount is always zero though

near snow Jan 30, 2023, 6:09 PM

#

I understand that, I'm just trying to double check how everything is being applied first.

late scroll Jan 30, 2023, 6:10 PM

#

correct, then the first response the amounts are what i expect

near snow Jan 30, 2023, 6:12 PM

#

Okay, so that part is working. Good

#

And the first one is always_invoice or is that second one?

late scroll Jan 30, 2023, 6:13 PM

#

the first one

near snow Jan 30, 2023, 6:21 PM

#

Th3FalleN sub discounts

late scroll Jan 30, 2023, 6:27 PM

#

oh lawd, it's the big guns. i done dun it now

icy lotus Jan 30, 2023, 6:29 PM

#

fallen-subscription-discount

late scroll Jan 30, 2023, 7:02 PM

#

sooo any ideas?

icy lotus Jan 30, 2023, 7:07 PM

#

Sorry I totally misunderstood you were waiting on us when I took over

late scroll Jan 30, 2023, 7:07 PM

#

no worries

icy lotus Jan 30, 2023, 7:11 PM

#

sorry Discord is super busy. All you're asking is why total_discount_amount is not set? Or something else?

late scroll Jan 30, 2023, 7:12 PM

#

yeah, in a nut shell i need to know the amount of discount applied to the proration

icy lotus Jan 30, 2023, 7:13 PM

#

Yeah that's not possible today unfortunately, we don't surface it in that case

late scroll Jan 30, 2023, 7:14 PM

#

WAT

#

so, we'll need to do that calculation ourselves

icy lotus Jan 30, 2023, 7:20 PM

#

yeah it's something we want to fix

late scroll Jan 30, 2023, 7:24 PM

#

that hurts my brain, but alrighty i'll get on it. thanks for your input as always

#

oof yeah so the prorated amount does indeed include that coupon in it's total calculation. which makes things even worse dead

icy lotus Jan 30, 2023, 7:35 PM

#

yeah we basically apply the coupon during the proration but we don't surface back the calculation I think

late scroll Jan 30, 2023, 7:36 PM

#

that's a hell of a wrench in my ui's gears 😭

#

time to get working on fixing that

#

thanks as always gents

#fallen-subscription-discount