#kostenko

1 messages · Page 1 of 1 (latest)

bright yarrowBOT
brittle notch
#

👋 happy to help

#

I'm not sure that 70MB of Ram is huge per se

#

If you really feel that we should improve on that I would strongly encourage you to write to support https://support.stripe.com/?contact=true and give us as much information as possible so our internal team might be able to investigate further and see if some improvements could be made

obsidian gust
#

I think it is huge for invisible iframe of a random tab of a random website. Our full-featured react app with material UI uses less

brittle notch
#

Invisible? what are you testing exactly?

obsidian gust
#

I've included stripe.js on every page as was requested in API. We display payment widgets only on specific upgrade page, on other pages we don't display any stripe elements

brittle notch
#

you shouldn't include Stripe elements everywhere

#

I've included stripe.js on every page as was requested in API
do you mind sharing where does it say so?

obsidian gust
#

To best leverage Stripe’s advanced fraud functionality, include this script on every page, not just the checkout page. This allows Stripe to detect suspicious behavior that may be indicative of fraud as customers browse your website.

sour pecan
#

Hey! Taking over for my colleague. Let me catch up.

#

Did you tried to load the asynchronously and deferred loading of Stripe.js ?

obsidian gust
#

do you mean calling loadStripe() instead of including the script directly in <head>?

sour pecan
obsidian gust
#

one moment, let me try, but I'm not sure it changes anything - it is about load order (before or after dom)

obsidian gust
#

same thing, 70 megabytes

#

there are m-outer-...*.html 60+ megabytes and 5.5 Mb inner.html

sour pecan
#

Why are you considering 70MB as a "memory leak" ?

obsidian gust
#

It is a guess and probably it is up to Stripe to debug. But I consider 70 megabyte RAM as wasting our clients' memory

sour pecan
#

Do you have any references that consider 70MB is a leak and Waste ? not sure about that, but if you have some recommendation we are open to discuss about it

obsidian gust
#

If you press "Shift+Esc" on chrome, you can see tab memory usage. Average amount is around 30 megabytes. Except of YouTube, Jira and Slack

edgy dawn
obsidian gust
#

Okay, thank you. I wrote to support, this repo is just a repo of script loader, does not include any stripe.js implementation

edgy dawn
#

Sure, the actual Stripe.js source is an internal repository. But that would be where I'd recommend filing the issue as the eng team who works on it can take a look