#Obsidian Night

1 messages · Page 1 of 1 (latest)

indigo zephyrBOT
ornate bronze
#

Hi there!

fallen mirage
#

Hi!

ornate bronze
#

Yes usually contacting support when you find bugs is a good idea. But out of curiosity, what is the issue you found?

fallen mirage
#

Creating subscriptions in the latest version doesn't allow the creation of follow up orders when certain conditions are met (or not met)

#

Call to a member function getIsVirtual() on null#0 /Users/alex/Sites/magento-cloud-test/generated/code/StripeIntegration/Payments/Helper/Subscriptions/Interceptor.php(122): StripeIntegration\Payments\Helper\Subscriptions->getShippingTax('percent')

#

as noted as a comment in the stripe module code:
$shippingTaxPercent = $this->getShippingTax("percent"); // Not reliable for recurring orders and migrations because we don't have an active cart, however if there is an order, it means the shipping tax was already calculated from the quote at the time of the order placement.

It looks as if it is known to be flaky/non working - and I have a fix/patch that I apply to our magento install for this

#

I don't want to maintain a patch if I don't have to, so was hoping to upstream / have some devs review it

ornate bronze
#

If this is related to magento, then yes contacting support is the right approach (we don't know much about magento here)

fallen mirage
#

Ah yes, sorry - that was my fault totally there 😂 It is magento related

#

Thank you!