CrisBadilla | Stripe Developers | Page 1

rigid sparrowBOT Oct 27, 2022, 6:40 PM

#

buoyant mirage Oct 27, 2022, 6:40 PM

#

Hello! What do you mean by "change" exactly?

cosmic folio Oct 27, 2022, 6:42 PM

#

Yesterday has released a change to the Stripe API that broke our system. Our fear is that this situation could happen again in the future. Our idea is to know beforehand if a change/release could break our system.

buoyant mirage Oct 27, 2022, 6:43 PM

#

We only release breaking changes in new API versions, and using a new API version is something you need to explicitly opt-in to: https://stripe.com/docs/upgrades

#

The last breaking changes we made were back in August. What change are you referring to yesterday?

cosmic folio Oct 27, 2022, 6:44 PM

#

Pompey said this to me in the morning :

buoyant mirage Oct 27, 2022, 6:46 PM

#

I'm not familiar with what happened, can you provide more details? What actually changed?

#

Also, as mentioned there, it sounds like this wasn't an intentional breaking change on our part, so I don't think there would have been any way to get notified ahead of time. It sounds like something that should have been part of a new API version.

cosmic folio Oct 27, 2022, 6:48 PM

#

#1035179780661858324 message

#

Ok, so yesterday's issue was unintentional and also isolated, so shouldn't happen again. Is that right?

buoyant mirage Oct 27, 2022, 6:51 PM

#

I'm trying to get further context internally, but as far as I understand it at this point, yes.

#

Okay, looks like we're still considering rolling back this change internally, as it may be considered breaking.

#

Regardless of this specific issue, I recommend you adjust your code to examine the URL and determine if the query parameters you want to add are already present or not before adding them again.

cosmic folio Oct 27, 2022, 7:03 PM

#

Is it possible to you can let me know before you rolling back this change? Because, we sent a fix in our system to support your last change

buoyant mirage Oct 27, 2022, 7:04 PM

#

How does your fix approach dealing with the change?

cosmic folio Oct 27, 2022, 7:08 PM

#

Now we're taking the entire URL that is in Invoice.lines.url field, without appending any parameter. Originally our system was expecting the respective URL without params and then the respective params were added.

buoyant mirage Oct 27, 2022, 7:13 PM

#

Can you adjust the fix as described above so your system is resilient to any query parameter changes which may happen in the future?

cosmic folio Oct 27, 2022, 7:21 PM

#

Yes, I think we don't have other options.

#

I hope the rollback won't be performed tomorrow 😦

buoyant mirage Oct 27, 2022, 7:40 PM

#

How many Stripe accounts do you have which are impacted by this?

#

Is it just the one?

#

@cosmic folio You still around?

#CrisBadilla