elitan | Stripe Developers | Page 1

knotty elmBOT Sep 14, 2022, 4:13 PM

#

open crest Sep 14, 2022, 4:14 PM

#

I'm asking because I would expect an invoice to always have an id.

serene verge Sep 14, 2022, 4:14 PM

#

Hi there

#

Yes it would always have an ID.

open crest Sep 14, 2022, 4:15 PM

#

Ok, then coming back to my first question. Why is id optional for the Invoice interface?

#

id?: string instead of id: string

serene verge Sep 14, 2022, 4:15 PM

#

Yeah good question

#

I'm not super familiar with TS

#

Let me check

open crest Sep 14, 2022, 4:20 PM

#

https://github.com/stripe/stripe-node/pull/1493/files#diff-e15c51b0e7e463c2a1f3cd08ef9aa36b77add099646c89aebc91600730072f98L12-R12

#

Seems like it was changed here 🤔

serene verge Sep 14, 2022, 4:22 PM

#

K yeah just double checked with a teammate and essentially these types are just somewhat vague — they are determined from our OpenAPI spec, which comes from internal definitions, and various fields default to being nullable.

#

Though yeah that's odd that it changed there

#

I'll file some feedback internally so we can take a closer look at these types and ensure they are accurate

open crest Sep 14, 2022, 4:23 PM

#

ok, thanks. I'll override with id: string internally for now then. Thank you.

serene verge Sep 14, 2022, 4:23 PM

#

👍

#

@open crest okay so the actual reason here is because the upcoming invoice endpoint uses the same model and in that case the ID actually is not present (since the invoice hasn't been created yet).

#

Forgot about that

open crest Sep 14, 2022, 4:39 PM

#

Hmm, not sure I understand. Is it a future endpoint that will be released?

serene verge Sep 14, 2022, 4:40 PM

#

No sorry, should have linked the endpoint. It is this one: https://stripe.com/docs/api/invoices/upcoming

#

So if you want to preview a future invoice

#

You use that endpoint

#elitan