#PERF-known-bugs
1 messages ยท Page 1 of 1 (latest)
That's a bit of a nebulous question. Are you seeing something specific happen? If so, how can we reproduce it?
sorry! we meet again @rain yoke haha
This seems to only be an issue on Android
when running the following I see this on the simulator on android.
await initPaymentSheet({
appearance: {
colors: {
primary: "#f13665"
}
},
customFlow: true,
merchantDisplayName: MERCHANT_DISPLAY_NAME,
customerId: customerID,
customerEphemeralKeySecret: ephemeralKey,
setupIntentClientSecret: setupIntentKey,
});
however when running i see this
await initPaymentSheet({
appearance: {
colors: {
primary: "#f13665"
}
},
// customFlow: true,
merchantDisplayName: MERCHANT_DISPLAY_NAME,
customerId: customerID,
customerEphemeralKeySecret: ephemeralKey,
setupIntentClientSecret: setupIntentKey,
});
Hmm, let me check
"@stripe/stripe-react-native": "^0.15.0",
Thanks.
I'm not aware this should be the case so attempting to repro myself.
Give me a moment
ok
Hmm so mine seems to be fine:
I'm seeing the Pink outline in the custom flow on Android as expected
I'm not seeing any differing behavior between iOS and Android here
Wow okay now I do see that
Good call
Really interesting because after I toggle custom flow off the appearance does seem to be cached
So you can only repro the initial time after a hard reset
I'm assuming you haven't tested this on a real device, correct?
Can you also confirm what emulator device you are using?
Cache issue?
Well the emulator is pulling the correct appearance API from somewhere.
Can you:
- comment out the custom flow
- reload your app (should see correct button color)
- toggle back in the custom flow
- Reload your app (should see correct button color still)
Then just hard reset your app, and let me know if you see the default colors.
I have not tested on an actual device yet.
@solid python what do you mean by reload? kill and reopen or allow react-native's hot reloaded to reload
Hit r in Metro
ok give me a moment
Sorry i am having some emulator issues, this might take a bit longer than expected
Np, it was really finicky for me and took a while as well
you were able to see it happening / is a bug ?
It does seem so.
I'm just confused why it does display correctly after I refresh from the non-custom flow
I assume because that appearance setting is getting cached somewhere
But not sure.
I'll file a bug report either way but having you reproduce exactly what happened to me would help confirm what is going on.
Following this #1006975325944680549 message
I saw the same thing
Gotcha
So the bug does only appear when you do a hard restart
Otherwise we are pulling the appearance API correctly from... somewhere
So for next steps, can you write an email to support (https://support.stripe.com/contact/login) and mention my handle bismarck in your email and let me know when you have sent it? That will allow me to grab the ticket and follow up with you async after I file the bug report. Then I can keep you updated on when this is fixed.
email sent through the support portal
Subject was "React-native SDK is not properly displaying custom colors when customFlow is true on android. "
np, as for a work around for the time being... would you suggest just not setting the customFlow to true?
Yes that is likely best. Overall I will push for this to get fixed pretty quickly, though I can't promise it.
haha all good. I am sure there are plenty of other more pressing things. what is "pretty quickly" in the world of stripe dev speed?
Really depends on how tricky the bug is to fix.
We usually try to prioritize stuff like this pretty quickly.
But yeah, can't give a specific timeline since I don't know how involved the fix will be.
classic broad answer, i dig it ๐
Just got to manage expectations :). I'll likely know more later today and may be able to give you more specifics.
cool cool ๐๐ป