ibrahim menem-update-subscription | Stripe Developers | Page 1

haughty mulch Aug 8, 2022, 3:41 PM

#

Hi 👋 can you provide the ID(s) of the request(s) that you're making to update a Subscription?

lethal flower Aug 8, 2022, 3:44 PM

#

sure: these are some
req_WdLtpdiEKi9Jkb
req_kvpyGVFWA7YpST

haughty mulch Aug 8, 2022, 4:06 PM

#

Thank you, and apologies for the delay, I'm working on reviewing those requests.

lethal flower Aug 8, 2022, 4:08 PM

#

thank you!

haughty mulch Aug 8, 2022, 4:27 PM

#

Apologies, that took longer than expected to parse through. What I think is happening is that you're duplicating part of the process by using two different approaches. I see that you created a new Subscription Item for the Subscription, but (if I'm following the timing of these requests correctly) that happened in an order that led your Subscription update requests to not make any changes to the Subscription and therefore not trigger any prorations.

#

Can you try setting proration_behavior when you create the new Subscription Item?
https://stripe.com/docs/api/subscription_items/create#create_subscription_item-proration_behavior

Stripe API reference – Create a subscription item – curl

Complete reference documentation for the Stripe API. Includes code snippets and examples for our Python, Java, PHP, Node.js, Go, Ruby, and .NET libraries.

lethal flower Aug 8, 2022, 4:28 PM

#

sure, I'll test that

#

should I set it to always_invoice ?

haughty mulch Aug 8, 2022, 4:29 PM

#

Yup

lethal flower Aug 8, 2022, 4:34 PM

#

that worked 😄 🥳

#

thank you toby, you rock 💪

#

any recommendation on the overall approach?

tacit marten Aug 8, 2022, 4:35 PM

#

Hi 👋 I"m stepping in for @haughty mulch as they need to go.

lethal flower Aug 8, 2022, 4:39 PM

#

I'll elaborate about it

#

my approach could require 2 subscriptions.update calls which is not ideal. is there a better way to avoid it?

the main reason I don't do it in one call is because the change may include changing billing periods, for that case I need to update prod1 in subscription to the new billing cycle, then create the subscription items (then call update again with he updated items). if I try to create subscription items (for prod2 or prod3) before updating existing prod1 that will fail.

tacit marten Aug 8, 2022, 4:46 PM

#

Hmmm... 🤔

lethal flower Aug 8, 2022, 4:48 PM

#

I guess if I delete the subscription and create a full new one, that would not count as upgrade and proroation will not work etc right?

tacit marten Aug 8, 2022, 4:49 PM

#

You can't delete the subscription. You can cancel it but you should read the couple paragraphs here about that: https://stripe.com/docs/api/subscriptions/cancel

lethal flower Aug 8, 2022, 4:55 PM

#

I'm not sure but it sounds like it would not work as expected. I think the way is via modifying the existing subscription which looks to be working now (but with mutiple api calls)
is it possible to create a kind of group of calls in a transaction?

#

so if one fails at the end of the operation, all are rolledback

tacit marten Aug 8, 2022, 4:55 PM

#

Yeah I think, because of the billing cycle and price changes the two API calls are still your best bet.

#

We do not currently have any batching functionality for API calls but some sort atomicity like what you are describing would be a great feature

lethal flower Aug 8, 2022, 4:57 PM

#

ok, thank you for your help both you and toby

#

I have another simpler (best practice) question, should I post again to the channel or continue here?

tacit marten Aug 8, 2022, 5:01 PM

#

Here would be better (it keeps the main channel more clean and cuts down on the number of threads we have to track)

lethal flower Aug 8, 2022, 5:04 PM

#

right now we are sharing the development credentials between staging and local development, which is not ideal because we have a lot of noise (events sent to the other environment):

I couldn't find a way to generate multiple development credentials
or add a custom special header so we can detect the target environment

what is the best practice here?

tacit marten Aug 8, 2022, 5:06 PM

#

Okay so it's due to the webhook events? We don't really have a good approach for separating staging and local development in that case.

#

My best recommendation would be for local developers to either A) create their own account (which could diverge from production/staging so that's somewhat problematic)

#

or B) Add custom metadata to their Stripe objects and filter the webhook events on that metadata

lethal flower Aug 8, 2022, 5:11 PM

#

option B sounds good, metadata can be added to all calls we make to api, even checkout and customer portal session creation, right?

#

should we return 400 for those webhook event reaching the other environment ?

tacit marten Aug 8, 2022, 5:17 PM

#

Not unless getting your endpoint disabled is part of the design. You should respond with a 200 once you know it's a valid POST from Stripe.

lethal flower Aug 8, 2022, 5:18 PM

#

haha I see #dev-help message asking almost the same question

tacit marten Aug 8, 2022, 5:18 PM

#

There are a few of them today 😅

lethal flower Aug 8, 2022, 5:21 PM

#

thank you, we will give the metadata approach a try

tacit marten Aug 8, 2022, 5:21 PM

#

I hope it works out for you 🙂

#ibrahim menem-update-subscription