#chungyi-iframe-change

1 messages · Page 1 of 1 (latest)

whole gate
#

@proper arch can you maybe give more details? What does "more than 1 instance is loaded on a page" mean? What exactly do you see?

proper arch
#

Yes! We have some integration tests on our page to check the Stripe iframe for credit card input, which is something like

<ifream name="__privateStripeFrame426"...>

I'm not 100% positive, but it seems that since earlier today, we have started to see more than 1 iframe loaded on the page. And I'm curious if there is anything changed on the Stripe side recently.

whole gate
#

it's always possible we changed things, we don't really take integration tests as a valid use-case

#

does that mostly just affect your integration tests? If so, you'll have to find a way to be resilient to that, we regularly change things like this

proper arch
#

cool yeah I'm trying to investigate if the change is on our side or stripe side, and work on next steps.

If I understand correctly, stripe.js/v3 is something that Stripe continues to update, right? So this kind of behavioral changes are totally expected.

whole gate
#

If I understand correctly, stripe.js/v3 is something that Stripe continues to update, right? So this kind of behavioral changes are totally expected.
yes

Does stripe keep a changelog for the v3 js script? https://js.stripe.com/v3/
No, it's purely internal and we own this entirely and do our best to not break users

#

Can you share the extra iframes you see/find?

proper arch
#

yes. 1 min.

whole gate
#

sure!

proper arch
#
<iframe name="__privateStripeFrame1186" frameborder="0" allowtransparency="true" scrolling="no" allow="payment *" src="https://js.stripe.com/v3/elements-inner-loader-ui-92d78d8c6c64ea26714611d3c8a0a3dd.html#referrer=https%3A%2F%2Fstaging.artsy.net%2Fauction%2Fimpact-la-for-choice-2022%2Fregister&amp;controllerId=__privateStripeController1181" aria-hidden="true" tabindex="-1" style="border: none !important; margin: 0px !important; padding: 0px !important; width: 1px !important; min-width: 100% !important; overflow: hidden !important; display: block !important; visibility: hidden !important; position: fixed !important; height: 1px !important; pointer-events: none !important; user-select: none !important;"></iframe>
#

The html body inside of this iframe is empty.

whole gate
#

ack so yeah we literally just changed the loader and enabled it for everyone

proper arch
#

Can you elaborate a bit more? You think this might be the reason we are seeing this extra iframe?

whole gate
#

yes

#

like we're adding new iframes which shouldn't impact ~anyone (unless you have tests doing bad things)

proper arch
#

interesting! ok then we should go back and update our integration tests with something else more robust. Thank you for checking! 🙏

whole gate
#

sure thing thanks a lot for flagging!