Accessibility improvements (tooltips mostly)

[vast lynx]

I think it'd be really neat to have a few (hopefully?) minor accessibility improvements, and by that, I primarily mean just adding tooltips to icons. I know you have a tooltip for the badge above the profile picture (as pictured), but I'm not sure if your component library or whatever supports adding tooltips with minimal code changes (i.e. a tooltip attribute or something).

There's also at least 1 place where a span or a div is used instead of a button element (i.e. the plus button to add a new account), so doing the same there but also adding role="button" would probably be good.

While some icons are self explanatory, some don't make sense to especially newer players (i.e. the friendship icon on generated pic).

Heck, if you are accepting pull requests I'll do it even 😛

[wet prism]

I shoved accessibility concerns on the backburner because genshin itself is not very accessible, and neither are most visual components of the card

However I do want to circle back to it at some point

Right now I just don't have the bandwidth to get into it and do all the tabindex, aria, tooltip, roles and readability things 😢

[vast lynx]

that's very fair, genshin could improve a lot. personally for me it's just a higher cognitive load to try and figure out what the icon is until i click it

[wet prism]

oh yeah that's definitely a thing, I wanted to add more tooltips everywhere in general

[vast lynx]

i'm not great with tabindex and ik the code is not open source but tbh i'd be willing to submit a PR to improve at least some aspects of accessibility (primarily tooltips and roles, could maybe do some more general aria stuff too)

but totally understand if you wanna keep it closed

[wet prism]

you'll die looking at the code

[vast lynx]

have you ever used jira?

[wet prism]

while i'm working on new stuff i'm refactoring parts of it, so i'll keep in mind when i touch on the components

[wet prism]

i did, but it doesn't make sense to use anything jira-ish if there's only one person working at it

[vast lynx]

not asking you to use it lol

i work on it

[wet prism]

oh as in jira code bad

[vast lynx]

i've seen worse

[wet prism]

lol

[vast lynx]

it's horrible

[wet prism]

well jira is probably enterprise-horrible

enka is naively horrible

[vast lynx]

i can't even use the UI, let alone understand half the code

[wet prism]

i won't mind inviting you to do some UI cleanup if you want to, though

[vast lynx]

it's like going through 10 packages and 50 components to find what a button is sometimes

[wet prism]

i do need help

[vast lynx]

never done svelte before but i've done react and angular, but as long as there's clear descriptions/details for anything you'd want help with then i'd be happy to do what i can

[wet prism]

the code has zero comments and is not typed

and also in places relies too much on svelte reactivity where it should have been factored out into separate functions

[vast lynx]

i was part of a typescript migration on jira frontend 😉

but types aside, it doesn't bother me

[vast lynx]

btw what i meant is, as long as the task is clearly defined. i.e. "improve accessibility" = too broad, but "add tooltips, roles and aria-* attributes to elements where applicable" = good

[signal pike]

the amount of times i’ve told you to use typescript and you refused is a bit much now

i would migrate the whole code base over but i’d rather not get slaughtered by you

[wet prism]

i would accept jsdoc cleanup

i won't do typescript

[signal pike]

jsdoc is hell

[wet prism]

it will just halt me completely

i straight up won't be able to work on the codebase

[vast lynx]

idk if you use github or something else but if you wanna invite my github then feel free: https://github.com/AllySummers

my stuff on github is mostly private coz i'm too embarassed 😛

i also have bitbucket (cloud) if you for some reason use that

[signal pike]

idek how it would affect you badly

[wet prism]

because i don't know typescrypt

[vast lynx]

do you know jsdoc?

[signal pike]

it’s very simple

[wet prism]

i tried to type a store to accept a svelte component reference and fucking died

and that's with jsdoc

[vast lynx]

typing components (in react or angular) is horrible

[signal pike]

writable<number>(0)

[vast lynx]

typing objects is easy

[signal pike]

dk how hard that is

[vast lynx]

but you can do a gradual or partial migration and just type what you can if you're interested at some point

[wet prism]

yeah typing objects is easy
it's when you get into interfaces and nullables and

is where it goes into "i have no idea" zone

[signal pike]

do you want me to migrate a page of enka to typescript and just show you?

[wet prism]

plus my frontend is always changing and it only makes sense to strongly type only small parts of it

[vast lynx]

if you wanna move to typescript, i'll volunteer as the person you can spam and ask "wtf does this mean" person

[wet prism]

well here's the thing, i don't want to

there's no value proposition in it for me

[signal pike]

same here

[wet prism]

it only is there if more people start working on it

[vast lynx]

😉

[wet prism]

¯_(ツ)_/¯

[signal pike]

i’ll start working on enka again if it’s in typescript

[wet prism]

i did the /u2/ recently

it's pretty fresh

[signal pike]

i refuse to work in plain javascript

[vast lynx]

/u2/?

or /v2/?

[wet prism]

u2

https://enka.network/u2/jstern25

[vast lynx]

oh did i just not read before when i went there before

[wet prism]

you can try augmenting it

[vast lynx]

i mean i can give it a try

i can get stuck in distraction loops and not do anything if stuff has no clear end task tho

tell me what you want done and i can try

[wet prism]

https://github.com/EnkaNetwork/KitFrontend

[vast lynx]

oh wow you actually invited me

that's exciting

looking now ^_^

[wet prism]

you can take a look with jay

look in /routes/u2 for the main pages and the components you can just find by reference

[vast lynx]

any vscode extensions i should use for the repo apart from (i imagine) the svelte one?

[wet prism]

the task would be to add tooltips to things related to showcase and new uid add/etc

[signal pike]

if u2 looks better code wise i’ll pat you on the back algo

[wet prism]

nah not really, svelte is enough

[signal pike]

intellicode and svelte

github copilot is recommended too, but just don’t use that for the whole thing

[wet prism]

oh hold on lemme send the env

[signal pike]

don’t send it here 😭

[vast lynx]

ah i think i disabled that coz i've been too lazy to make a separate work profile but i'll do that now 😄

[signal pike]

omg

[vast lynx]

what?

[signal pike]

i should work on the cards for zzz

and make it typescript