V5 upgrade 404 images locally [404] /_image | Astro Lounge | Page 1

fiery swallow Dec 4, 2024, 9:31 AM

#

After upgrading a codebase to v5.0.2 i get [404] /_image on the images.
Does not impact the build just local dev.

lofty estuary Dec 4, 2024, 9:42 AM

#

Same here, since the upgrade to V5. However here i have no issues at all when running it locally, when deployed to a production server however all the images fail with an 404.

carmine vigil Dec 4, 2024, 1:54 PM

#

Are you guys using squoosh?

fiery swallow Dec 4, 2024, 2:09 PM

#

no, but i am using unpic (to get React support)

carmine vigil Dec 4, 2024, 2:10 PM

#

Ah

Figured it might be squoosh getting removed, but clearly not that for you 😅

Did this only happen after 5.0.2? was it working on 5.0.0/1?

fiery swallow Dec 4, 2024, 2:18 PM

#

I started with 5.0.1

carmine vigil Dec 4, 2024, 2:20 PM

#

And it also did not work there?

fiery swallow Dec 4, 2024, 2:21 PM

#

no it didn't

#

if i switch back to the branch with 4.16.9 it is fine

carmine vigil Dec 4, 2024, 2:23 PM

#

Hmm interesting

Are you using the built in Image component or generating something with getImage?

fiery swallow Dec 4, 2024, 2:33 PM

#

Im using the unpic image component (mainly in react) with the setting set to Astro. So is generating urls like: src="/_image?href=https%3A%2F%2Fstage-site.com/male-student-on-apron.jpg"

#

I did try using the built in import { Image } from 'astro:assets';

#

but same result

#

they are coming from a remote source if that makes any difference

carmine vigil Dec 4, 2024, 2:44 PM

#

And I assume nothing changed other than the upgrade from 4 to 5 right? You still have your remote image sources in your config and such?

fiery swallow Dec 4, 2024, 2:54 PM

#

yep that correct

carmine vigil Dec 4, 2024, 3:00 PM

#

This component right? https://github.com/ascorbic/unpic-img

fiery swallow Dec 4, 2024, 3:29 PM

#

yes that right

carmine vigil Dec 4, 2024, 3:33 PM

#

@wary coral

When you get some time could you possibly take a gander at this? Maybe something weird with the library and the v5 upgrade?

wary coral Dec 4, 2024, 4:03 PM

#

Sure. Could you open an issue on the Unpic repo, with a repro?

carmine vigil Dec 4, 2024, 4:04 PM

#

@fiery swallow

fiery swallow Dec 4, 2024, 4:29 PM

#

I will see if I can replicate it in a starter repo

fiery swallow Dec 5, 2024, 10:42 AM

#

frustratingly I cannot replicate it in another repo, doesn't feel like it is unpic as that is generating the correct src urls.

Anywhere I can throw a debugger? what fires up the /image route?

acoustic brook Dec 6, 2024, 5:08 PM

#

Are you using trailing slash? Could be realated to this https://github.com/ascorbic/unpic/issues/141

GitHub

Trailing slash problem with Astro · Issue #141 · ascorbic/unpic

Starting from Astro 5 (now in beta), the image endpoint might have trailing slash depending on the trailingSlash config. That is, if it's set to always, then the image endpoint would be /_image...

fiery swallow Dec 7, 2024, 8:18 AM

#

@acoustic brook that was it thank you! didn't think about that being and issue!

wary coral Dec 7, 2024, 3:31 PM

#

You should be able to update @unpic/astro and then trailing slashes will work

unborn chasm Dec 7, 2024, 8:03 PM

#

Who (in the world) (even) invented trailing slashes?

acoustic brook Dec 8, 2024, 12:27 AM

#

Yeah... Using it because the only i18n package that does what I want requires it.

#V5 upgrade 404 images locally [404] /_image