Plex-Poster-Maker (ppm) Stuff | Kometa | Page 2

fresh gorge Feb 25, 2024, 3:02 PM

#

if I add movies... the numbers get even more difficult to follow

#

For the logs to be useful, and the summary to be helpful, I need to be able to find where things went wrong and fix them

#

Thats the perspective I am coming from

#

And where most users will come from

#

If I want to know how many times a movie poster did not come from my primary source, that should be easy to find.

#

So taking a step back, based on the summary (We don't need answers in the summary, but the knowledge to search for key strings to find the answer):
1 - Did text get truncated? If so, which posters?
2 - Did a poster come from my primary source or not? If not, which ones?
3 - If the selected poster has text on it, which ones?
4 - If the season poster was "copied" from the show poster, which ones?
5 - If the API produced some kind of error, which ones?

proud seal Feb 25, 2024, 3:10 PM

#

I know, thats why a logfile is present and the infos are in logfile?

fresh gorge Feb 25, 2024, 3:11 PM

#

I understand.... and I provided you my log file because I cannet find what the "2" represents

#

your reply was look for poster with text

#

i did and came up with 153

#

so now what?

#

I need to review 153 sections to find the two?

proud seal Feb 25, 2024, 3:12 PM

#

As an example, what are you missing here?

[2024-02-25 10:33:56] TRACE   |      Searching on TMDB for a Season poster
[2024-02-25 10:33:56] OPTIONAL|      Found Poster with text on TMDB
[2024-02-25 10:33:56] DEBUG   |      Taking TMDB Fallback show Poster for - Season01...
[2024-02-25 10:33:56] INFO    |      Poster url: https://image.tmdb.org/t/p/original/yscwTJzKeOID3djzy78UONxmwOe.jpg
[2024-02-25 10:33:56] DEBUG   |      Downloading Poster from 'TMDB'
[2024-02-25 10:33:56] INFO    |      Resizing it | Adding Borders | Adding Overlay
[2024-02-25 10:33:58] INFO    |      Optimal font size set to: '150'
[2024-02-25 10:33:58] INFO    |      Applying Font text: "SEASON 1"
[2024-02-25 10:33:59] TRACE   |      Searching on TMDB for a Season poster
[2024-02-25 10:33:59] OPTIONAL|      Found Poster with text on TMDB
[2024-02-25 10:33:59] DEBUG   |      Taking TMDB Fallback show Poster for - Season02...
[2024-02-25 10:33:59] INFO    |      Poster url: https://image.tmdb.org/t/p/original/yscwTJzKeOID3djzy78UONxmwOe.jpg
[2024-02-25 10:33:59] DEBUG   |      Downloading Poster from 'TMDB'
[2024-02-25 10:33:59] INFO    |      Resizing it | Adding Borders | Adding Overlay
[2024-02-25 10:34:00] INFO    |      Optimal font size set to: '150'
[2024-02-25 10:34:00] INFO    |      Applying Font text: "SEASON 2"```

fresh gorge Feb 25, 2024, 3:13 PM

#

let me read this a couple of times.

#

these lines could be clearer:
Found Poster with text on TMDB
Taking TMDB Fallback show Poster for - Season01...

Based on this section, I would say that the counter for fallback is incremented by 1 (perseason), the number for poster with text (may or may not) be incremented by 1(per season)

#

maybe Fallback show Poster is a good string to search on to find the number of times a season postere was used based on the show poster?

#

I also have only 1 occurrence of Fallback poster cause its your Fav Provider which seens to be an interesting line

#

Shouldn't that be false?

#

or maybe I am misunderstanding... which is more likely

#

texlessposter and posterwithtext should be opposed?

#

when one is true, the other is false?

#

$global:TextlessPoster = $false
$global:PosterWithText = $true

#

Not sure I understand why we have both of these in the script

fresh gorge Feb 25, 2024, 5:09 PM

#

How would you handle the following with this script?

#

imdb is invalid

#

tmdb does not exist

#

fanart gives poster with text

#

tvdb seems to have some posters

#

I made this...

#

no idea where I would put this to possibly have the script apply the overlay, border, and text

#

trying to add it to fanart, but they will likely reject it as they always do

#

added it to tvdb: https://thetvdb.com/series/looney-tunes#artwork as an image with no text, but again, I think that the script does not try to download tvdb textless images. Their image upload workflow allows one to choose a picture without text

proud seal Feb 25, 2024, 6:32 PM

#

I would say, choose a provider you want to stick with and add there the files that are missing, it does make the script to complex if you have to search there and there and only take this when this is not present and and and...

fresh gorge Feb 25, 2024, 8:17 PM

#

Absolutely. Unfortunately. Tmdb rejected looney tunes as its evolved since 1929 so they don't recognize it.

#

The csv does not have a tmdb id

proud seal Feb 25, 2024, 8:26 PM

#

if its missing in csv, its missing in plex

#

But try latest, i added tvdb textless search and im now exporting every info to a csv into the logs folder "PosterChoices.csv" i think you now can better find what needs manual work...

#

fresh gorge Feb 25, 2024, 9:49 PM

#

sure. let me try

fresh gorge Feb 25, 2024, 10:07 PM

#

LibraryName column is always empty... just FYI

#

148 records in csv where fallback=TRUE

#

#

142 in summary

fresh gorge Feb 25, 2024, 11:03 PM

#

that being said, the csv is very useful. I am setting it to false on that column and going to fix the sources in TMDB

proud seal Feb 26, 2024, 6:35 AM

#

Both should be fixed.

fresh gorge Feb 26, 2024, 11:08 AM

#

proud seal Both should be fixed.

Oh no.... this version is worse in terms of results. It's not taking any textless season posters. It is falling back to the show poster all the time, even if it reports that it found the textless season poster.

#

📎 message.txt

#

#

And this can't be right... well it sort of is right and wrong all at the same time.

proud seal Feb 26, 2024, 11:16 AM

#

had a type, fixed 😄

#

i need to make another textlib, during testing before pushing it, my libs never act like this

fresh gorge Feb 26, 2024, 12:21 PM

#

How could my libs be so different?

#

Are the shows I watch that obscure?

proud seal Feb 26, 2024, 12:27 PM

#

i dunno, everytime you have a problem i dont have i try to add exactly that show to get the same result 😄 i even changed on one testlib to use season title and tmdb, cause i do not had it that way

fresh gorge Feb 26, 2024, 12:34 PM

#

Ok. I am rerunning with the latest version. So far it looks like that typo fixed the issue.

#

Much better. I will need to review because it says everything is textless but I still see text on posters so I will need to go see the source and find out what is happening

fresh gorge Feb 26, 2024, 1:13 PM

#

Prison Break, Planet Earth, Looney Tunes, Impractical Jokers all have text posters/season scattered. Likely a bad source but will require me to investigate each one. Been creating textless posters for the last 4 days....

proud seal Feb 26, 2024, 1:27 PM

#

we need a free ai api tool for that, that detects text and then removes it 😄

fresh gorge Feb 26, 2024, 1:44 PM

#

well... here is the next bug

#

https://www.themoviedb.org/tv/1044-planet-earth/images/posters

#

#

according to the csv, textless is true, but there are no textless on tmdb

#

#

both season and show have text. This should have done a fallback to another provider

#

[2024-02-26 07:41:11] TRACE   |      Searching on TMDB for a show poster
[2024-02-26 07:41:11] OPTIONAL|      Found Poster with text on TMDB
[2024-02-26 07:41:11] INFO    |      Poster url: https://image.tmdb.org/t/p/original/mfXulHiALTloIqivuC4Q3lI3RGw.jpg
[2024-02-26 07:41:11] DEBUG   |      Downloading Textless Poster from 'TMDB'
[2024-02-26 07:41:11] INFO    |      Resizing it... 
[2024-02-26 07:41:12] INFO    |      --------------------------------------------------------------------------------
[2024-02-26 07:41:12] INFO    | Start Season Poster Search for: Planet Earth
[2024-02-26 07:41:12] TRACE   |      Searching on TMDB for a Season poster
[2024-02-26 07:41:12] SUCCESS |      Found Textless Poster on TMDB
[2024-02-26 07:41:12] INFO    |      Poster url: https://image.tmdb.org/t/p/original/cx8v8gEJMNBHiXRvRktY3Bm8xR6.jpg
[2024-02-26 07:41:12] DEBUG   |      Downloading Poster from 'TMDB'
[2024-02-26 07:41:12] INFO    |      Resizing it...

proud seal Feb 26, 2024, 1:49 PM

#

can you send me the csv entry of libexport from this show?

fresh gorge Feb 26, 2024, 1:55 PM

#

I will share logs now

#

📎 PlexLibexport.csv 📎 PosterChoices.csv 📎 Scriptlog.log

#

i wonder if this condition happens when the show poster has text, but the season poster is textless?

#

in the above image, the season poster had text on it because someone classified it as "no language"

#

however, the actual show poster has 0 "No language" posters... so just a theory at this point...

proud seal Feb 26, 2024, 2:14 PM

#

the api returns textless on those for the show 😄

#

https://www.themoviedb.org/tv/1044-planet-earth/season/1/images/posters?image_language=xx

The Movie Database

Miniseries

fresh gorge Feb 26, 2024, 2:20 PM

#

I deleted the 1 show poster and ran script:

#

Found poster with text

#

downloading textless poster

#

it either found it with text, or it didn't?

#

Like I mentioned.... the condition here might be that if sesaon has textless but show only has text

#

planet earth show has TEXTONLY, but the seasons contain images that are textless.

#

Planet Earth II has a similar problem:
https://www.themoviedb.org/tv/68595-planet-earth-ii/images/posters

#

csv says all textless

#

site does not have textless show and no textless season

#

#

#

the logs I shared have all this in there as well

#

Money Heist is going to be a special review... so I will hold off on that one....

#

Looney Tunes show poster is with text. yet csv says textless. notice how its pulling from fanart, yet the fallback says false? To me that means that it grabbed from my primary which is tmdb

#

and from fanart:

#

has text on it... and labelled as having text.

#

Impractical Jokers:
Show poster is textless.
Season posters are with text:

#

#

notice how all the results are showing textless true

#

for impractical.. the source is bad.

#

someone uploaded a bunch of posters and did not classify them as english

#

So I cleaned up the season posters and labelled them all as english. so now in theory, for impractical jokers, whenever the API has the updates, only the show poster is textless.... none of the season posters are textless. (I would need to create them and upload them)

proud seal Feb 26, 2024, 2:55 PM

#

those all text and texless issues drive me crazy 😄
please try latest, in my test the planet earth now reported back exactly like the api does, so it should now also report back the way in scriptlog and in csv.

fresh gorge Feb 26, 2024, 4:16 PM

#

You telling me?!? Crazy is my middle name... lol.

#

I will test it out shortly.

fresh gorge Feb 26, 2024, 5:07 PM

#

So I think this last version, for Looney Tunes, is grabbing the textless version from tvdb after not finding anything on primary with tmdb, and finding a poster with text on fanart. (This is a good result) Rerunning to look for other anomalies

#

#

so not much of a conclusion... since I cannot tell when the API updates are completed for tmdb.... right now, the script should come back empty on all seasons for impractical jokers.... as I had to label all of them as english

#

as for the 2 planet earth 1 and 2, I am not sure how to interpret the csv:

#

textless FALSE, fallback True

#

#

📎 message.txt

#

the log explains pretty much why its text, but since I ended up grabbing from tmdb, why is fallback true?

#

as for the seasons in Planet Earth / Planet Earth II, I think its a question of waiting again as I may have done some cleanup in tmdb and need that to reflect in the API

proud seal Feb 26, 2024, 5:36 PM

#

Fallback is true because it tried to search on other sites too, but only with text available so it took the fallback poster from fav provider, in this case tmdb

fresh gorge Feb 26, 2024, 5:39 PM

#

which is the preferred... so fallback switches to true if ever in the logic, it goes to something other than the primary

proud seal Feb 26, 2024, 5:40 PM

#

Correct

fresh gorge Feb 26, 2024, 5:41 PM

#

OK. I can live with that now that the "business" logic is explained

#

lunch time for me. gonna try after lunch without making any changes to tmdb to see if the API is updated yet.

fresh gorge Feb 26, 2024, 6:05 PM

#

on a separate note.. I am 2 for 2 on having art rejected from fanart.tv.

#

I dont hink I will be submitting much to them

#

anymore... lol

proud seal Feb 26, 2024, 6:06 PM

#

🥲 thats sad, back in the days of kodi, fanart was the way to go

fresh gorge Feb 26, 2024, 7:04 PM

#

They are so picky. like the Looney Tunes is from 1929... and they are worried about the quality of the image... its kind of embarrassing

fresh gorge Feb 26, 2024, 8:11 PM

#

OK. so API updates happened and the script is looking accurate in terms of results

#

shows 1 text image and when I use my own eyes, there is only 1 text image for planet earth

proud seal Feb 26, 2024, 8:14 PM

#

Finally 😮‍💨😂

fresh gorge Feb 26, 2024, 8:32 PM

#

Yes... now I am pushing up the rest of the fixes to tmdb... then its a waiting game again

fresh gorge Feb 26, 2024, 9:57 PM

#

so the last strange one. Money Heist...

#

#

#

📎 message.txt

#

📎 PlexLibexport.csv 📎 PosterChoices.csv 📎 Scriptlog.log

#

Money Hesit is one of those shows where originally, I think the spanish version only had 3 seasons, but when Netflix released it, they had 5 seasons. So I cannot tell what the script is doing, or where its trying to get the images from.

#

I have the Netflix 5 season version

#

so 5 posters are pulled, but teh last two or three are seemingly duplicates

#

or fallbacks, but not 100% sure why

#

https://www.themoviedb.org/tv/71446-la-casa-de-papel/seasons

#

#

seems that it takes this textless image and makes it the default image for season 4 and season 5.

proud seal Feb 27, 2024, 6:13 AM

#

Okey, Updated the order on when what gets picked (it has defaulted to fallback on the beginning because it had a texless one as fallback)
Also log adjusted it should be clear now!

rare tulip Feb 27, 2024, 12:45 PM

#

Good morning guys... Just wanted to take a second here to say you both are Badasses and Thanks! FSCorrupt worked with me to get the postermaker working and I've just been here lurking and downloading the latest updates. I run a software development platform and wish some of my guys were as on it as you are 🤣 Thanks again.

proud seal Feb 27, 2024, 1:33 PM

#

rare tulip Good morning guys... Just wanted to take a second here to say you both are Badas...

Thank you for the appreciation! minecraftheart

fresh gorge Feb 27, 2024, 1:39 PM

#

rare tulip Good morning guys... Just wanted to take a second here to say you both are Badas...

Cool. We try our best.

#

I will test with latest version.

fresh gorge Feb 27, 2024, 1:51 PM

#

proud seal Thank you for the appreciation! <:minecraftheart:927954218046861364>

We may want to adjust the readme a little.

I only use pwsh 7.1 and it works fine
Given that this script really tries to grab textless posters above all, I think that should be specified in the first paragraph. If people want the most popular poster regardless of language, this script is not for them.

I am not sure what manual mode will do in this script. I need to try it. What I read sounds like I can decide on having a local poster that I point the script to and it will overlay it and add text. But what if my options don't want that... will it just resize and rename and place into an assets directory?

proud seal Feb 27, 2024, 1:53 PM

#

fresh gorge We may want to adjust the readme a little. I only use pwsh 7.1 and it works fin...

the manual mode currently takes a poster, asks for lib name, title name and rootfolder name and if season or not, then it does the imageprocessing logic the same way as in automatik mode

#

but it takes a image, and then moves it and it currently only does one part, so either season poster or show/movie poster, not a lot of logic in manual mode in current state

fresh gorge Feb 27, 2024, 1:55 PM

#

Here is an enhancement that you might want to consider....

Within the config.json, pick your preferred language for a poster. If you want French, use fr. If you want textless, use xx. If you want German, use de. Thoughts on such a feature?

fresh gorge Feb 27, 2024, 1:55 PM

#

proud seal but it takes a image, and then moves it and it currently only does one part, so ...

Ok. I will stay away from manual for the moment

#

I think the api calls are already filtering on 3 languages

proud seal Feb 27, 2024, 1:56 PM

#

fresh gorge Here is an enhancement that you might want to consider.... Within the config.js...

i know what you want to say with this, but for current logic this would result in a complete rewrite 😄

fresh gorge Feb 27, 2024, 1:57 PM

#

What if you could pass that string to the script

#

Ok. No problem. Not asking for a rewrite

proud seal Feb 27, 2024, 1:57 PM

#

to prefer posters in specified language even if textless is true or not or?

fresh gorge Feb 27, 2024, 1:58 PM

#

Ultimately, it would have been cool to specify the language of the posters you wanted as a config option

#

If I want textless with the script, I pass xx

#

If I want German, de

#

If I want French, fr

#

So the user decides what language they want. There is nothing out there like that...

proud seal Feb 27, 2024, 2:00 PM

#

hmm in theory possible, but i do not know if it breaks the flow 😄

fresh gorge Feb 27, 2024, 2:00 PM

#

For me personally. I want xx, en

#

Others might want en, xx

#

Second is I want English posters, if none exist, give me textless

#

First is that I want textless, and if does not exist, give me English

#

Also, readme show document the new csv that is created as its useful.

proud seal Feb 27, 2024, 2:15 PM

#

fresh gorge Also, readme show document the new csv that is created as its useful.

i thought i already added this to readme 🤔

fresh gorge Feb 27, 2024, 2:18 PM

#

Oh I see it now... in a sub bullet

fresh gorge Feb 27, 2024, 2:51 PM

#

Summary and not Summery

#

Also, this summary is new... and wondering why the 72 "errors"

#

Is it because a fallback happened?

#

But fallback shows 75

#

So 72 of the 75 had errors?

#

Let me review the logs

#

📎 PlexLibexport.csv 📎 PosterChoices.csv 📎 Scriptlog.log

#

Just noticed that 72 looney tunes did not download or have a proper link.

#

Let me rerun.

#

It also explains why this run only took 7 minutes instead of the typical 9

#

Looks like rerunning is now capturing the missing looney tunes

proud seal Feb 27, 2024, 5:38 PM

#

fresh gorge Others might want `en, xx`

I can try, but i might get a headache 🤣

modern pebble Feb 27, 2024, 6:55 PM

#

I just found this yesterday and was checking it out and this is FANTASTIC! Just wondering if there is a way to limit the right side margin as the ribbon overlay in the right lower corner does cut off some of the title text in certain situations. Kudos to you guys, this is really slick!

proud seal Feb 27, 2024, 6:57 PM

#

Do you have an example pic?

modern pebble Feb 27, 2024, 7:02 PM

#

#

proud seal Feb 27, 2024, 7:05 PM

#

You need to play with those settings in config file:

    "MaxHeight": "600",
    "text_offset": "+300"```

#

But to only shift the width more from right to left is not possible in current state,

modern pebble Feb 27, 2024, 7:09 PM

#

So if I took 360 pixels out of the MaxWidth, it would center the text slightly off to the left side (like from the bottom of the ribbon to the left border of the image?) Maybe I'll switch the rating and the ribbon and see how that works out. Thanks!

proud seal Feb 27, 2024, 7:12 PM

#

The textbox field gets centered and has a maxwidth what you can set in config, if you lower the value it will still center the text inside thte box but you will shift in your case 180px from left to center and 180px from right to center with the text box field.

modern pebble Feb 27, 2024, 7:16 PM

#

So being the ribbon is 351 pixels, I'd have to double that (702) so the text box doesn't go into the ribbon space? And it would take 351 pixels from both left and right side leaving the width at 1098? Just making sure I understand the concept.

proud seal Feb 27, 2024, 7:18 PM

#

In current state of script - yes
I can check tomorow if i can add a way to change it like you want to only shift from right to left, not sure if its possible that way

modern pebble Feb 27, 2024, 7:22 PM

#

proud seal In current state of script - yes I can check tomorow if i can add a way to chang...

I wouldn't really sweat it. It will look funny being offset to the left on posters without a ribbon. Unless you can figure out a way to check and see if a ribbon overlay is applied/going to be applied and just shift it for those (is that asking too much? LOL). I'm going to do a run with the rating and ribbon switched, I think it will look better with the title centered.

proud seal Feb 27, 2024, 7:23 PM

#

It has no pmm integration, so i do not know what happens to picture after the creation of mine script

modern pebble Feb 27, 2024, 7:24 PM

#

Looking at my math above, I guess it would still be centered but it would be a narrower window and have multiple lines of text in it. That won't really look great either. Great job on this though!

proud seal Feb 27, 2024, 7:24 PM

#

An alternative would be to apply the banner in top left corner and the top parts to the bot

modern pebble Feb 27, 2024, 7:25 PM

#

Yes, I'm moving the ribbon to top left and the rating to bottom right. That should look good. Thanks again!

fresh gorge Feb 27, 2024, 8:02 PM

#

Try to imagine a box that this script will place text into. And the base image is 2000x3000

#

It will optimize the font size based on the box size

#

It will add the carriage returns as needed and based on your font as not all fonts are the same

modern pebble Feb 27, 2024, 8:07 PM

#

fresh gorge Try to imagine a box that this script will place text into. And the base image i...

I get that but if the max width is 1800 (as set in config) and I take 702 (or 710 for buffering) away then it's left with a small window and there could be many carriage returns in the title. (this one was not done by this script).

fresh gorge Feb 27, 2024, 8:09 PM

#

It's a box so height plays into this as well

#

If you don't want it to go so high, limit the box height as well

modern pebble Feb 27, 2024, 8:10 PM

#

fresh gorge It will optimize the font size based on the box size

I missed the part about the font size. So a smaller box would use a smaller font size?

fresh gorge Feb 27, 2024, 8:11 PM

#

modern pebble I missed the part about the font size. So a smaller box would use a smaller fon...

702 means you have 1298 pixels yes. It auto sizes

#

Max font size tells it never to go larger than a certain font size and min font does the same

rare tulip Feb 27, 2024, 8:12 PM

#

Spent a lot of time making sure all my PMM items don't cover any of the awesome poster work you guys are doing 🙂

modern pebble Feb 27, 2024, 8:13 PM

#

fresh gorge 702 means you have 1298 pixels yes. It auto sizes

I might have to play with that. I'm just concerned that the font may be too small and either hard to read or just plain look too small (not large enough in relation to poster size).

modern pebble Feb 27, 2024, 8:13 PM

#

rare tulip Spent a lot of time making sure all my PMM items don't cover any of the awesome ...

I like that status overlay!

fresh gorge Feb 27, 2024, 8:13 PM

#

Hence min font size

#

You need to fool around until you find the right box and then the min and max font for that box and the font you want. Also planning where the other overlays go

#

You can also choose to exclude border if you want

modern pebble Feb 27, 2024, 8:15 PM

#

fresh gorge You need to fool around until you find the right box and then the min and max fo...

Yeah, that's why I was going to swap the ribbon and rating because the box/font size look good now. I already decreased the border to 5px.

fresh gorge Feb 27, 2024, 8:16 PM

#

Just sharing how the script is very flexible... and you need to conceptualise a couple of items and plan things out for it to work out.

#

I love that it grabs textless posters, assuming they are available and marked properly in the source systems

fresh gorge Feb 27, 2024, 8:18 PM

#

modern pebble Yeah, that's why I was going to swap the ribbon and rating because the box/font ...

Moving the ribbon is not an easy task from what I recall... at least from the defaults perspective

#

You could also decide to have the title at the top with the overlay from the top down. You'd need to flip the overlay.png and then adjust the text box offset to be at the top, so that's doable as well.

#

Not sure the posters would look good that way as likely covers people in the poster compared to covering their lower body

modern pebble Feb 27, 2024, 8:21 PM

#

fresh gorge Moving the ribbon is not an easy task from what I recall... at least from the de...

I'll play around with it. I'm trying to swap the ribbon/rating right now (running now) so if that doesn't work out I'll look at decreasing the box size and go from there. Thanks!

#

LOL I didn't even think about the shape of the ribbon overlay!

fresh gorge Feb 27, 2024, 8:24 PM

#

Since I am overlay crazy. I just want the textless posters

proud seal Feb 27, 2024, 8:24 PM

#

Yeah you would need to create a new ribbon template for left top and apply this instead of the default one 😅

fresh gorge Feb 27, 2024, 8:27 PM

#

This is also why I prefer to have pure textless and 0 border, and text applied....

#

For me personally it gives me the most freedom.

modern pebble Feb 27, 2024, 8:29 PM

#

fresh gorge Since I am overlay crazy. I just want the textless posters

Yes, those are the best. Can you explain the text_offset?

fresh gorge Feb 27, 2024, 8:29 PM

#

0 means that the "box" is at the bottom

#

1 means the box is 1px off the bottom edge

#

100px means that it is 100px from bottom edge

#

I think it's a little more complicated than that, but that was the intention when we built that part

modern pebble Feb 27, 2024, 8:31 PM

#

So the default config is a box starting at 600px from the bottom edge and the text starts at 300px from the bottom edge (so the text starts centered in the box).

fresh gorge Feb 27, 2024, 8:31 PM

#

Default?

#

Oh wait...

modern pebble Feb 27, 2024, 8:32 PM

#

MaxHeight: 600, text_offset: +300

#

Or is that the max height of the overlay image?

fresh gorge Feb 27, 2024, 8:33 PM

#

    "MaxHeight": "600",
    "text_offset": "+300"

#

So think of the box being 1800x600

#

And the box is pushed up 300px from the bottom

#

Then take your font with the text and it will be centered in that box

#

In theory, and we'd need to check, those variables should probably be renamed to:

    "BoxHeight": "600",
    "box_offset": "+300"

#

That might provide more clarity

modern pebble Feb 27, 2024, 8:38 PM

#

Probably, or change them to "TextBoxWidth", "TextBoxHeight", and "text_offset", since you're not offsetting the box.

#

But if I change the box width and border width, I assume I need to grab all the posters again (and delete the existing ones?)

fresh gorge Feb 27, 2024, 8:39 PM

#

I think we are offsetting the box. The text then gets centered within the box

#

Centered horizontally and vertically

proud seal Feb 27, 2024, 8:40 PM

#

Or read the readme 🤭

modern pebble Feb 27, 2024, 8:40 PM

#

or that... LOL

fresh gorge Feb 27, 2024, 8:41 PM

#

Readme?

#

lol who reads that?

modern pebble Feb 27, 2024, 8:42 PM

#

I gave it a quick perusal

#

Who's the better provider for posters? Fanart or TMDB? Or does it really matter? I did a partial run yesterday and I think I liked the fanart stuff better so I set that as the fav provider.

fresh gorge Feb 27, 2024, 8:45 PM

#

Tmdb

proud seal Feb 27, 2024, 8:45 PM

#

I have set it to tmdb, but do what you like more, it will fallback to tmdb if textless not available on fanart

fresh gorge Feb 27, 2024, 8:45 PM

#

In the long run tmdb is way more flexible

#

If you want to contribute to textless art, tmdb is the way to go

#

If you don't mind that sometimes people upload text art to tmdb and forget to classify it and then you end up with art and text on it, tmdb

#

You can easily go and move that art with text to the right language and then the script won't end up with false positives

fresh gorge Feb 28, 2024, 5:36 AM

#



magick.exe -size 2000x3000 xc:white -gravity south -background None ( -background lightblue -fill blue -font ""C:\\Users\\bullmoose20\\PosterMaker\\temp\\Comfortaa-Medium.ttf"" -pointsize 210 -size 1090x500 -gravity south caption:"ALEX RIDER" ) -geometry +0+300 -composite output_image.png

To help illustrate the box and height and width and offset

The box size I chose was 1090x500 and the offset from bottom was 300

First command will determine the optimal size based on font and size of box. The size found in my setup is 210 for ALEX RIDER. The second command takes that point size and places the text on the image

#

#

This can then help you decide which overlays and whether the ribbon and other overlays fit.

#

@modern pebble @rare tulip uparrow

#

magick.exe -size 1800x600 -font "C:\\Users\\bullmoose20\\PosterMaker\\temp\\Comfortaa-Medium.ttf" -gravity center -fill black caption:"ALEX RIDER" -format "%[caption:pointsize]" info:
Gives me 297

#

#

magick.exe -size 2000x3000 xc:white -gravity south -background None ( -background lightblue -fill blue -font ""C:\\Users\\bullmoose20\\PosterMaker\\temp\\Comfortaa-Medium.ttf"" -pointsize 297 -size 1800x600 -gravity south caption:"ALEX RIDER" ) -geometry +0+300 -composite output_image2.png

fresh gorge Feb 28, 2024, 6:25 AM

#

@proud seal we may want to consider using center instead of south with the magick commands to properly center the text in the box.

proud seal Feb 28, 2024, 9:38 AM

#

for adjusting overlays and such things, i found south the better option, cause you know even for short text where it lands, if it gets centered inside this box too, it makes it harder to find the correct offset.

proud seal Feb 28, 2024, 11:24 AM

#

fresh gorge So the user decides what language they want. There is nothing out there like tha...

now it is, added in latest 🙂 config also needs an update for that, if not set - the script defaults to xx,en,de

fresh gorge Feb 28, 2024, 1:22 PM

#

proud seal for adjusting overlays and such things, i found south the better option, cause y...

Sure thing. This is why I only mentioned "consider". 🙂

#

What about a -Test mode that does one thing.... produces a test output based on the settings in the config. Essentially producing one output with zero images and just the overlay, border settings, text settings, and the blue box so people can "see" what happens before applying it to all the downloads?

proud seal Feb 28, 2024, 1:28 PM

#

good idea

fresh gorge Feb 28, 2024, 1:29 PM

#

And I would not make it a white box. Keep that part transparent just like the output.

#

You pick your favourite movie. Or maybe you pick your favorite "short text movie" and favourite "long text movie"

#

So -Test produces 2 images only.

fresh gorge Feb 28, 2024, 1:31 PM

#

proud seal now it is, added in latest 🙂 config also needs an update for that, if not set -...

Let me go review the readme to determine how this actually works.

fresh gorge Feb 28, 2024, 1:49 PM

#

Suggestion for readme:

If its set to xx the script will focus on grabbing textless posters, if you set en to the beginning it will focus on grabbing en.```

Is there a limit? Can we put just 1? Can we put 10? What is the proper 2 digit code to use? Is it <https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2>? upper case or lower case?(Seems like lower, but maybe specify case in the readme)?

#

proud seal Feb 28, 2024, 2:15 PM

#

there is an example of it in readme and in config? 😄

#

no limit

#

and it differs on the providers, but it should work with "en" "de" "ru" on fanart and tmdb
tvdd uses "eng" "deu" "rus" but i specified "en*" so it gets matched too, so just the 2 char of lang should be the way to go.

#

but i adjusted the readme., the error you get there is strange, looks like the git pull failed, try to copy the script again.

#

@fresh gorge sry my fault, a "#" too much, should be fixed

fresh gorge Feb 28, 2024, 2:46 PM

#

ok. so we might just want to clarify the iso code to use with the reference. Some people will put all kinds of weird things...

proud seal Feb 28, 2024, 2:55 PM

#

already added to readme

fresh gorge Feb 28, 2024, 3:33 PM

#

#

interesting how the "season" ends up being MINISERIES?

#

Its what is found in the csv, so I guess its normal

proud seal Feb 28, 2024, 3:46 PM

#

hmm strange 😄

proud seal Feb 28, 2024, 4:24 PM

#

Any errors during test run with prefered language as en?

fresh gorge Feb 28, 2024, 4:25 PM

#

I am still trying xx,en,de

#

will try en,xx,de next

fresh gorge Feb 28, 2024, 4:57 PM

#

there are issues... I will share shortly... but essentially, the seasons are not getting downloaded

proud seal Feb 28, 2024, 4:57 PM

#

With xx? Or with en?

#

Because if textless is prefered, the parts are unchanged and should works as before🤔

fresh gorge Feb 28, 2024, 5:04 PM

#

en,xx,de

#

let it finsih and I can share

#

only 65 images were created... show poster only

#

📎 ImageMagickCommands.log 📎 PlexLibexport.csv 📎 PosterChoices.csv 📎 Scriptlog.log

#

fyi, for troubleshooting, you might want to add the results of the settings from config.json (minus the keys) so that the log file has everything in there and we know what values the user used.

proud seal Feb 28, 2024, 5:24 PM

#

I will have a look tomorrow - in my testlibs it created show, season and movie poster in en 🤔

modern pebble Feb 28, 2024, 6:39 PM

#

fresh gorge `magick.exe -size 1800x600 -font "C:\\Users\\bullmoose20\\PosterMaker\\temp\\Com...

I found a box size of 1425 and a max font size of 125 and increasing the text offset to +400 allows 99.9% of the overlays to use the ribbon without the text being covered. I tried a max font size of 150 but it wrapped the text too early for my liking.

#

Default box/text sizes

fresh gorge Feb 28, 2024, 6:39 PM

#

It will depend on your font

modern pebble Feb 28, 2024, 6:39 PM

#

New settings

fresh gorge Feb 28, 2024, 6:40 PM

#

and if you use ALL CAPS or not

modern pebble Feb 28, 2024, 6:41 PM

#

I still want to play around with it a bit. I was using the arial bold font but switch to just arial. This will probably keep me busy for weeks LOL

fresh gorge Feb 28, 2024, 6:46 PM

#

I am an "ALL CAPS" kind of person for this stuff...

#

And if you use collections from our defaults, then ComfortAa-Medium is the font to use and in ALL CAPS to have a similar and consistent view across libraries and collections

modern pebble Feb 28, 2024, 7:18 PM

#

fresh gorge And if you use collections from our defaults, then ComfortAa-Medium is the font ...

I'll try that combination, thanks for the suggestion

fresh gorge Feb 28, 2024, 7:19 PM

#

#

#

thats using a custom gradient

#

#

gradient used here: uparrow

modern pebble Feb 28, 2024, 7:20 PM

#

What's your settings on those?

fresh gorge Feb 28, 2024, 7:20 PM

#

oh... I am messing around... but if you want to know...

#

    "OverlayPart":{
      "ImageProcessing": "true",
      "fontAllCaps": "true",
      "AddBorder": "false",
      "AddText": "true",
      "AddOverlay": "true",
      "fontcolor": "white",
      "bordercolor": "white",
      "minPointSize": "100",
      "maxPointSize": "250",
      "borderwidth": "30",
      "MaxWidth": "1300",
      "MaxHeight": "500",
      "text_offset": "+300"

modern pebble Feb 28, 2024, 7:23 PM

#

I was worried about decreasing the box width and you're running 125px narrower than I am!

fresh gorge Feb 28, 2024, 7:23 PM

#

like I said... I am messing around

modern pebble Feb 28, 2024, 7:23 PM

#

I do like the all caps, it looks larger.

fresh gorge Feb 28, 2024, 7:23 PM

#

and recall that the fonts will also impact results

#

i will share a collage so that you can grab and zoom in to see the results

#

modern pebble Feb 28, 2024, 7:28 PM

#

So you don't do any other overlays?

fresh gorge Feb 28, 2024, 7:28 PM

#

no... not saying that... the above is strictly in terms of the PPM tool

#

I have way too many overlays for me to use text and overlay

#

#

hmm... i wonder why i am missing hte looney tunes ones...

#

in the earlier collage

#

rerunning and its now finding the fanart for looney tunes

modern pebble Feb 28, 2024, 7:34 PM

#

Made some changes, I'm going to let it run and see how they look. Thanks for the tips!

fresh gorge Feb 28, 2024, 7:34 PM

#

YW

modern pebble Feb 28, 2024, 10:56 PM

#

If a poster with text exists and a new poster without text is uploaded, will it grab the textless poster on the next run?

fresh gorge Feb 28, 2024, 10:59 PM

#

You need to delete the text poster locally and then yes

#

However, tmdb can take up to 8 hours before api sees the changes

modern pebble Feb 28, 2024, 11:03 PM

#

I'm really liking the posters with the all caps. I think I got the spacing just right as the ribbon isn't covering any text (that I could find). I might need to go a bit darker on the gradient overlay, but still very pleased with the results.

#

urban nebula Feb 29, 2024, 4:18 AM

#

Is code base for this tool open source at all? Would love to have a look to see how everything is working if so

proud seal Feb 29, 2024, 5:28 AM

#

urban nebula Is code base for this tool open source at all? Would love to have a look to see ...

It is 👍
https://github.com/fscorrupt/Plex-Poster-Maker

GitHub

GitHub - fscorrupt/Plex-Poster-Maker: Automated poster maker for Pl...

Automated poster maker for Plex. (PPM). Contribute to fscorrupt/Plex-Poster-Maker development by creating an account on GitHub.

urban nebula Feb 29, 2024, 5:38 AM

#

Legend thanks! Trying to brush up on PS skills for work so figured I’d have a look to try to understand what is going on and grab some tips lol

proud seal Feb 29, 2024, 5:39 AM

#

Good Luck 😄

proud seal Feb 29, 2024, 9:56 AM

#

Testing Mode added: https://github.com/fscorrupt/Plex-Poster-Maker?tab=readme-ov-file#testing-mode

proud seal Feb 29, 2024, 10:55 AM

#

fresh gorge fyi, for troubleshooting, you might want to add the results of the settings from...

also added:

fresh gorge Feb 29, 2024, 12:34 PM

#

Nice!

#

Did you have a chance to see why things don't fully work for seasons when I use en, xx, de?

proud seal Feb 29, 2024, 12:35 PM

#

fresh gorge Did you have a chance to see why things don't fully work for seasons when I use ...

could not reproduce that error, but found a possible bug, that is also fixed in latest, you could try again.

fresh gorge Feb 29, 2024, 12:48 PM

#

Ok. I will try it all out

#

Ok... feedback time. 😉

#

I read the readme... you specify two modes, manual, automatic... and then down below you mention testing mode. I recommend adding the testing mode option above as well.

Secondly, rather than include test image.png, use the magick command to create the file.

Thirdly, if someone is testing with white borders, having a white image is an issue. Not sure if your -Testing uses all settings from the config.json file. And if so, that would mean applying the gradient and border settings if applicable. So I'd suggest that the test image.png that is created is something like magick.exe -size: 2000x3000 xc: transparent background none .\\temp\\TestImage.png

#

The bug where seasons is not pulled is still there

proud seal Feb 29, 2024, 1:02 PM

#

fresh gorge The bug where seasons is not pulled is still there

then there maybe is no season poster for this lang?

fresh gorge Feb 29, 2024, 1:03 PM

#

proud seal then there maybe is no season poster for this lang?

I wish I could say that, but 100% of all 65 shows is not downloading 1 "en" image

#

And I know they have en images because they were poisoning the textless ones when I was starting all of this...

#

I will share the logs

proud seal Feb 29, 2024, 1:06 PM

#

how can it be that i can create over 2000 pics with en, and you dont? 😄

mystic juncoBOT Feb 29, 2024, 1:09 PM

#

The following was shared by @fresh gorge and was automatically redacted by Luma as it may have contained sensitive information.

If you feel this message should not have been redacted, resend it with !noredact in your message to avoid redaction.

#

#

📎 PlexLibexport.csv

#

📎 PosterChoices.csv

#

📎 Scriptlog.log

#

📎 ImageMagickCommands.log

fresh gorge Feb 29, 2024, 1:10 PM

#

#

Strange that message at the end... the green line is 100% accurate

#

Not the expected outcome, but accurate

#

The 307 is not accurate... I'd focus in the season section of the script.

#

And now the log has my settings so you can use my exact settings to see why my little library is causing so many issues. :-p

rare tulip Feb 29, 2024, 1:17 PM

#

fresh gorge And if you use collections from our defaults, then ComfortAa-Medium is the font ...

Same here! I also use the Comfortaa font in all caps. I think it is easier to read

fresh gorge Feb 29, 2024, 1:25 PM

#

magick.exe -size 2000x3000 xc:transparent -background None ..\..\PosterMaker\Testimage.png

fresh gorge Feb 29, 2024, 1:35 PM

#

fresh gorge `magick.exe -size 2000x3000 xc:transparent -background None ..\..\PosterMaker\T...

magick.exe -size 2000x3000 xc:pink -background None .\Testimage.png

And use the border settings, and the overlay. Transparent png seems to be problematic in test mode.
I'd also dump the output files into ./test instead of mixing it up with the ./temp files

#

This way is someone wants to test with their own kids Verla's file and border settings, they will see the results in the output files

#

$response = (Invoke-WebRequest -Uri "https://api.themoviedb.org/3/tv/$($global:tmdbid)/season/$global:SeasonNumber/images?append_to_response=images&language=xx&include_image_language=en,null,de" -Method GET -Headers $global:headers -ErrorAction SilentlyContinue).content | ConvertFrom-Json -ErrorAction SilentlyContinue

#

I'm wondering why this is hardcoded?

#

Shouldn't that be a variable that is passed based on the value of what is in config.json?

#

Line 272

#

function GetTMDBSeasonPoster {

#

From what I see there, it's impossible that it works for you

proud seal Feb 29, 2024, 1:51 PM

#

fresh gorge From what I see there, it's impossible that it works for you

it only triggers if ($global:PreferTextless -eq 'True')

#

#

you mean like this? 😄

fresh gorge Feb 29, 2024, 1:53 PM

#

Is that what the image looks like with your overlay.png?

proud seal Feb 29, 2024, 1:54 PM

#

yep

fresh gorge Feb 29, 2024, 1:54 PM

#

On a pink image?

#

I think maybe it's the way we create it

#

Maybe that background "none" is messing it up

proud seal Feb 29, 2024, 1:55 PM

#

yep with blue background on texbox

fresh gorge Feb 29, 2024, 1:57 PM

#

The other option is making the testimage a jpg which should remove all the layers so you are starting with something that is exactly like a downloaded tmdb jpg.

#

magick.exe -size 2000x3000 xc:pink .\PosterMaker\Testimage.jpg

proud seal Feb 29, 2024, 2:00 PM

#

proud seal you mean like this? 😄

it does create it the right way everything is applied

#

boarder, overlay, text, textbox

fresh gorge Feb 29, 2024, 2:01 PM

#

This line does not work: Invoke-WebRequest -uri "https://github.com/fscorrupt/Plex-Poster-Maker/raw/main/testimage.png" -OutFile $global:ScriptRoot\temp\testimage.png

#

Likely because the case sensitive nature of GitHub

proud seal Feb 29, 2024, 2:02 PM

#

removed that part in latest

fresh gorge Feb 29, 2024, 2:02 PM

#

Ok. Have a meeting now and will test new version in a bit

proud seal Feb 29, 2024, 2:10 PM

#

fresh gorge And now the log has my settings so you can use my exact settings to see why my l...

Gonna have a look tomorrow 🥲

fresh gorge Feb 29, 2024, 6:51 PM

#

Did you mean to name the bold files CAPS?

#

Like all the *bold.jpg" are the ones that are all CAPS

proud seal Feb 29, 2024, 6:52 PM

#

Oh good catch 🤣

fresh gorge Feb 29, 2024, 6:52 PM

#

Ok. Just checking. That's an easy fix

#

Test folder and my crazy settings are working

#

fresh gorge Feb 29, 2024, 10:43 PM

#

Summary and not Summery

fresh gorge Feb 29, 2024, 11:07 PM

#

Been trying to troubleshoot the reason why season posters are not download. I do not know why yet.

modern pebble Feb 29, 2024, 11:14 PM

#

fresh gorge Been trying to troubleshoot the reason why season posters are not download. I do...

This might sound dumb but in your scriptlog you posted above it has this: Create Season Posters: false

#

Maybe that's why?

fresh gorge Feb 29, 2024, 11:18 PM

#

Oh.... ???

#

#

#

So my config says true but logs say false

#

But logs also show that it's attempting to download season posters and unable to

#

modern pebble Feb 29, 2024, 11:23 PM

#

Mine says true also but the logs also show true.

fresh gorge Feb 29, 2024, 11:24 PM

#

Flip it from xx,en to en,xx

#

When I prefer textless, season posters are downloaded

#

When I prefer en, then season posters don't download

modern pebble Feb 29, 2024, 11:33 PM

#

I changed it to en, xx then deleted an asset directory for a TV show, ran the script and it downloaded new art work for the series and the seasons. Then I did it again and got the same results.

fresh gorge Feb 29, 2024, 11:34 PM

#

Strange

#

You are using folders... hmmm

#

Let me try folders and see

modern pebble Feb 29, 2024, 11:36 PM

#

Just swapped back to xx, en and it grabbed textless series and season posters

#

Also just did a git pull to make sure I had latest, which I do.

fresh gorge Feb 29, 2024, 11:43 PM

#

I think my issue was that the terminal I was working in got hosed. Started a new terminal and things seem to be better

fresh gorge Mar 1, 2024, 3:09 AM

#

modern pebble Just swapped back to xx, en and it grabbed textless series and season posters

Definitely a bug to me

#

Essentially, those should be two different variables to report what is written in the config.json file

modern pebble Mar 1, 2024, 3:11 AM

#

fresh gorge Essentially, those should be two different variables to report what is written i...

Just looking at it, I'd agree, but I know next to nothing about programming.

fresh gorge Mar 1, 2024, 3:12 AM

#

should likely be this:

#

Write-log -Subtext "| Create Library Folders:   $LibraryFolders" -Path $configLogging -Type Info
Write-log -Subtext "| Create Season Posters:    $global:SeasonPosters" -Path $configLogging -Type Info

#

at line 931

proud seal Mar 1, 2024, 5:32 AM

#

Ah thanks, good catch.
So it now works with en langugae for you too?

fresh gorge Mar 1, 2024, 12:28 PM

#

Yes it does. Was a terminal window that was just messed up after having run about 10 different versions of ppm

proud seal Mar 1, 2024, 12:29 PM

#

😄 good

fresh gorge Mar 1, 2024, 12:29 PM

#

Yeah...for sure

proud seal Mar 1, 2024, 12:34 PM

#

now its time to work on integration of TPDB 😄

fresh gorge Mar 1, 2024, 12:40 PM

#

No api, right?

proud seal Mar 1, 2024, 12:43 PM

#

without api yeah

fresh gorge Mar 1, 2024, 12:44 PM

#

Here are 2 additional ideas...

Point ppm to a folder of images and sub folders of images and have it apply the overlays/text/border settings but into a new output directory so it does not overwrite the source

#

Another source in addition to fanart and tmdb, and tvdb, and IMDb could be to use Plex as the source... selected posters in Plex

proud seal Mar 1, 2024, 12:57 PM

#

I thought about mass processing of images in a folder, but to be useful for the user he would have to name them manually before/after the processing in order to be useable in pmm.

#

Plex as source would only make sense if no pmm is in place.

fresh gorge Mar 1, 2024, 1:13 PM

#

proud seal Plex as source would only make sense if no pmm is in place.

Someone wants to add a border only

#

Or change the color of their border

fresh gorge Mar 1, 2024, 1:14 PM

#

proud seal I thought about mass processing of images in a folder, but to be useful for the ...

That's for them to decide... you just replicate name and folder structure in the output folder

#

Bad source naming equals bad naming in output.

#

How about grabbing backgrounds? PMM applies backgrounds... not sure about applying overlays to backgrounds but that would also be a good to grab and stuff into the output folder

#

Episode cards are also available on tmdb so that could be stuffed as well into the assets directory

#

This way you would have a complete "assets" directory

#

Movies, shows, seasons, episodes, backgrounds

#

Backgrounds I would only apply a resize. No text or borders

#

We'd need to know the official Plex background dimensions

#

Episode cards are an area where I would offer all options as posters but would require different height and width for the box as it is landscape and not portrait. We'd need the official size of episode cards as well to resize them.

#

And likely a different overlay file to respect the dimensions of the episode cards

#

Pretty sure 1920x1080 or 3840x2160 would be correct for background and episode cards

modern pebble Mar 1, 2024, 3:09 PM

#

fresh gorge Pretty sure 1920x1080 or 3840x2160 would be correct for background and episode c...

1920x1080 or 3840x2160 (16:9)

fresh gorge Mar 1, 2024, 4:25 PM

#

Yeah... I can't multiply... lol

#

fixed now to 3840x2160

proud seal Mar 1, 2024, 4:33 PM

#

Currently i Fokus on posters, for episodes there is tcm

fresh gorge Mar 1, 2024, 4:38 PM

#

well... so there are people that use gap, there are people that use tcm, there are people that now use ppm, and there are people that are using other stuff as well....

If the focus is to get/create a complete assets directory that is "clean" and without anything applied so that you can always then decide how you want to alter images, ppm could meet that need very nicely when you don't apply overlay/border/text

#

tcm still needs a source of images if I recall

proud seal Mar 1, 2024, 4:42 PM

#

That's true, but it would take a lot of time to integrate all this, and makes things even more complicated.

#

Before i start integration other things i want to integrate all needed providers for posters

modern pebble Mar 1, 2024, 4:51 PM

#

I briefly looked at tcm but there was something that stopped me from going any farther (not sure if you needed an invite to grab the code?). I then saw this and I think you've done a great job with it!

fresh gorge Mar 1, 2024, 4:55 PM

#

proud seal Before i start integration other things i want to integrate all needed providers...

of course... just throwing ideas out there and seeing what sticks

#

what other providers were you thinking of? I guess tpdb, although they are currently rate limiting and they dont have am api which could mean lots more to break on your side?

proud seal Mar 1, 2024, 4:59 PM

#

Currently only tpdb is on my agenda, its possible without api, just web requests, i thought to add the user names some likes to grap posters from, also text or textless option is available, and then on first script run i cache all posters from the users with posterid and name, later and on other script runs i then just appens those who where created recently by the user, this would speed up the search for tpdb, cause if i do not cache it, it has to go thrrew each page til it finds that show or movie 😅

fresh gorge Mar 1, 2024, 5:00 PM

#

i think that we also had some people use other providers when tpdb was down

proud seal Mar 1, 2024, 5:03 PM

#

could be yeah

fresh gorge Mar 1, 2024, 5:04 PM

#

https://mediux.pro/

#

thats the one that i found some people were using

#

i dont know much about it

proud seal Mar 1, 2024, 5:09 PM

#

looks good, but no api and login required :/

fresh gorge Mar 1, 2024, 7:17 PM

#

ahhh... there you go... I was not sure

#

PR submitted to replace Summery with Summary

fresh gorge Mar 1, 2024, 7:47 PM

#

fresh gorge Mar 1, 2024, 8:33 PM

#

Also added the "Included" libs as part of the logging as we only show the excluded.
https://github.com/fscorrupt/Plex-Poster-Maker/pull/9/files

covert eagleBOT Mar 1, 2024, 8:33 PM

#

fscorrupt/Plex-Poster-Maker

Pull Request #9 | Update PlexPosterMaker.ps1

update Summery to Summary

State:

Open

Comments:

0

Review Comments:

0

Commits:

3

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

False

Mergeable State:

Unknown

Labels:

``

Modifications:

+10
1
-8

fresh gorge Mar 1, 2024, 8:52 PM

#

I also started to look into adding the query to grab the backgrounds... and quickly got overwhelmed... realising that we'd need to create a separate backgroundUrl instead of posterUrl... and then realising that the resize was not a function, so all the 2000x3000 lines (and there are a lot... like 20) would need to be duplicated as 3840x2160 for backgrounds... but in doing so, would make maintaining this even more difficult... so I stopped..

#

📎 message.txt

#

was really easy to create this function as it required minimal edits for it to grab backgrounds

#

likely pretty easy to do the same for fanart, and tvdb. Maybe not possible for IMDb.

#

Its all the other logic that is worrying me

proud seal Mar 1, 2024, 9:23 PM

#

fresh gorge Its all the other logic that is worrying me

The code has grown by 1700 lines in the last 20 days 😅

#

The background, episode part has to be seperated like the season part first show/movie poster, then background, then season then episode poster

#

Im already working on a imagemagick function to simplify this process

#

But i do not have a lot time the next weeks, vacation is over 🥹

fresh gorge Mar 1, 2024, 9:52 PM

#

proud seal The code has grown by 1700 lines in the last 20 days 😅

indeed it has...

#

If you look at the PR I submitted, its pretty harmless... typos and an additional logging line to share the libraries that are included in the output

proud seal Mar 1, 2024, 10:04 PM

#

fresh gorge If you look at the PR I submitted, its pretty harmless... typos and an additiona...

Merged zoro

fresh gorge Mar 1, 2024, 10:24 PM

#

I do what I can. 😉

#

#

Consider that for moives you dump a null instead of System.String[] into that column

proud seal Mar 1, 2024, 10:36 PM

#

Looks like a you problem, it only gets data if there is data in plex 😅

#

On my movie libs, this is always empty

fresh gorge Mar 1, 2024, 10:40 PM

#

hmmm...

#

if the $Metadata.MediaContainer.$contentquery.type != "show" shouldnt it just be null?

#

in any case I think I see the bug

#

just testing

#

FIXED

#

Let me PR the fix

#

basically... because seasons get processed first, the last value stays within the 4 season variables.... setting them to null at the beginning of the script ensured that when teh csv is created, it works

#

#

$SeasonNames = $null
$Seasondata = $null
$SeasonsTemp = $null
$SeasonNumbers = $null

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/10

covert eagleBOT Mar 1, 2024, 10:57 PM

#

fscorrupt/Plex-Poster-Maker

Pull Request #10 | Update PlexPosterMaker.ps1 to set 4 season vars to $null

N/A

State:

Open

Comments:

0

Review Comments:

0

Commits:

1

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

False

Is Mergeable:

True

Mergeable State:

Clean

Labels:

``

Modifications:

+5
1
-0

proud seal Mar 1, 2024, 11:03 PM

#

For you, cause you have a strange cache issue in your powershell, if the script is started in a fresh session the variables do not exist before 😅

fresh gorge Mar 1, 2024, 11:05 PM

#

If you run it multiple times, I suspect the same will happen

#

and I mean.. in the same window

#

I also saw it running in vscode and happening there

#

its probably best practice to always set variables to $null as you start the app

#

kinda like the days of adding Option Explicit to vba and vbscripts

#

add Set-StrictMode -version 2
to line 5 and watch what happens....

#

for example, look at what happens here:

#

not a huge deal but it would be best to set that variable

proud seal Mar 1, 2024, 11:27 PM

#

Thats more like an copy issue, that variBle is not set cause its not needed on subtext

#

This line can be removed, never got an error tho😅

fresh gorge Mar 1, 2024, 11:56 PM

#

I get it... just saying that I think that "some" of the problems are related to some variables abd their variables being set/cached from previous runs... by not resetting them upon start of the script, you can have things like this happen... like they happen to me.

#

And the "error" is seasons is not an error per se... its just adding a value that is not valid

#

Anyhow... I will just look for these little things and propose some fixes. You can accept or not those and move on... no biggie.

fresh gorge Mar 2, 2024, 12:19 AM

#

FYI:

#

when you run script twice, back to back... since the first time, the script gets everything, PosterChoices.csv exists and there are no errors

#

if you rerun, since nothing is found or downloaded, PosterChoices.csv does not exist and then you get this

modern pebble Mar 2, 2024, 12:30 AM

#

I would concur that you need to initialize all variables before use so they don't have unpredictable values. That way, if you run the script 100 times over and over, you get predictable results.

fresh gorge Mar 2, 2024, 2:18 AM

#

fresh gorge if you rerun, since nothing is found or downloaded, PosterChoices.csv does not e...

https://github.com/fscorrupt/Plex-Poster-Maker/pull/11/files

covert eagleBOT Mar 2, 2024, 2:18 AM

#

fscorrupt/Plex-Poster-Maker

Pull Request #11 | Update PlexPosterMaker.ps1 to see if PosterChoices.csv

N/A

State:

Open

Comments:

0

Review Comments:

0

Commits:

1

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

False

Is Mergeable:

True

Mergeable State:

Clean

Labels:

``

Modifications:

+2056
1
-2054

fresh gorge Mar 2, 2024, 2:19 AM

#

PR kinda srrange since I only added a file check

#

    Write-log -Message "Finished, Total posters created: $posterCount | Total Season Posters created: $SeasonCount" -Path $global:ScriptRoot\Logs\Scriptlog.log -Type Success
    if ((Test-Path "$global:ScriptRoot\Logs\PosterChoices.csv")) {
        Write-log -Message "You can find a detailed Summary of Poster Choices here: $global:ScriptRoot\Logs\PosterChoices.csv" -Path $global:ScriptRoot\Logs\Scriptlog.log -Type Info
        # Calculate Summary
        $SummaryCount = Import-Csv -LiteralPath "$global:ScriptRoot\Logs\PosterChoices.csv" -Delimiter ';'
        $FallbackCount = @($SummaryCount | Where-Object Fallback -eq 'True')
        $TextlessCount = @($SummaryCount | Where-Object Textless -eq 'True')
        $TextTruncatedCount = @($SummaryCount | Where-Object TextTruncated -eq 'True')
        $TextCount = @($SummaryCount | Where-Object Textless -eq 'False')    
    }

Around line 2020

modern pebble Mar 2, 2024, 2:48 AM

#

Well that's a mess!

fresh gorge Mar 2, 2024, 6:07 AM

#

How do you mean?

#

Formatting issue possibly?

proud seal Mar 2, 2024, 12:52 PM

#

Background image processing is added in latest

fresh gorge Mar 2, 2024, 2:24 PM

#

proud seal Background image processing is added in latest

Holy guacamole! Gonna check that out right away.

fresh gorge Mar 2, 2024, 3:04 PM

#

#

A couple of questions:
1- I saw that you removed the two lines at the top to remove-variable and clear. Was that causing a problem or not doing anything?
2-I see that you added the ability to add text and overlay. However because of the orientation and dimensions of the overlay file, I think we either need to resize the current overlay or reference an backgroundOverlay variable?

#

So maybe a resize on the overlay file would be best so that you don't need an extra variable in config.json

#

And then in the script, when applying the overlay to a landscape background, it references the temp resized overlay file.

#

I also think that you added the poster choices.csv check at the end so you can kill my PR.

proud seal Mar 2, 2024, 3:09 PM

#

1st, yeah it also cleared the params and testing mode was not possible anymore 😅

Maybe possible for your overlay, if i want to do it with mine it would strech it to look ugly, second overlay is the way i think, also when adding title cards as well then a second overlay would be handy

fresh gorge Mar 2, 2024, 3:10 PM

#

Oh? I figured a gradient stretch would not look bad, but no idea

#

And yes, I guess the most flexible is adding a separate overlay

proud seal Mar 2, 2024, 3:11 PM

#

In 3h im at the pc, then i can make the changes for it.

fresh gorge Mar 2, 2024, 3:13 PM

#

I think you may want to consider an overlay dimension check. If the dimensions of the overlay is not 2000x3000, post a warning/error to the logs. If landscapeOverlay dimensions is not 3840x2160, post a warning/error to the logs

proud seal Mar 2, 2024, 3:13 PM

#

fresh gorge I think you may want to consider an overlay dimension check. If the dimensions o...

Good idea👍

fresh gorge Mar 2, 2024, 3:14 PM

#

Have a great day. So far this version looks like it's working great. I will post things if I find anything.

#

Oh.... this one is probably a little more painful.... in landscape mode, the text box shape should probably be a different dimension because it's wider, so I would want to make it much wider and less height for the background/episode cards.

proud seal Mar 2, 2024, 3:17 PM

#

Yeah i will add for backgroud a seperate part in config.json

fresh gorge Mar 2, 2024, 3:19 PM

#

as an example of what i meant. Probably need a text_offset_landscape as well...

#

-testing should now include landscape tests as well.

proud seal Mar 2, 2024, 3:30 PM

#

Yep, i know what you mean, adding it today 👍

fresh gorge Mar 2, 2024, 3:31 PM

#

No problem... just posting my findings here.

modern pebble Mar 2, 2024, 3:31 PM

#

fresh gorge How do you mean?

I meant I saw the pull request on github and it was a mess.

fresh gorge Mar 2, 2024, 3:31 PM

#

modern pebble I meant I saw the pull request on github and it was a mess.

Yeah I screwed something up.

#

That's why I told FSCorrupt to kill it when he has a chance

#

The more I think about config.json, the more I think we might want to have a section called OverlayPartBackground

Right now, there is no way to apply text to poster, but not to the background.

#

It's both or none.

#

I take that back

#

Having them as separate parts would just make it easier to know what is being applied

#

And how per type

modern pebble Mar 2, 2024, 3:45 PM

#

The text box size on the background needs to be addressed. Possibly the offset as well.

proud seal Mar 2, 2024, 3:46 PM

#

Yep, adding this as config part in the evening

fresh gorge Mar 2, 2024, 4:29 PM

#

modern pebble The text box size on the background needs to be addressed. Possibly the offset ...

1- I think we'll end up with a separate section for background in the config.json that will offer all the same settings as the poster section thus giving you total control.
2- -testing for background
3- overlaybackground.png added to repo
4- poster and background dimensions validator

#

To minimize scrolling... 😉

modern pebble Mar 2, 2024, 5:30 PM

#

I've noticed that when it can't find a background that there is no separation line "-------" between the current background search and the next one (both onscreen and in the logs).

#

Happens with posters, too.

fresh gorge Mar 2, 2024, 5:48 PM

#

Screenshot illustrating that could be helpful

#

In this case, since backgrounds are part of the numbers, should the word images be used instead of posters? Or maybe different/additional stats per image type should be reported? Season fallback versus movie fallback versus season background fallback versus movie background fallback?

modern pebble Mar 2, 2024, 6:06 PM

#

No separation between searches in the log

#

But it seems only when it can't find a poster/background

proud seal Mar 2, 2024, 6:56 PM

#

fresh gorge 1- I think we'll end up with a separate section for background in the config.jso...

everything except 4 added in latest.

fresh gorge Mar 2, 2024, 7:19 PM

#

proud seal everything except 4 added in latest.

Based on the new config.json, how would we apply text/border/overlay to posters, but NOT backgrounds?

proud seal Mar 2, 2024, 7:20 PM

#

set add overlay,text,boarder to false? 😄

fresh gorge Mar 2, 2024, 7:22 PM

#

Ahhhh yes! I feel silly.

proud seal Mar 2, 2024, 7:23 PM

#

modern pebble No separation between searches in the log

i think this should be fixed now.

modern pebble Mar 2, 2024, 7:29 PM

#

proud seal i think this should be fixed now.

It's not. Still only works on successful grabs. If it can't find a poster/background you get no separation line.

fresh gorge Mar 2, 2024, 7:30 PM

#

function Check-ImageDimensions {
    param(
        [string]$imagePath,
        [int]$expectedWidth,
        [int]$expectedHeight
    )

    $image = [System.Drawing.Image]::FromFile($imagePath)
    $actualWidth = $image.Width
    $actualHeight = $image.Height

    if ($actualWidth -eq $expectedWidth -and $actualHeight -eq $expectedHeight) {
        return $true
    } else {
        return $false
    }
}

# Example usage:
$width = 800
$height = 600
$imagePath = "C:\Path\To\Your\Image.jpg"

$result = Check-ImageDimensions -imagePath $imagePath -expectedWidth $width -expectedHeight $height
Write-Host $result

modern pebble Mar 2, 2024, 7:30 PM

#

Additionally, got this but the lines don't show in the log file.

fresh gorge Mar 2, 2024, 7:46 PM

#

Write-log -Subtext "| Script Root: $global:ScriptRoot" -Path configLogging -Type Info

Should probably be:
Write-log -Subtext "| Script Root: $global:ScriptRoot" -Path $configLogging -Type Info

proud seal Mar 2, 2024, 7:59 PM

#

modern pebble Additionally, got this but the lines don't show in the log file.

should be fixed now, and logging to, i do have a false count tho.. on it 😄

proud seal Mar 2, 2024, 7:59 PM

#

fresh gorge `Write-log -Subtext "| Script Root: $global:ScriptRoot" -Path c...

also changed

modern pebble Mar 2, 2024, 8:07 PM

#

proud seal should be fixed now, and logging to, i do have a false count tho.. on it 😄

I no longer get the error but there's still no separation between grab attempts.

proud seal Mar 2, 2024, 8:07 PM

#

what you mean with separation?

modern pebble Mar 2, 2024, 8:15 PM

#

This is how it looks with successful grabs

#

This is how it looks on unsuccessful grabs

proud seal Mar 2, 2024, 8:22 PM

#

ahhhhhh, okey

#

now you should be happy again, also the count issue is fixed

fresh gorge Mar 2, 2024, 8:48 PM

#

Let me go grab the latest

#

#

Because of that line, a file gets created in the ppm location.

#

proud seal Mar 2, 2024, 8:59 PM

#

Should be all sorted now

#

Tried title cards to, got headache and quited😂
This will take some time to integrate🥲

fresh gorge Mar 2, 2024, 9:14 PM

#

Here is another easy fix

mystic juncoBOT Mar 2, 2024, 9:15 PM

#

The following was shared by @fresh gorge and was automatically redacted by Luma as it may have contained sensitive information.

If you feel this message should not have been redacted, resend it with !noredact in your message to avoid redaction.

fresh gorge Mar 2, 2024, 9:15 PM

#

To fix this:

mystic juncoBOT Mar 2, 2024, 9:15 PM

#

if ($PlexToken) {
    Write-log -Subtext "| Plex Token: (redacted by Luma)
}
Else {
    Write-log -Subtext "| Plex Token: (redacted by Luma)
}

fresh gorge Mar 2, 2024, 9:16 PM

#

modern pebble Mar 2, 2024, 9:18 PM

#

Do the api tokens really need to be printed in the log, no matter how redacted?

modern pebble Mar 2, 2024, 9:21 PM

#

proud seal now you should be happy again, also the count issue is fixed

It's mostly fixed. Right in the middle there's a section where the separator is missing.

📎 Scriptlog.log

modern pebble Mar 2, 2024, 9:21 PM

#

fresh gorge

It's no longer creating the file.

fresh gorge Mar 2, 2024, 9:24 PM

#

!noredact

if ($PlexToken) {
    Write-log -Subtext "| Plex Token:                   $($PlexToken[0..7] -join '')****" -Path $configLogging  -Type Info
}
Else {
    Write-log -Subtext "| Plex Token:                   No Token in Config" -Path $configLogging  -Type Info
}

fresh gorge Mar 2, 2024, 9:29 PM

#

modern pebble Do the api tokens really need to be printed in the log, no matter how redacted?

Replace 0..7 with 0..1 and it will only show first character.

modern pebble Mar 2, 2024, 9:32 PM

#

fresh gorge Replace 0..7 with 0..1 and it will only show first character.

Sure that would work, but if it's there I'm not sure why it needs to be logged. If it's missing it would make more sense. Doesn't really matter to me either way but if you're going to redact it, why log it (so long as it's present). I'd think it would be more important to log it if the token is missing.

fresh gorge Mar 2, 2024, 9:51 PM

#

The reality is from a troubleshooting perspective, we can at least look and see part of the information... to see if the user may have put something or nothing in those fields... and avoids us asking for a redacted config.json file

#

# Plex Part
Write-log -Subtext "API Part" -Path $configLogging -Type Trace
Write-log -Subtext "| TVDB API Key:                 $($global:tvdbapi[0..0] -join '')**(redacted)**" -Path $configLogging -Type Info
Write-log -Subtext "| TMDB API Token:               $($global:tmdbtoken[0..0] -join '')**(redacted)**" -Path $configLogging -Type Info
Write-log -Subtext "| Fanart API Key:               $($FanartTvAPIKey[0..0] -join '')**(redacted)**" -Path $configLogging -Type Info
if ($PlexToken) {
    Write-log -Subtext "| Plex Token:                   $($PlexToken[0..0] -join '')**(redacted)**" -Path $configLogging  -Type Info
}
Else {
    Write-log -Subtext "| Plex Token:                   No Token in Config" -Path $configLogging  -Type Info
}
Write-log -Subtext "| Fav Provider:                 $global:FavProvider" -Path $configLogging  -Type Info
Write-log -Subtext "| Prefered Lang Order:          $($global:PreferedLanguageOrder -join ',')" -Path $configLogging  -Type Info
Write-log -Subtext "Plex Part" -Path $configLogging  -Type Trace
Write-log -Subtext "| Excluded Libs:                $($LibstoExclude -join ',')" -Path $configLogging -Type Info
Write-log -Subtext "| Plex Url:                     $($PlexUrl[0..10] -join '')**(redacted)**" -Path $configLogging -Type Info

modern pebble Mar 2, 2024, 9:52 PM

#

Yeah, I suppose that makes sense.

fresh gorge Mar 2, 2024, 9:56 PM

#

Another "easy" change.... 1 line that uses where should be Where-Object

#

Also the System.String[] issue came back... I will PR that fix along with the above

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/13 has bee submitted

covert eagleBOT Mar 2, 2024, 10:05 PM

#

fscorrupt/Plex-Poster-Maker

Pull Request #13 | Update PlexPosterMaker.ps1 to add fixes

Update PlexPosterMaker.ps1 to add initialize variables section and fix where to Where-Object

State:

Open

Comments:

0

Review Comments:

0

Commits:

1

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

False

Is Mergeable:

True

Mergeable State:

Clean

Labels:

``

Modifications:

+7
1
-1

fresh gorge Mar 3, 2024, 12:04 AM

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/14 Are some updates to the README file that I submitted a PR for

covert eagleBOT Mar 3, 2024, 12:04 AM

#

fscorrupt/Plex-Poster-Maker

Pull Request #14 | Update README.md

N/A

State:

Open

Comments:

0

Review Comments:

0

Commits:

1

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

False

Is Mergeable:

True

Mergeable State:

Clean

Labels:

``

Modifications:

+9
1
-8

fresh gorge Mar 3, 2024, 3:35 PM

#

Here is another PR for a new "feature": https://github.com/fscorrupt/Plex-Poster-Maker/pull/15

#

and a small PR for README: https://github.com/fscorrupt/Plex-Poster-Maker/pull/16

#

Hope your headache is better. 😉

proud seal Mar 3, 2024, 3:43 PM

#

fresh gorge Hope your headache is better. 😉

Not really, titlecards drive me crazy 😅

fresh gorge Mar 3, 2024, 3:47 PM

#

proud seal Not really, titlecards drive me crazy 😅

I wanted to add more to the readme around the testing section like an extra image for the background test images, however, since you link to imgur I decided it was best to allow you. BTW, why not keep those images on your GitHub?

#

Creating a sub folder off of the ppm folder called images and then just reference them from the readme.?

proud seal Mar 3, 2024, 4:12 PM

#

okey is changed

fresh gorge Mar 3, 2024, 4:48 PM

#

Did you want to add a testing image for background overlay?

proud seal Mar 3, 2024, 4:56 PM

#

i removed the check dimension function, it did not worked on my site

fresh gorge Mar 3, 2024, 5:11 PM

#

proud seal i removed the check dimension function, it did not worked on my site

Oh? I did quite a bit of testing...

#

I just submitted a small PR for README.md

fresh gorge Mar 3, 2024, 6:52 PM

#

[2024-03-03 11:25:12] INFO    | Start Poster Search for: Indiana Jones and the Kingdom of the Crystal Skull
[2024-03-03 11:25:12] TRACE   |      Searching on TMDB for a movie poster
[2024-03-03 11:25:12] SUCCESS |      Found Textless Poster on TMDB
[2024-03-03 11:25:13] INFO    |      Poster url: https://image.tmdb.org/t/p/original/yWA04fzkt4ChybmRGoRWKe90udd.jpg
[2024-03-03 11:25:13] DEBUG   |      Downloading Textless Poster from 'TMDB'
[2024-03-03 11:25:13] INFO    |      Processing Poster for: "INDIANA JONES AND THE KINGDOM OF THE CRYSTAL SKULL"
[2024-03-03 11:25:13] INFO    |      Resizing it | Adding Borders | Adding Overlay
[2024-03-03 11:25:16] WARNING |      Text truncated! optimalFontSize: 95 below min_pointsize: 100
[2024-03-03 11:25:16] INFO    |      Optimal font size set to: '100'
[2024-03-03 11:25:16] INFO    |      Applying Font text: "INDIANA JONES AND THE KINGDOM OF THE CRYSTAL SKULL"
[2024-03-03 11:25:17] INFO    |      --------------------------------------------------------------------------------
[2024-03-03 11:25:17] INFO    | Start Background Search for: Indiana Jones and the Kingdom of the Crystal Skull
[2024-03-03 11:25:17] TRACE   |      Searching on TMDB for a movie background
[2024-03-03 11:25:17] SUCCESS |      Found Textless background on TMDB
[2024-03-03 11:25:17] INFO    |      Poster url: https://image.tmdb.org/t/p/original/bXH4lyFS6tctnBgxK1eYRuwekR0.jpg
[2024-03-03 11:25:17] DEBUG   |      Downloading Textless background from 'TMDB'
[2024-03-03 11:25:17] INFO    |      Processing background for: "INDIANA JONES AND THE KINGDOM OF THE CRYSTAL SKULL"
[2024-03-03 11:25:17] INFO    |      Resizing it | Adding Borders | Adding Overlay
[2024-03-03 11:25:23] INFO    |      Optimal font size set to: '175'
[2024-03-03 11:25:23] INFO    |      Applying Font text: "INDIANA JONES AND THE KINGDOM OF THE CRYSTAL SKULL"

#

#

so the CSV shows that text was truncated for the background, however logs do not show that. I think this is a case of variable not being re-initialized before checking for optimalsize

modern pebble Mar 3, 2024, 7:13 PM

#

The log shows your minimum text size is 100 but it wanted to set it to 95 so it truncated it, if I'm reading that right.

fresh gorge Mar 3, 2024, 7:14 PM

#

modern pebble The log shows your minimum text size is 100 but it wanted to set it to 95 so it ...

Look at the background one... does not say it was truncated, but CSV does

modern pebble Mar 3, 2024, 7:15 PM

#

Ahh, ok.

proud seal Mar 3, 2024, 7:28 PM

#

https://github.com/fscorrupt/Plex-Poster-Maker/tree/main?tab=readme-ov-file#example-of-titlecards-after-creation

#

its live, happy creating 😛

proud seal Mar 3, 2024, 7:29 PM

#

fresh gorge so the CSV shows that text was truncated for the background, however logs do not...

also set it to null on the backgrounds, in latest

fresh gorge Mar 3, 2024, 7:34 PM

#

proud seal also set it to null on the backgrounds, in latest

README is gonna need some updates as its missing some sections related to the titlecards

proud seal Mar 3, 2024, 7:36 PM

#

hmm i thought ive added all relevant information 🤔
but i now need a break, coded 12h on this today ^^

#

See Ya tomorrow 😄

fresh gorge Mar 3, 2024, 7:45 PM

#

Yes. this looks great and will test...

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/18/files simple PR for the where to Where-Object fixes

mystic juncoBOT Mar 3, 2024, 11:08 PM

#

📎 PlexEpisodeExport.csv

#

📎 PlexLibexport.csv

#

📎 Scriptlog.log

#

📎 Testinglog.log

#

0 TitleCards

modern pebble Mar 4, 2024, 12:29 AM

#

I'm not really familiar with title cards. Is this supposed to download an episode image to make a title card or does the image already need to exist, or ??? I've run it and no title cards were made. Not sure if I'm doing something wrong.

fresh gorge Mar 4, 2024, 1:52 AM

#

#

looks like a remnant from your testing....

#

also, I dont think the data is getting pulled properly from the xml. In my xml, I dont see grandparenttitle... I do see parentTitle... but a bit further down, episodes are not captured, but rather seasons...

fresh gorge Mar 4, 2024, 2:36 AM

#

There are some logic issues around lines 2369 $tempseasondata = New-Object psobject
this keeps wiping out the information found and then does not download anything because it gets flushed before downloads occur.

#

also line 2361 needs to change to: [xml]$Seasondata = (Invoke-WebRequest $PlexUrl/library/metadata/$key/children?X-Plex-Token=$PlexToken).content

before you had $ratingKey which does not make sense as grandparentTitle did not exist and the else statement uses $key

fresh gorge Mar 4, 2024, 2:59 AM

#

and Iactually, I think that with those adjustments, the script starts to work again

fresh gorge Mar 4, 2024, 3:35 AM

#

Here is the PRhttps://github.com/fscorrupt/Plex-Poster-Maker/pull/20

fresh gorge Mar 4, 2024, 3:35 AM

#

modern pebble I'm not really familiar with title cards. Is this supposed to download an episo...

fixed in my PR

#

title cards are the 16:9 episode images in plex

#

#

fresh gorge Mar 4, 2024, 4:06 AM

#

Additional commit to the PRhttps://github.com/fscorrupt/Plex-Poster-Maker/pull/20:

Update PlexPosterMaker.ps1
replaced Middle with Medium
replaced Bold with CAPS
Applying <<type of text>> text: so make logging more clear```

proud seal Mar 4, 2024, 5:50 AM

#

fresh gorge

oh good catch, sorry for that 😅

#

PR is merged 👍

fresh gorge Mar 4, 2024, 5:51 AM

#

Still another little glitch with some counters, but I will share tomorrow. Related to title cards and truncated text

fresh gorge Mar 4, 2024, 1:43 PM

#

So I just noticed this today... the characters are showing really weird for some episodes. I don't think I saw this on the other csv files

#

Ok, forget that... looks like I need to fix my import into excel because csv in notepad ++ is fine

#

fresh gorge Mar 4, 2024, 2:37 PM

#

OK... so back to the original issue that I saw last night about counts and the csv and more....

[2024-03-04 01:58:24] TRACE   |      Searching on TMDB for: Family Guy 'Season 8 - Episode 21' Title Card
[2024-03-04 01:58:24] WARNING |      TMDB Api Response is null
[2024-03-04 01:58:24] TRACE   |      Searching on TVDB for a Title Card
[2024-03-04 01:58:24] OPTIONAL|      Found Textless Title Card on TVDB
[2024-03-04 01:58:24] INFO    |      Title Card url: https://artworks.thetvdb.com/banners/episodes/75978/2380591.jpg
[2024-03-04 01:58:24] DEBUG   |      Downloading Poster from 'TVDB'
[2024-03-04 01:58:24] INFO    |      Resizing it | Adding Borders | Adding Overlay
[2024-03-04 01:58:27] INFO    |      Optimal font size set to: '223'
[2024-03-04 01:58:27] INFO    |      Applying EPTitle text: "EPISODE 21"
[2024-03-04 01:58:29] INFO    |      Optimal font size set to: '81'
[2024-03-04 01:58:29] INFO    |      Applying SeasonEPNumber text: "SEASON 8 • EPISODE 21"
[2024-03-04 01:58:30] INFO    |      --------------------------------------------------------------------------------

Notice how the logs are not complaining at all about "Truncated", yet... in the ImageChoices.csv (3rd TRUE is for Truncation:

"S08E20 | SOMETHING, SOMETHING, SOMETHING, DARK SIDE";"Episode";"Family Guy (1999) [imdbid-tt0182576]";"TV Shows";"True";"False";"True";"https://image.tmdb.org/t/p/original/wx0EJqtfatuhCAXDGAK912b0hgU.jpg"
"S08E21 | EPISODE 21";"Episode";"Family Guy (1999) [imdbid-tt0182576]";"TV Shows";"True";"True";"True";"https://artworks.thetvdb.com/banners/episodes/75978/2380591.jpg"

#

📎 message.txt

#

almost like the subsequent episode is keeping the truncated flag when it should not

proud seal Mar 4, 2024, 2:42 PM

#

Hmm, i had also a few truncated during my last run, but after a truncated was found the next one did not had it set to true.

rare tulip Mar 4, 2024, 3:05 PM

#

getting this at the start but it seems to be running fine

#

Doh ! my bad... didn't update that line in the config LOL

fresh gorge Mar 4, 2024, 3:13 PM

#

proud seal Hmm, i had also a few truncated during my last run, but after a truncated was fo...

i will try to just perform a smaller subset to review what might be going on and provide less data

proud seal Mar 4, 2024, 3:16 PM

#

im starting a new run, can take a while - 33.000 episode posters ^^ 😄

fresh gorge Mar 4, 2024, 3:22 PM

#

I have a test library

#

I use that and then I can make the minfont size quite large to "force" truncation

#

the idea is to find the right number so that some pass and some fail

proud seal Mar 4, 2024, 3:29 PM

#

i did a few runs with the Comfortaa-Medium.ttf
i found this where the best settings:

"PosterOverlayPart": {
    "fontAllCaps": "true",
    "AddBorder": "true",
    "AddText": "true",
    "AddOverlay": "true",
    "fontcolor": "white",
    "bordercolor": "white",
    "minPointSize": "95",
    "maxPointSize": "250",
    "borderwidth": "30",
    "MaxWidth": "1900",
    "MaxHeight": "500",
    "text_offset": "+400"
  },
  "BackgroundOverlayPart": {
    "fontAllCaps": "true",
    "AddOverlay": "true",
    "AddBorder": "true",
    "AddText": "true",
    "fontcolor": "white",
    "bordercolor": "white",
    "minPointSize": "95",
    "maxPointSize": "250",
    "borderwidth": "30",
    "MaxWidth": "3200",
    "MaxHeight": "500",
    "text_offset": "+200"
  },
  "TitleCardOverlayPart": {
    "AddOverlay": "true",
    "AddBorder": "true",
    "bordercolor": "white",
    "borderwidth": "30"
  },
  "TitleCardTitleTextPart": {
    "fontAllCaps": "true",
    "AddEPTitleText": "true",
    "fontcolor": "white",
    "minPointSize": "95",
    "maxPointSize": "250",
    "MaxWidth": "3640",
    "MaxHeight": "350",
    "text_offset": "+300"
  },
  "TitleCardEPTextPart": {
    "fontAllCaps": "true",
    "AddEPText": "true",
    "fontcolor": "white",
    "minPointSize": "60",
    "maxPointSize": "100",
    "MaxWidth": "1200",
    "MaxHeight": "120",
    "text_offset": "+150"
  }```

fresh gorge Mar 4, 2024, 4:33 PM

#

proud seal i did a few runs with the **Comfortaa-Medium.ttf** i found this where the best s...

Oh.. i found some good numbers to use... thats not the issue... its more about why the numbers/csv/scriptlog is not showing things accurately/consistently

#

#

Here is a good example... summary says 2. logs only find 1. csv shows 2

#

The truth is that only 1 was truncated

#

so summary and csv are incorrect

proud seal Mar 4, 2024, 4:38 PM

#

okey, maybe there is another null required.

fresh gorge Mar 4, 2024, 4:39 PM

#

i think so... I was going to try and step through the code with S06E19,20,21 to see what might be happening

proud seal Mar 4, 2024, 4:40 PM

#

try latest, it may fixed it.

fresh gorge Mar 4, 2024, 5:05 PM

#

LOL... I found the issue

#

$global:IsTruncated = $null needs to be added to Get-OptimalPointsize

#

by setting this global to null here, anytime you call this function, it will ensure that its null to begin with

#

proud seal Mar 4, 2024, 5:10 PM

#

omg yeah ofc 😅😂

fresh gorge Mar 4, 2024, 5:12 PM

#

#

so your script still fails even with the addtional globalnull that you added... I'd just add it to the function as mentioned above

#

#

with the addition to the function

#

#

and csv is fine as well now

#

this is an interesting "find"

#

maybe write the error to the logs as an ERROR?

proud seal Mar 4, 2024, 5:33 PM

#

fresh gorge maybe write the error to the logs as an ERROR?

yeah, its a placeholder for now ^^

truncated part is updated.

fresh gorge Mar 4, 2024, 5:34 PM

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/21

#

ok... I might need to redo the PR

#

actually... not sure since I only see an update to ps1 from 1 hour ago

#

anyhow... check out the PR as I made some cleanup and added a couple fo enchancements

#

removed some comment lines
added prefix "poster" to test posters
added a delete of all files within the test folder when running -testing added global to get-optimalpointsize

proud seal Mar 4, 2024, 6:03 PM

#

merged 👍

fresh gorge Mar 4, 2024, 6:39 PM

#

rerunning now. I see you also did more cleanup in the script. 😉

fresh gorge Mar 4, 2024, 8:46 PM

#

proud seal merged 👍

when you mentioned this in the README: Cross-platform Compatibility: Ensures seamless operation across Linux, Docker, and Windows Plex servers, enhancing versatility.

Are you talking about plex being on an platform? Or are you talking about running the ps1 Cross-platform?

proud seal Mar 4, 2024, 8:49 PM

#

Yeah plex, but in theory the script should also run on linux.

#

Only one dot.net reference is in script, and thats the dimension calculation.

fresh gorge Mar 4, 2024, 8:51 PM

#

i will test it if I can on an ubuntu VM i have lying around

proud seal Mar 4, 2024, 8:54 PM

#

Imagemagick needs to be installed manually and the paths would need to be in linux format in config file but the rest should work as it is.

fresh gorge Mar 4, 2024, 9:30 PM

#

#

so as you suspected.... dimensions checker is acting up

proud seal Mar 4, 2024, 9:34 PM

#

And the paths 😬

fresh gorge Mar 4, 2024, 9:35 PM

#

well... not sure about the paths because I am installing imagemagick manually now.... maybe detecting non-windows OS and aborting there would be best?

#

instead of downloading the windows exe?

fresh gorge Mar 4, 2024, 9:59 PM

#

    if (Test-Path -LiteralPath $magickinstalllocation\magick.exe) {
        Write-log -Subtext "ImageMagick installed here: $magickinstalllocation" -Path $configLogging -Type Success
    }
    Else {
        Write-log -Subtext "Error During installation, please manually install Imagemagick" -Path $configLogging -Type Error
    }```

in ubuntu, 22.04, the install is:

Version: ImageMagick 6.9.11-60 Q16 x86_64 2021-01-25 https://imagemagick.org
Copyright: (C) 1999-2021 ImageMagick Studio LLC
License: https://imagemagick.org/script/license.php
Features: Cipher DPC Modules OpenMP(4.5)
Delegates (built-in): bzlib djvu fftw fontconfig freetype heic jbig jng jp2 jpeg lcms lqr ltdl lzma openexr pangocairo png tiff webp wmf x xml zlib

and the file used is `convert` found in `/usr/bin/convert`

#

maybe I could make an ~~alias ~~ symlink to it and call it magick.exe

modern pebble Mar 4, 2024, 10:00 PM

#

submitted a PR for some README changes/additions. Added titlecard stuff to PrerequisitePart and change LibraryFolders true/false explanation (they were backwards).

native crag Mar 4, 2024, 10:03 PM

#

fresh gorge maybe I could make an ~~alias ~~ symlink to it and call it `magick.exe`

Seems cleaner to figure out where it is and just call the correct path depending on platform.

fresh gorge Mar 4, 2024, 10:07 PM

#

currenty the script requires a path to the executable as part of config.json

#

it uses magick.exe when launching in windows

#

magick.exe does not exist in the unix version of imagemagick

#

so I guess that whole logic would need to be reviewed

native crag Mar 4, 2024, 10:08 PM

#

yes, I realize that, but it seems like the cleaner solution is to not require an explicit path to the executable but instead to look for it in a platform-independent fashion.

fresh gorge Mar 4, 2024, 10:09 PM

#

I agree

native crag Mar 4, 2024, 10:09 PM

#

convert also exists in windows
https://legacy.imagemagick.org/Usage/windows/

fresh gorge Mar 4, 2024, 10:10 PM

#

yes.. the issue with convert in windows is that its legacy.... so some features may not be at parity...

#

at least that is what I read and understood

#

sudo ln -s /usr/bin/magick.exe /etc/alternatives/convert is getting me a little further....

#

#

lets see if the fanart module will install

native crag Mar 4, 2024, 10:12 PM

#

Or use magick everywhere
https://imagemagick.org/script/download.php

native crag Mar 4, 2024, 10:12 PM

#

fresh gorge `sudo ln -s /usr/bin/magick.exe /etc/alternatives/convert` is getting me a littl...

That is so wrong. magick should probably be available.

fresh gorge Mar 4, 2024, 10:13 PM

#

oh

#

I am definitely not a unix person

#

oh... that magick download looks interesting

modern pebble Mar 4, 2024, 10:14 PM

#

ImageMagick version 7 should have magick

fresh gorge Mar 4, 2024, 10:15 PM

#

lots of path issues to contend with as I believe the assumption when building this was to make it work for windows

fresh gorge Mar 4, 2024, 10:15 PM

#

modern pebble ImageMagick version 7 should have magick

when you install using sudo apt install imagemagick its 6.9 that gets installed

#

gonna try that magick download

modern pebble Mar 4, 2024, 10:16 PM

#

fresh gorge when you install using `sudo apt install imagemagick` its 6.9 that gets installe...

yeah, Ubuntu has 6

native crag Mar 4, 2024, 10:17 PM

#

fresh gorge gonna try that magick download

I'd just use convert rather than requiring another thing to be installed, unless v7 is required.

modern pebble Mar 4, 2024, 10:20 PM

#

native crag I'd just use `convert` rather than requiring another thing to be installed, unle...

ImageMagick for windows doesn't have convert so you'd have to determine which one to use by which operating system, or alias convert and use magick for everything.

native crag Mar 4, 2024, 10:22 PM

#

This seems to say that convert is there.
https://legacy.imagemagick.org/Usage/windows/#convert_issue

But either way is probably fine

modern pebble Mar 4, 2024, 10:30 PM

#

convert, under windows, is a program to convert a FAT volume to NTFS.

native crag Mar 4, 2024, 10:33 PM

#

it notes that issue and the workaround in that article.

#

But that is an issue to bear in mind.

fresh gorge Mar 4, 2024, 10:37 PM

#

So the AppImage is v7.1.1.29

#

after checking that libfuse3 was installed and then installing libfuse2, it looks like the AppImage is now executable on Ubuntu 22.04

#

paths issue... gonna need to convert those to be compatible between windows and unix

#

i am just starting with the -testing option

native crag Mar 4, 2024, 10:41 PM

#

Maybe useful:
https://powershell.org/2019/02/tips-for-writing-cross-platform-powershell-code/

fresh gorge Mar 4, 2024, 10:42 PM

#

thanks Chaz... that is useful

fresh gorge Mar 4, 2024, 11:02 PM

#

Making good progress on the paths transformations...

thin sparrow Mar 4, 2024, 11:04 PM

#

This is very interesting to me because I feel I could/should be using local assets more than just depending on Plex-Meta-Manager-Images and hoping more things get added there. But I'm on MacOS myself. I could help test the cross-platform functionality, or fix anything on the mac side?

fresh gorge Mar 4, 2024, 11:10 PM

#

sure... but we need to get a v1 for cross-platform running first

#

the source code is available... just try it?

#

but I know the paths will be all wrong

thin sparrow Mar 4, 2024, 11:19 PM

#

Oh yeah, no pressure. Just thinking about how I can make my stuff better and also help.

I'll install powershell in a bit and see what this is like.

misty cobalt Mar 4, 2024, 11:29 PM

#

So I haven't really dug into this - it's really neat

#

So my understanding is that it prefers a "textless" poster - what would be cool is if you could set a schedule for it to select a new textless poster, just so the images change every now and again.

fresh gorge Mar 5, 2024, 12:03 AM

#

misty cobalt So my understanding is that it prefers a "textless" poster - what would be cool ...

it prefers what you want... if you want a german poster, then list de,xx,en which means german, then textless, then english

#

if you want english and then fallback to textless, then german en,xx,de

#

as for the option..... you could delete the assets completely, and then rerun... if there are new posters that have arrived and are voted higher on average, then they would be pulled.

#

source can be fanart.tv then tmdb, then tvdb, then imdb

#

or the way I run it is tmdb, then fanart, then tvdb, then imdb

#

@proud seal , I think I have a running cross-platform version of the script... I will create the PR for it.

fresh gorge Mar 5, 2024, 3:32 AM

#

https://github.com/fscorrupt/Plex-Poster-Maker/pull/23

#

its not perfect, but definitely a good version 1 of a cross-platform version

proud seal Mar 5, 2024, 5:19 AM

#

fresh gorge its not perfect, but definitely a good version 1 of a cross-platform version

~~i will let this one open til its a complete working one, just tried it on a ubu 22.04 and there is not really anything that works 😄 it has to cover all parts like on windows, then i can merge it.~~

Okey, made some changes, it now works on Linux to, imagemagick "install" is also covered.

Also had to fix the join paths, cause with your changes you broke the windows version 😅

fresh gorge Mar 5, 2024, 12:16 PM

#

Oh? I was testing on windows and Ubuntu and the t seemed to be working. To be fair, I was working on -testing and I thought I had that correct. Then I moved on to the rest. I know I had broken some things along the way.... but also did a test run on my test libraries and it worked with windows and Ubuntu... I guess I missed some things. Also my testing was not as exhaustive as I would have liked...

#

I went to bed last night to run things against the full library

#

No idea what it looks like this morning

#

Yup.... something broken in full run that was not broken in test run

#

Omg.... and my Ubuntu run is still going... x that VM is so slow!!!

proud seal Mar 5, 2024, 12:20 PM

#

should be fixed now 🙂

fresh gorge Mar 5, 2024, 12:21 PM

#

Yup... gonna go see the diff between your fixes and what I did.

proud seal Mar 5, 2024, 12:25 PM

#

fresh gorge Omg.... and my Ubuntu run is still going... x that VM is so slow!!!

you tell me, i had the script run for 24h just to see i selcted the wrong font and now i have to start over again ^^ 😄

fresh gorge Mar 5, 2024, 12:32 PM

#

One question:

# Cleanup old log files
$logFilesToDelete = @("Manuallog.log", "Testinglog.log", "ImageMagickCommands.log", "Scriptlog.log", "ImageChoices.csv", "PlexLibexport.csv", "PlexEpisodeExport.csv")

Why are you not removing all files in the logs folder upon launch?

#

I added the extra files and you removed them

proud seal Mar 5, 2024, 12:33 PM

#

csv´s are not log files, i like to keep them.

fresh gorge Mar 5, 2024, 12:33 PM

#

They get overwritten don't they?

proud seal Mar 5, 2024, 12:34 PM

#

yeah, but if i want to check after i run and a schedule or so is starting it would delete them right after script start, in this case i can abrort the script and still have the files to check

fresh gorge Mar 5, 2024, 12:49 PM

#

Indeed. I see. As a future consideration for an enhancement, log rotation with a max number of logs could be considered. So if someone uses 5, then the logs will never grow past 5 of each

proud seal Mar 5, 2024, 12:50 PM

#

like pmm has or?

fresh gorge Mar 5, 2024, 12:55 PM

#

Well, I am not crazy about PMM logs

#

I wish the extension would not be .1

#

I like that newest is always the one without anything... like meta.log

#

Also 9 logs is a lot, so a configurable number would be nice

#

So something like this is what I was thinking of:(ignore names of files here as you already have good names)
ScriptLog.log - always the most recent
ScriptLog.2.log - second most recent
ScriptLog.3.log - third most recent log

And since maxLogs is set to 3, this is the most I would get for ScriptLog.log. The same applies for the 3 csv files and the imagemagick logs and the testing logs

#

Btw, the install on Ubuntu worked great for magick

#

Rerunning on windows and Ubuntu now

#

My windows run with all those errors took ~7h. Hoping the new version from your latest will be faster due to less errors

#

A consideration for the README.
Sharing the way to use/connect to the 3 csv with Excel. Using those settings, you can create the 3 connections with the three total rows and then all you do is hit Data | Refresh All and it will grab the latest info from the csv's and present it back in excel.

#

The key in the import is the Semicolon and the 65001: Unicode (UTF-8)

rare tulip Mar 5, 2024, 2:40 PM

#

working on running this in docker... here is my current docker-compose

version: '3'

services:
powershell_cron:
image: mcr.microsoft.com/powershell:latest
container_name: Postermaker
volumes:
- /share/config/postermaker/PosterTemp:/PosterTemp:rw
- /share/Multimedia/Plex/assets:/assets:rw
- /share/config/postermaker/PosterTemp/config.json:/postermaker/config.json:rw # Mount the configuration file
- ./FanartTvAPI:/FanartTvAPI # Assuming FanartTvAPI is the module directory
command: ["sh", "-c", "while true; do pwsh /PosterTemp/PlexPosterMaker.ps1 -ConfigFile /PosterTemp/config.json; sleep 3600; done"] # Pass the configuration file as a parameter

network_mode: host  # Use host networking for simplicity
restart: always

It almost runs LOL... I just keep getting this error
"AppImages require FUSE to run. You might still be able to extract the contents of this AppImage if you run it with the --appimage-extract option. See https://github.com/AppImage/AppImageKit/wiki/FUSE for more information"

GitHub

FUSE

Package desktop applications as AppImages that run on common Linux-based operating systems, such as RHEL, CentOS, openSUSE, SLED, Ubuntu, Fedora, debian and derivatives. Join #AppImage on irc.liber...

proud seal Mar 5, 2024, 2:47 PM

#

rare tulip working on running this in docker... here is my current docker-compose version:...

Try to add magick in dockerfile like i did in scrip

#

https://github.com/fscorrupt/Plex-Poster-Maker/blob/7a48a0982a8eb68fff4a888853e4b77556ee47fa/PlexPosterMaker.ps1#L1604

#

But if you take latest script, it may is not required to do so.

#

How does your Dockerfile look like?

rare tulip Mar 5, 2024, 3:08 PM

#

I did use the latest script. 👍 I am using that compose file to create a stack in portainer

proud seal Mar 5, 2024, 3:09 PM

#

Ah okey, that may not work,

#

I will have a look tomorrow, last powershell container i build is 2 years old 🤣

rare tulip Mar 5, 2024, 3:12 PM

#

or maybe switch to a Linux image since the script now runs in Linux also

native crag Mar 5, 2024, 3:14 PM

#

brand new git clone on ubuntu 22.04:

PowerShell 7.4.1
PS /mnt/hdd/Plex-Poster-Maker> ./PlexPosterMaker.ps1
New-Item: /mnt/hdd/Plex-Poster-Maker/PlexPosterMaker.ps1:40
Line |
  40 |          New-Item -Path $Path -Force | out-null
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Access to the path '/Logs' is denied.
...

and lots of failures follow due to that

Looks like maybe this doesn't work as expected?

$global:ScriptRoot = $PSScriptRoot

Edit, that bit in isolation works fine.

PS /mnt/hdd/Plex-Poster-Maker> ./test.ps1
/mnt/hdd/Plex-Poster-Maker

where test.ps1 is:

Write-Host $PSScriptRoot

proud seal Mar 5, 2024, 3:16 PM

#

You do have rights to call and create things with the user you are trying it?

native crag Mar 5, 2024, 3:17 PM

#

I do, but presumably that logs directory should be /mnt/hdd/Plex-Poster-Maker/Logs not /Logs

#

Ah, apparently only happens the first run.

proud seal Mar 5, 2024, 3:25 PM

#

Yeah, just checked - it was on a false line, fixed in latest.

modern pebble Mar 5, 2024, 6:32 PM

#

Is it possible to specify the config file? My thought is that I can run the script to create posters when new items are added and then let PMM deal with everything else on the nightly run. The caveat is that I only want to process my movies when a new file is added, and not do TV. Or, when a TV item is added that I don't process Movies. Specifying a config file that locks out all but the one library I can then have Radarr/Sonarr run the script for the respective library. I know there's a lot going on right now, but maybe something to keep in mind?

proud seal Mar 5, 2024, 6:42 PM

#

I already thought about something like that, but not possible in current state, but in future Definitely a good change 👍

modern pebble Mar 5, 2024, 9:13 PM

#

Something is amiss...

📎 Scriptlog.log

fresh gorge Mar 5, 2024, 10:16 PM

#

modern pebble Something is amiss...

Need to see the csv files for this to see what the tmdbid was reported as

modern pebble Mar 5, 2024, 10:17 PM

#

I can dig it up but I did verify it had the correct id for tvdb, tmdb, and imdb.

fresh gorge Mar 5, 2024, 10:19 PM

#

Right, so that's what I am looking for as I wanted to trace it back from that point

#

The csv file will contain the tmdbid for Hanna. If you can share that row

modern pebble Mar 5, 2024, 10:21 PM

#

That's in plexlibexport?

fresh gorge Mar 5, 2024, 10:21 PM

#

Possibly

#

But might be in the other csv as well

#

One is for show and the other is more for episode cards

modern pebble Mar 5, 2024, 10:24 PM

#

fresh gorge Mar 5, 2024, 10:25 PM

#

Ok so that is accurate

#

54155 is for Hanna

#

Now we need to check the PlexEpisodeExport

#

Should have 3 lines for Hanna

#

Share the rows just before and just after Hanna please

modern pebble Mar 5, 2024, 10:30 PM

#

fresh gorge Mar 5, 2024, 10:31 PM

#

@proud seal it looks like we might be double-counting or those summary variables need to be set to $null upon launch of script

fresh gorge Mar 5, 2024, 10:31 PM

#

modern pebble

Ok... so that is strange... can you try something if it's finished processing?

modern pebble Mar 5, 2024, 10:32 PM

#

Yes

fresh gorge Mar 5, 2024, 10:32 PM

#

Go and delete just that show

modern pebble Mar 5, 2024, 10:32 PM

#

From the asset directory?

fresh gorge Mar 5, 2024, 10:32 PM

#

Rerun script which should skip everything and just add that

modern pebble Mar 5, 2024, 10:32 PM

#

I already did that. Same results

fresh gorge Mar 5, 2024, 10:32 PM

#

That can't be

#

Ok

modern pebble Mar 5, 2024, 10:33 PM

#

I can do it againi...

fresh gorge Mar 5, 2024, 10:33 PM

#

Try a new powershell window

#

From that new window, just delete Hanna and rerun.

#

If you want, back up your logs directory first and outside of the PM folder

#

In case you need to refer back to csv 's and logs

modern pebble Mar 5, 2024, 10:34 PM

#

Running now...

fresh gorge Mar 5, 2024, 10:35 PM

#

As a separate question, do you have that show/movie called Klute?

modern pebble Mar 5, 2024, 10:35 PM

#

No

fresh gorge Mar 5, 2024, 10:35 PM

#

Even stranger then...

#

So the results of this run, since it's only going to show this one show, are you able to zip the logs folder and share the whole thing here?

modern pebble Mar 5, 2024, 10:37 PM

#

Sure

fresh gorge Mar 5, 2024, 10:47 PM

#

Great thanks. As I don't have that show in my server, I am gonna try and repro it by pausing the script after it reads in the csv and then adding your rows to trick it into thinking I have that show and then download the images

#

I might also be able to trick Plex in my test library

modern pebble Mar 5, 2024, 10:53 PM

#

We're meeting friends for music bingo so I have to take off. I'll check back in around 9pm. Thanks!

📎 ppm-logs.zip

fresh gorge Mar 6, 2024, 2:20 AM

#

Poisoned on tmdb:

#

submit a report that this is invalid and they will take it down. Then up to a maximum of 8 hours and the tmdbapi will pull back the proper data

#

what this doe snot explain is WHY ppm decides to fallback to this poster for season 2 and 3. I think its because the tmdbglobalfallback is not reset to null between season searches.

#

so because it does not find textless, it fallsback and reuses the Klute image

modern pebble Mar 6, 2024, 2:26 AM

#

Dang... I even went and checked the posters, but I guess I didn't look in the right spot. Thanks for checking it out!

fresh gorge Mar 6, 2024, 2:31 AM

#

well.. there is still that second problem...

#

in theory, you should have season 1 with poisoned poster

#

then season 2 and 3 should have been fine

#

still stepping through to figur ethat part out

modern pebble Mar 6, 2024, 2:37 AM

#

Should it reuse a textless poster for other seasons if it can't find textless? Or should it just fallback to text posters if it can't find textless for EACH season?

fresh gorge Mar 6, 2024, 2:38 AM

#

it should try the other providers to find textless

#

which it does not seem to do

modern pebble Mar 6, 2024, 2:38 AM

#

But if it can't, should it use textless from other season, or use text from the season it's searching for?

#

and by can't, I means can't find textless

fresh gorge Mar 6, 2024, 2:40 AM

#

pretty sure that each image should first go to the preferred provider and look for the preferred language which is xx,en so textless and then english text

#

so if it cant find textless on tmdb

#

then it goes to fanart

#

then tvdb

#

then back to tmdb to look for en

#

then fanart

#

then tvdb

#

and likly imdb is in that mix as well

#

however, I believe there are logic issues at this point

#

we havent even gottent ot he fact that a season can also have backdrops

#

logic issue is around here:

#

line 3149 restarts the search for the seasonposter, but now it has TMDBfallbackposterurl set to the poisoned image.

#

ont he next iteration for season 2, since it cannot find textless, it defaults to the TMDBfallbackposterurl which is the poisoned image. Repeats again for season 3

#

So I understand why its happening, but not entirely sure how to fix

#

modern pebble Mar 6, 2024, 3:00 AM

#

So, that section starts at line 3107 for me, so it looks like maybe you've added some code to your file? But I'll have to spend several hours staring at that for it to start to make sense to me.

fresh gorge Mar 6, 2024, 3:01 AM

#

like try this... delete only season2 and season3 poster for hanna.... rerun.. and watch how it gets the text posters

#

he released a version ate today

#

i did not add code

#

#

#

so notice how it remembered the season2 text and made that the fallback for season 3

modern pebble Mar 6, 2024, 3:04 AM

#

Didn't see the release, but I'm up to date now. Deleted the two posters and running now.

fresh gorge Mar 6, 2024, 3:04 AM

#

but if i then delete season3 only

#

#

this summary is the strangest as well... the green is acurate... the yellow is totally off for some reason

#

I thnk the reason is thatt he summary reads the csv and the csv is no longer being deleted or reset during the run...

#

there should not be those duplicates in there

#

this is also strange for me... why a reference to a P drive?

modern pebble Mar 6, 2024, 3:17 AM

#

Weird, it's picking up a bunch more title cards that weren't there a few hours ago..

#

Oh... it's using the background image as a title card... that's new

fresh gorge Mar 6, 2024, 3:18 AM

#

thats not what it should be doing

#

again... probably when it cant find something it fails back

#

but then keeps that

#

i found the issue witht he coutners

#

#

in an older version of the script, this CSV is deleted

#

now its not there at all and things get appended

#

The other two csv files might suffer from this same issue

modern pebble Mar 6, 2024, 3:22 AM

#

Yeah, for everything I didn't have a title card for it's falling back to using the background image. That could be okay, but I think it should be optional. That way, if an image becomes available it would use that.

fresh gorge Mar 6, 2024, 3:23 AM

#

Export-Csv -Path "$global:ScriptRoot\Logs\ImageChoices.csv" -NoTypeInformation -Delimiter ';' -Encoding UTF8 -Force -Append

so without an explicit remove-item, all references to ImageChoices.csv is -Append

fresh gorge Mar 6, 2024, 3:24 AM

#

modern pebble Yeah, for everything I didn't have a title card for it's falling back to using t...

I think there is a similar logic issue that needs to be addressed

#

$Libraries | Select-Object * | Export-Csv -Path "$global:ScriptRoot\Logs\PlexLibexport.csv" -NoTypeInformation -Delimiter ';' -Encoding UTF8 -Force

#

$Episodedata | Select-Object * | Export-Csv -Path "$global:ScriptRoot\Logs\PlexEpisodeExport.csv" -NoTypeInformation -Delimiter ';' -Encoding UTF8 -Force

#

I will add the logic to delete the ImageChoices.csv and PR that

modern pebble Mar 6, 2024, 3:26 AM

#

I don't think I noticed that because I have a simple batch file that rotates the logs.

#

So unless I'm just running the script in a powershell window it would rename the logs.

fresh gorge Mar 6, 2024, 3:29 AM

#

i see... thats a supplemental thing... it should work without that extra thing you added

#

#

fixed

#

line 1455:
$logFilesToDelete = @("Manuallog.log", "Testinglog.log", "ImageMagickCommands.log", "Scriptlog.log", "ImageChoices.csv")

#

PR submitted:
https://github.com/fscorrupt/Plex-Poster-Maker/pull/24

modern pebble Mar 6, 2024, 3:35 AM

#

fresh gorge i see... thats a supplemental thing... it should work without that extra thing y...

Oh, I agree. But because I do that, it would always create a new log and I wouldn't have noticed it was appending data.

fresh gorge Mar 6, 2024, 3:36 AM

#

i shared a log rotation strategy with FSCorrupt so he might implement it thus eliminating the need for your additional wrapper

modern pebble Mar 6, 2024, 3:36 AM

#

Wouldn't you also want to delete the PlexLibexport.csv also?

#

And PlexEpisodeExport.csv?

fresh gorge Mar 6, 2024, 3:38 AM

#

no need since if you notice the command used... its not performing the -Append

#

so when it writes the file, it removes it right away

#

now the method used means that if you run in testing mode, the file gets deleted... I know that FS has reasons to keep the file around... however.... not 100% sure.

#

old logic

#

if testing, then it won't touch the ImageChoices.csv

#

and since testing wont get to the other two csv's, they remain as well

#

so my fix is probably not going to be accepted

#

I will update it to this:

# Cleanup old log files
if ($Testing) {
    $logFilesToDelete = @("Manuallog.log", "Testinglog.log", "ImageMagickCommands.log", "Scriptlog.log")
}else{
    $logFilesToDelete = @("Manuallog.log", "Testinglog.log", "ImageMagickCommands.log", "Scriptlog.log", "ImageChoices.csv")
}

#

PR updated

modern pebble Mar 6, 2024, 4:01 AM

#

Is there some way to add logic so if a title card can't be found to NOT use the show background poster?

fresh gorge Mar 6, 2024, 4:27 AM

#

yes. like I mentioned, I believe this is a bug and not what was intended originally by the script

#

similar to the logic error we discovered and documented above

modern pebble Mar 6, 2024, 4:37 AM

#

So I deleted season posters 2 and 3 and it did download posters with text, but at least the right ones.

fresh gorge Mar 6, 2024, 4:38 AM

#

yes... but this logic is gonna cause you all kinds of problems

proud seal Mar 6, 2024, 5:31 AM

#

modern pebble Is there some way to add logic so if a title card can't be found to NOT use the ...

Not a logic issue, I'd rather have a backdrop than nothing at all 😅

proud seal Mar 6, 2024, 5:32 AM

#

fresh gorge PR updated

Merged

fresh gorge Mar 6, 2024, 5:33 AM

#

so if a episode titlecard is not found, the fallback is to use the show background?

proud seal Mar 6, 2024, 5:34 AM

#

yes, to ensure that it does as much as possible, it can be seen as a fallback in the csv and can then be adjusted after the run

fresh gorge Mar 6, 2024, 5:35 AM

#

i was less focused on the background stuff and more concerned with the other logic issue shared around the Hanna show

proud seal Mar 6, 2024, 5:39 AM

#

Correct thats an logic issue copied it from show posters

fresh gorge Mar 6, 2024, 6:27 AM

#

put a tmdb id, outputs the files/folders
if there is a movie and show with same id, it asks you which you want

I used this with tmdbid 54155 (Hanna) which gave me the fake folders and files that I placed in my test library directory so that I could repro the issue from MyPostingID

📎 fakeplex.zip

#

all you need is python, a tmdbkey within the .env file

#

#

#

fresh gorge Mar 6, 2024, 12:37 PM

#

Line 1429 contains P:\assets which is likely related to your personal setup.

proud seal Mar 6, 2024, 12:49 PM

#

yeah, only when on linux, cause then the default path was not changed.

fresh gorge Mar 6, 2024, 1:05 PM

#

So it's checking whether the user has changed the line within config.json to point to a proper posix system path

#

In my case I had a path of c:\ so it did not detect that

proud seal Mar 6, 2024, 1:21 PM

#

thats not what i want to accomplish, if you enter a false path then its your fault 😄
i just want to make sure the user changed my default value on linux, cause P:\ could never exist on a linux system.

fresh gorge Mar 6, 2024, 1:23 PM

#

then maybe look for :\ in the $AssetPath?

#

😉

proud seal Mar 6, 2024, 1:23 PM

#

why?

fresh gorge Mar 6, 2024, 1:37 PM

#

to capture people that move between running this in windows versus linux?

#

in any case, not a big deal

#

i am rerunning with your latest logic changes

proud seal Mar 6, 2024, 1:38 PM

#

I think i dont get what you want to tell me, what does a check of :\ for windows user should tell them?

fresh gorge Mar 6, 2024, 1:40 PM

#

doesnt the logic there state that if you are on unix (not win32NT) AND the path is P:\assets to write an error out to the user? and then exits?

proud seal Mar 6, 2024, 1:41 PM

#

Yes, but on windows a user could have P:\assets like i have

#

So even it is a default config value, it could be a right value, but not on linux

fresh gorge Mar 6, 2024, 1:42 PM

#

if user is on windows, this logic is skipped, no?

proud seal Mar 6, 2024, 1:42 PM

#

Correct

fresh gorge Mar 6, 2024, 1:53 PM

#

sorry... was speaking in a meeting here at work... lol

#

So...
Scenario 1:
I am on windows machine 1 and my config.json has the following path: D:\assets
logic will be skipped because I am on win32NT

Scenario 2:
I am on unix and my config.json has the following path: D:\assets
logic will be skipped because my path is not P:\assets but will have errors later because D:\assets is not valid for a unix system

Scenario 3:
I am on windows machine 2 and my config.json has the following path: D:\assets however, my machine 2 does not have a D: drive and this should have been C:\assets
logic will be skipped because my path is not P:\assets and because I am on win32NT, but will have errors later because D:\assets is not valid for my win32NT system

native crag Mar 6, 2024, 2:00 PM

#

Why not just check to see if the path exists at runtime and tell the user to fix it if it doesn't?

fresh gorge Mar 6, 2024, 2:01 PM

#

thats my point

#

in all cases, if the path fails, it needs to be resolved

#

Test-Path and abort if path does not exist and post a meanigful error

native crag Mar 6, 2024, 2:02 PM

#

I'm saying don't look for some magic characters in the path.

fresh gorge Mar 6, 2024, 2:02 PM

#

Me too.. I was trying to understand why that logic was there in the first place

#

# Create directories if they don't exist
foreach ($path in $LogsPath, $TempPath, $TestPath, $AssetPath) {
    if (!(Test-Path $path)) {
        if ($global:OSType -ne "Win32NT" -and $path -eq 'P:\assets') {
            Write-Log -Message 'Please change default asset Path...' -Path $configLogging -Type Error
            Exit
        }
        New-Item -ItemType Directory -Path $path -Force | Out-Null
    }
}

I just read the comments

#

this will CREATE folders

#

if they dont exist

#

so its normal that at the beginning, when first run that none of these folders exist

#

it reads from the config.json and then attempts to create the folders

#

the asset folder on a windows system could contain a drive letter

#

and the config.json for a unix system should NOT contain a drive letter for the assetpath

#

$LogsPath, $TempPath, $TestPath are all based off of the running scriptpath so there is nothing to define in the config.json file

#

$AssetPath needs a definition so that you can point the script to your assets folder that PMM can then process

#

so essentially a validation of the values within the config.json should be done for cross-platform compatibility

#

each line in there where someone might put a win32NT value but be running on a POSIX system should have a validation and exit if that validation fails

#

    "PrerequisitePart":{
      "AssetPath": "C:\\users\\bullmoose20\\PosterMaker\\bbb\\shows",
      "magickinstalllocation": "C:\\Program Files\\ImageMagick-7.1.1-Q16-HDRI",

These are the only two parts that someone could screw up if they are moving between windows and unix based systems.. or if they used the default config.json.example directly in a unix system

proud seal Mar 6, 2024, 2:48 PM

#

The path that the user puts in that config file gets created on windows and on linux, its just a check for the linux users that it cant be created because its in windows format, but yeah i do not have a check integrated that checks for what the user has put in there so you ask for a foolproof logic.

modern pebble Mar 6, 2024, 3:47 PM

#

proud seal Not a logic issue, I'd rather have a backdrop than nothing at all 😅

I'd rather have just the plex episode image than have the background. That way, if an image is found, it will update it and I won't have to go looking through 12,000 lines of episodes to figure out what needs to be changed. It's not really automated if I have to do the work to change everything the automation does. Just my two cents, take that for what it's worth....

proud seal Mar 6, 2024, 4:56 PM

#

modern pebble I'd rather have just the plex episode image than have the background. That way,...

thats why its open source, if youre not happy the way it is - you can fork it and adapt it to your needs.

#

i will add plex as provider, so in a future update you can set it as fav provider or as a fallback source.

modern pebble Mar 6, 2024, 5:14 PM

#

Cool, thanks! I wish it was easy for me but I'm not really familiar with python much less powershell.

fresh gorge Mar 6, 2024, 5:35 PM

#

proud seal i will add plex as provider, so in a future update you can set it as fav provide...

FYI, if you do this, adding Plex as a provider, sharing with you now that you will want to be able to read the exif data to see if TCM overlays and PMM overlays are applied or you will end up with a big mess.

#

Thankfully, that is already part of the exif data and implemented. You just need to know what you are looking for.

#

I can share the exif locations and tags for PMM and TCM

proud seal Mar 6, 2024, 5:38 PM

#

Thanks, its not something i will start working on soon, i want to optimize the main part before adding new things, still a few bugs and logic issues in current code

proud seal Mar 6, 2024, 5:38 PM

#

fresh gorge I can share the exif locations and tags for PMM and TCM

very gladly

fresh gorge Mar 6, 2024, 5:56 PM

#

python.exe .\exif_overlay_checker.py --input-folder "D:\bullmoose20\pyprogs\Plex\assets" --verbose

📎 exif_overlay_checker.py

#

this is what I use to scan my assets folders in case something with an overlay from PMM ends up in there or from TCM ends up in there

proud seal Mar 6, 2024, 5:57 PM

#

Thanks zoro

fresh gorge Mar 6, 2024, 5:58 PM

#

yw. I am trying to understand why Hanna is notpulling that textless image

proud seal Mar 6, 2024, 5:58 PM

#

Is it still not working 🤔

fresh gorge Mar 6, 2024, 5:59 PM

#

No...someone fixed it on the TMDB site

modern pebble Mar 6, 2024, 5:59 PM

#

fresh gorge yw. I am trying to understand why Hanna is notpulling that textless image

Is there a textless image? I did report that klute image, and I also tagged it as English, since it's not textless.

fresh gorge Mar 6, 2024, 5:59 PM

#

there is no more textless Klute image for Hanna season 1

#

So I was hoping that it would stay there to test if the logic fix is good

proud seal Mar 6, 2024, 6:00 PM

#

🤣

fresh gorge Mar 6, 2024, 6:00 PM

#

unfortunately we cannot test with Hanna

modern pebble Mar 6, 2024, 6:00 PM

#

I can change it back....

fresh gorge Mar 6, 2024, 6:00 PM

#

you cant because its literally GONE

#

modern pebble Mar 6, 2024, 6:01 PM

#

That was fast

fresh gorge Mar 6, 2024, 6:01 PM

#

the Czech and Spanish pages do not have Klute either

#

so its been wiped.. which is a good thing

modern pebble Mar 6, 2024, 6:02 PM

#

I don't think they ever did. It was just uploaded as a no language poster

fresh gorge Mar 6, 2024, 6:02 PM

#

you can only change the language in tmdb

#

you cannot delete it

#

you must ask the admins to delete it

modern pebble Mar 6, 2024, 6:02 PM

#

I changed klute to english and I reported it as a bad poster.

fresh gorge Mar 6, 2024, 6:03 PM

#

or they must have realised that klute has nothing to do with Hanna and moved it completely

#

so they got rid of it

#

or moved it to the real klute

#

#Plex-Poster-Maker (ppm) Stuff