contributor role | .fmbot | Page 1

sacred wyvernBOT Jun 1, 2026, 2:07 PM

#

fmbot-discord/fmbot

Pull Request #349 | Fix track length lookup passing artist name twice

GetAllTimePlayTimeForAlbum falls back to GetTrackLengthForTrack(track.ArtistName, track.ArtistName) when an AlbumTrack has no stored DurationSeconds. The second arg should be track.TrackName.

Because UseAverages = true, the lookup silently returns the artist's average instead of failing, so album playtime estimates were variance-blind for every track missing a stored duration.

State:

Closed (Merged)

Comments:

0

Review Comments:

0

Commits:

1

Is Locked:

False

Is Draft:

False

Auto Merge:

False

Is Merged:

True

Mergeable State:

Unknown

Labels:

``

Merged By:

th0mk

Modifications:

+1
1
-1

Checks:

Codacy Static Code Analysis - Completed (Success)

kindred shuttle Jun 1, 2026, 2:09 PM

#

hey, we dont give out this role for one line code contributions. its more for contributors who have consistently contributed multiple things to either the code base or bot

minor hare Jun 1, 2026, 2:10 PM

#

yeah that figures lol

kindred shuttle Jun 1, 2026, 2:10 PM

#

given out at my discretion, there is no specific threshold

minor hare Jun 1, 2026, 2:10 PM

#

guess I’ll go through the codebase some more

#

can you close this?

#contributor role