#github

1 messages ยท Page 29 of 1

cloud quailBOT
cloud quailBOT
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome, Firefox

Current Behavior

The highlights feature breaks/overrides the vanilla highlights w/ no option to turn off.

Expected Behavior

I expect to be able to disable handling of the highlights by 7TV as my friends and I are just used to the way Tw...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

I think a channel emote (sub, follow, etc) should be higher priority than third party emotes.

It sometimes makes sense to have emotes that overlap. In the example above, the emote is both a sub emote and BTTV emote so all viewers can use it in the channel regardless of subscription, but subs can use the emote across the website.

#

Very nice so far. I noticed some minor cosmetic issues:

  • extend the clickable area to the whole container (currently only the sort icon is clickable)
  • make the context menu tabs the same width (they are off by a couple of pixels)
  • the default color of the sort icon in the search bar could be var(--seventv-text-color-secondary) and then it would turn into var(--seventv-text-color-normal) when focused (currently the icon really sticks out)
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Firefox

Current Behavior

When I go to https://addons.mozilla.org/en-US/firefox/addon/7tv-nightly/?referrer=7tv.app (from the 7tv.app homepage)
I'm presented with the nightly extension which is version 3.0.0.12200, updated on Feb 20.

Expected Behavior

...

cloud quailBOT
cloud quailBOT
cloud quailBOT
#

This PR is created to add a custom highlight feature for usernames.

What this PR does

  • Adds a new field of highlightType to highlight
  • Adds a new field (column) to the highlight setting menu
  • Adds a dropdown to let users pick which highlight type they want. However, it's unstyled.
  • Adds a very simple dropdown component to support it
  • Increases the width of the settings area. However, the dropdown (the select element) is still a bit concatenated because I don't want to i...
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

@Melonify I implemented that requested change. I put the setting under appearance even though it's a functionality just cause that's where other emote menu settings were.

Since closing menu is now optional, I thought it would be a good idea to at least auto close the menu by default when a chat message is sent. Personally I really don't see any reason why a user would want the emote menu to stay open after sending the message, so I think it's a good default behavior.

The way I went ab...

cloud quailBOT
#

The lack of this feature is currently the only reason I am reluctant to start using 7TV 3.0+.
FrankerFaceZ has a version of this; separating badges, terms and users with a priority. It is not compatible with 7TV 3.0+. Here is how it looks:

image

The numbers next to the coloring is the priority, in case a message contains both a badge, username and term that should be highlighte...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#
[SevenTV/Extension] New branch created: feat/youtube\-iframe\-tweaks
cloud quailBOT
#
[SevenTV/Extension] branch deleted: feat/youtube\-iframe\-tweaks
#

nit: it makes more sense to invert this condition; while it's unlikely owner would ever be defined on an emoji set, if it ever was then this means the special emoji case wouldn't render.

							<div v-if="es.provider === 'EMOJI'" class="emoji-group">
								<SingleEmoji
									:id="emojiGroupIcons[emojiCategories.indexOf(es.name)]"
									:alt="es.name"
									:style="{ width: `100%`, height: `100%` }"
								/>
							</div>
							<img v-else-if="es.owner ...
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

When you are in the viewers list, you can't scroll it, you are scrolling the chat history instead.

Expected Behavior

One should be able to scroll the viewers list.

Steps To Reproduce

Click viewers list and try to scroll.

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

https://github.com/SevenTV/Extension/pull/481

This PR hides the Prime Loot button at the top of Twitch, but it does not hide the Prime loot things that may appear on some streamer's video players when you hover. The PR also gets rid of React / Bits buttons but it doesn't hide when people uses Bits in the chat. Just an FYI since I am unsure if those changes fully cover what you are mentioning in this Issue.

#

This issue is mostly addressed in PR https://github.com/SevenTV/Extension/pull/481. The desired UI Treadspear had screenshotted in his description is achievable with the newly added hidden elements feature. However, it was not implemented in a way where specifically hype train or specifically pinned message can be hidden, it will just hide any community highlights in general. There could be future work addressing this, and allowing for hiding specifically just hype train, etc.

cloud quailBOT
#

Bug Fix

Small bug fix if hiding "Unfollow" button without hiding "React" button.

This PR also adds another selector for removing the live notification button with the goal of removing the left padding to make the UI look cleaner after removal. However, the original selector is still added as a fallback option since the new selector relies on a chain of multiple children.

Screenshots

Normal:
![image](https://user-images.githubusercontent.com/69816894/235357283-4773d3cd-1386...

cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

When sidebar is open the settings "Hide Recommended Channels" and "Hide Viewers Also Watch" function correctly.

When sidebar is collapsed the "Hide Recommended Channels" hides "viewers also watch" and "Hide Viewers Also Watch" does...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#
[SevenTV/chatterino7] New tag created: v2\.4\.2
#
[SevenTV/chatterino7] New tag created: v7\.4\.3
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome, Firefox

Current Behavior

When you hover over an emote that is located at the right side of the chat column the tool tip is strangely squashed.

![111](https://user-images.githubusercontent.com/20751720/235462168-0b7ea6bd-789b-43aa-a2ea-3fe4ce65d37...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

Bumps jurplel/install-qt-action from 3.1.0 to 3.2.0.

Release notes
Sourced from jurplel/install-qt-action's releases.

install-qt-action v3.2.0

Fix py7zr weirdness (@โ€‹ddalcino)

Commits

c650b0c Git add force new modules
5cb43cf Build v3.2
aac41e2 Merge branch 'master' into v3
3600680 Merge pull request #182 from jurplel/dependabot/npm_and_yarn/action/xml2js-an...
dc8ed2e Merge pull request #178 from ddalcino/topic/use-correct-py7zr
9f33817...

#
[SevenTV/chatterino7] New branch created: dependabot/github\_actions/jurplel/install\-qt\-action\-3\.2\.0
cloud quailBOT
cloud quailBOT
cloud quailBOT
#
[SevenTV/API] New branch created: troy/terraform
#
[SevenTV/CompactDisc] New branch created: troy/add\-terraform
#
[SevenTV/API] branch deleted: chore/optimize\-user\-state\-query
#
[SevenTV/EventAPI] branch deleted: feat/anatole/fix\-eager\-subscribe\-
cloud quailBOT
#

Please don't use DOM operations. We have built an array of React utilities capable of hooking Twitch's components, you can see those under common/ReactHooks.ts and common/Reflection.ts.

In order to hook to hook the relevant component, a predicate such as this might work (untested, only visually found this scrolling through the react tree)

(n) => n.props && n.props.mediaPlayerInstance && n.props.videoContainer
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This feature does not exist in the latest nightly version

  • [X] I have checked the latest nightly version

Feature Description

I appreciate the Hide Community Highlights feature added to the nightly version, but I don't like that it hides every highlight.

I think it would be better if you could decide what features you specifically want to hide on your own if that is possible to implement. I li...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

As a moderator I like more the default design (like default "VIP" / first message etc ) box . there is a way to do it? Like only emote and nothing else

Almost every thing can be toggled off in the settings. Check the hightlight tab in settings, can toggle off first message/mention hightlights etc.

So if I toggle all hightlight off I will see the default twitch design (the box) ?

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

The nightly version is now completely gone on the FF addons store.
And all I see is "gross mishandling of Mozillas Site". No details, nothing is explained. What is the exact reason Mozilla "banned" / removed both addons. I trust Mozilla more than you. So if you don't provide some proofs that you did nothing wrong, I'll assume that you violated some Privacy or ToS of Mozilla and it's your fault not Mozillas. Mozilla is known to go for Privacy, so if youre addon isn't on there store it's r...

cloud quailBOT
#

@Totto16,

it's not actually gone I just renamed it since they've reverted it to a super old version.

Since you're on our github repository which contains 100% of the code published to either CWS or AMO (you can even view the build logs and subsequent publish action, which is fully automated so no post-processing can occur), you can check for yourself that there is nothing wrong with the 7TV Extension.

We're not sure why mozil...

#

@AnatoleAM thanks for clarification, as I said, you can't find reliable information anywhere. But Google Chrome is more Spyware then FF. But lets not focus on that conversation. I managed to build teh extension, but FF (also chrome) doesn't allow extensions, that are not signed to be installed for more than a session, so it's not an option to reinstall the extension every time I reopen the browser :sweat:

Anyway, thanks for clarification, and if Mozillas reviewers are that :hankey: it's b...

cloud quailBOT
cloud quailBOT
#

Fixed the menu location by using a more reliable anchor, and ensured the inputElement updates after it's deleted and added back. When the user is timed out, both the anchorEl and the inputEl are removed from the site, which previously caused the anchor to glitch and the menu to appear at the top left.

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

@robmonte I looked at the output of complete and the slider. There, and so most of the emoticons offer a choice of emoticons of the author of the channel.

stare emoticons, which were found simply by searching from the author of the channel:

image

now we look at the results that the autocomplete picked up for us:

![image](https://user-images.githubusercontent.com/61266300/23678...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

The plan currently is to switch to self-distribution ("unlisted addon"), which as I understand doesn't have to deal with this review process. CI has already been set up for that (#492) but I haven't figured out auto-updating yet.

For what's worth. You probably know about this already but TTV LOL PRO had a similar issue in https://github.com/younesaassila/ttv-lol-pro/issues/82 . Apologies for the ping :)

cloud quailBOT
cloud quailBOT
#

Is there an existing issue for this?

  • [X] I have searched the existing issues

This issue exists in the latest nightly version

  • [X] I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

When I click the emote menu, it will display the emotes, however if I click it again, the emote menu won't close. This is not consistent with the other buttons next to it, "chat settings" button, "native twitch emotes" button.

Ex...

cloud quailBOT
cloud quailBOT
cloud quailBOT
cloud quailBOT
#

@AnatoleAM Because when there are special characters next to the link, it is no longer a link, but just a set of strings.

I have to remove special characters and check if there is a link in the string after removal.

There are no special characters in the transition link itself, but they are in "displayText"

If you try to remove them, you will have to render each special character as a separate token, and you will also need to follow the order so that the message text does not change.

cloud quailBOT
#

Bumps lib/lua/src from 5d708c3 to 6443185.

Commits

6443185 "Emergency" new version 5.4.6
e15f1f2 Details
b5c6570 New year (2023)
7ca8105 More orderliness in casts of enumerations
94689ac More regularity in uses of enums in 'lcode.c'
ab859fe Bug: Loading a corrupted binary file can segfault
c4b71b7 Details
1de2f31 Corrected support for 16-bit systems
02bab9f Bug: Wrong line in error message for arith. errors
5e08b41 Simpler definition for LUA_STRFT...

#
[SevenTV/chatterino7] New branch created: dependabot/submodules/lib/lua/src\-6443185
#
[SevenTV/chatterino7] branch deleted: dependabot/submodules/lib/lua/src\-6443185
#
[SevenTV/chatterino7] branch deleted: dependabot/github\_actions/jurplel/install\-qt\-action\-3\.2\.0
#
[SevenTV/chatterino7] branch deleted: dependabot/submodules/lib/WinToast\-717e663