#github
1 messages ยท Page 28 of 1
Bumps lib/lua/src from 5d708c3 to b5c6570.
Commits
b5c6570 New year (2023)
7ca8105 More orderliness in casts of enumerations
94689ac More regularity in uses of enums in 'lcode.c'
ab859fe Bug: Loading a corrupted binary file can segfault
c4b71b7 Details
1de2f31 Corrected support for 16-bit systems
02bab9f Bug: Wrong line in error message for arith. errors
5e08b41 Simpler definition for LUA_STRFTIMEOPTIONS
cf08915 New macro LUA_USE_IOS
c888ae0 Small changes i...
ee668e6 Bump lib/lua/src from 5d708c3 to b5c6570 - dependabot[bot]
[SevenTV/chatterino7] New branch created: dependabot/submodules/lib/lua/src\-b5c6570
[Website] Branch ci/update\-locale was force-pushed to `f78dd50`
@AnatoleAM PR updated and nit fixed.
169f419 Mark experimental builds at the start of their ... - pajlada
421497c Mark builds as experimental (#4553) - pajlada
7285686 Mark builds as experimental (#4554) - pajlada
ec4ec79 Mark builds as experimental - v4 (#4555) - pajlada
cb0ab90 Add qtimageformats Module in Qt6 CI Builds (#... - Nerixyz
For future proofing (i.e when actual support for modifiers is added) this should be inverted to say "Show Emote Modifiers" (default false)
Channel ID isn't a user-friendly parameter, it's virtually impossible for a regular user to find that value. This would need to either use login name, or make an intermediate query for the channel ID. (see useApollo & related code for interacting with Twitch's internal apollo instance)
169f419 Mark experimental builds at the start of their ... - pajlada
421497c Mark builds as experimental (#4553) - pajlada
7285686 Mark builds as experimental (#4554) - pajlada
ec4ec79 Mark builds as experimental - v4 (#4555) - pajlada
cb0ab90 Add qtimageformats Module in Qt6 CI Builds (#... - Nerixyz
nonce is undefined if the message isn't sent directly from the current tab. I believe it may be best to make a author ID check.
nit
const showSelfHighlights = useConfig<boolean>("highlights.basic.you");
nit
hint: "Whether or not to highlight messages sent by yourself",
This is fine for now.
I'd like to note though in the future we should look at getting this from twitch's highlight settings.
cc6dcfe feat: add option to hide suspicious user highli... - Niller2005
cc6dcfe feat: add option to hide suspicious user highli... - Niller2005
@AnatoleAM PR updated with request changes. This sorting happens only after sortCase() which handles the widths, so it works as expected and doesn't break the width priority.
In general I think this isn't the best approach to take, it would be best to implement a profile system with condition-based activation.
Changed it to work with channel names
695401b emote menu: skip filtering if there are no emot... - berghall
695401b emote menu: skip filtering if there are no emot... - berghall
@AnatoleAM Now a Highlight has a Blocked toggle from where it toggles it into a new config set
Still not quite sure about the "Blocked" naming, so if you have any suggestions please tell :D
PS.
The highlight saving should probably be improved in another issue, because now all the items in the table are sent over even though you're editing one.
[Website] Branch ci/update\-locale was force-pushed to `6ec188f`
#519 PR merged, issue closed.
Should be flipped with the new commit.
Since we don't actually support these yet, we should specify that this only governs whether or not to show text pollution.
hint: "Show text pollution from BTTV and FFZ emote modifiers (!w, ffzHyper, etc.). Modifiers are not supported yet, this setting only affects the display of their text form",
The highlight saving should probably be improved in another issue
This needs a general refactor of the settings system. It's currently implemented in a way which does not allow non-shallow reactive updates to be detected. Hence why a save() method even has to exist in the first place.
To me double click feels kinda unintuitive especially for people that are used to Chatterino. I feel like it would be better if user could choose between double click and right click .
This could be a little less verbose, perhaps checkIgnored
Untrack this file (seems it was wrongly modified by prettier)
I think "Ignores" may be a better name than "blocked". This wording is also used in Chatterino, which the highlights system is generally inspired from.
Untrack this file (seems it was wrongly modified by prettier)
For simplicity make this optional
isIgnored?: boolean;
efb1b44 feat: add option to toggle hiding emote modifie... - polyrtm
efb1b44 feat: add option to toggle hiding emote modifie... - polyrtm
Functionality wise this works fine now. In terms of user experience though, this isn't great.
The sorting options should be within the emote menu itself. i.e, next to the search bar.
This condition has the possibility to become undefined === undefined, which would return true.
Suggest adding an additional checks
if (enabled && identity) {
chatHighlights.define("~self", {
test: (msg) => !!(msg.author && identity) && msg.author.id === identity.id,
paint should simply not be set when the option is disabled, rather than adding this extra check in the template.
ah, that is what you meant. I changed how name tags paints should be disabled overall which removes the old method which was commented to be replaced. This way the nametag paint and tooltip are disabled without extra checks like I did. :)
3a87d37 Add option to highlight your own messages (#510) - MatinAniss
3a87d37 Add option to highlight your own messages (#510) - MatinAniss
@ayyybubu I can do it, but it's not clear how it should be displayed in the settings menu.
I need to make a dropdown list, where the default value will be, is the author's nickname quick selection disabled?
[Website] Branch ci/update\-locale was force-pushed to `7d9a331`
@AnatoleAM PR updated with the requested changes and the terminology is now "Ignores"
Checklist
- [X] I'm reporting a problem with Chatterino
- [X] I've verified that I'm running the most recent nightly build or stable release
- [X] I've looked for my problem on the wiki
- [X] I've searched the issues and pull requests for similar looking reports
Describe your issue
There used to be an AppImage version of Chatterino7 on every new release, but I've noticed that the latest ...
@AnatoleAM I guess I should use the font-awesome icons and I need the svg, so could I get them from you?
Was thinking for the order these two https://fontawesome.com/icons/sort-up?f=classic&s=duotone&sc=%231E3050 and https://fontawesome.com/icons/sort-down?f=classic&s=duotone&sc=%231E3050.
For the sort type https://fontawesome.com/icons/bars-sort?f=classic&s=solid
This might have been implemented already, but is already de facto behaviour in 3.0.5
Yeah the dropdown list is the way to go. It's kinda whatever if the setting is on or off by default since its not really disruptive
@berghall added the icons on your branch
[Website] Branch ci/update\-locale was force-pushed to `9cb2a71`
@ayyybubu Made edits. Updated function descriptions in settings, corrected code, corrected logs for nightly release.
screencast-github.com-2023.04.18-21_44_53.webm
Tested:
-
Toggle click option.
-
Saving the selected setting after reboot
-
the settings work in the test chat and when switching to other real streams.
Close, but needs some improvement on the UX side
- Split ignores into a new setting category
- Instead of adding
isIgnoredon highlights, pass an argument touseChatHighlightsto define whether to use ignore or highlight mode - Define the config key used based on the mode passed to the composable
This isn't actually a good fix. It's more of a band-aid; the problem stems from earlier up.
Not enough information here, try with a clean browser environment (no other extensions, default settings, etc). If this persists, create a new issue.
@AnatoleAM changed it to use channel name
[SevenTV/Extension] New tag created: v3\.0\.6
This will not work on non-english languages
@AnatoleAM I don't really understand what exactly is involved. If we are talking about some part of the code, please show me. I'll try to fix it.
@AnatoleAM This PR is ready. Could this be merged since it is a QoL that some users have asked for?
Bumps lib/lua/src from 5d708c3 to e15f1f2.
Commits
e15f1f2 Details
b5c6570 New year (2023)
7ca8105 More orderliness in casts of enumerations
94689ac More regularity in uses of enums in 'lcode.c'
ab859fe Bug: Loading a corrupted binary file can segfault
c4b71b7 Details
1de2f31 Corrected support for 16-bit systems
02bab9f Bug: Wrong line in error message for arith. errors
5e08b41 Simpler definition for LUA_STRFTIMEOPTIONS
cf08915 New macro LUA_USE_IOS
Additio...
e0842b0 Bump lib/lua/src from 5d708c3 to e15f1f2 - dependabot[bot]
[SevenTV/chatterino7] New branch created: dependabot/submodules/lib/lua/src\-e15f1f2
I have looked a bit further into this, and it seems to be due to images tagged with color spaces, the majority of these (not all), were taken in mpv, with screenshot-tag-colorspace set to yes.
[Website] Branch ci/update\-locale was force-pushed to `b2dfe2a`
@AnatoleAM now the Ignores are in Chat > Ignores
This predicate is weak and has an extremely high chance of hitting the wrong component.
DOM operations are not preferable. Consider mutating the returned node instead. Currently, you are essentially not making any actual use of the hook.
Works pretty good but the only issue is that it should also add a space or a comma and a space after the name automatically. For example "@ayyybubu, ".
07a707e Add a tooltip to show full "Replying to @..." t... - tautautautautau
07a707e Add a tooltip to show full "Replying to @..." t... - tautautautautau
This is unnecessary duplicate code. Re-use SettingsConfigHighlights.vue and pass a prop to determine whether to use ignores, in which case you can hide some of the options and pass that prop to the composable.
Determine higher up which store to use (data.highlights/data.ignores) based on the composable parameter, shouldn't be a need for an if/else here
Upstream removed appimage builds on Ubuntu 22.04 in https://github.com/Chatterino/chatterino2/pull/4400. Since Chatterino7 doesn't build with Qt 5.12.12 (removed in https://github.com/SevenTV/chatterino7/pull/69), no appimage was built afterwards. It would be nice to still provide appimages, but given "The AppImage from Ubuntu 22.04 is broken. Approach with caution", this s...
I'm changing the value of shouldRenderMessage below so instead of reassigning the parameter I'm copying it
@AnatoleAM how can I pass a prop to this?
You may need to add a new property there, componentProps, which you could then set to v-bind at SettingsNode.vue:19
Yeah but why not just re-assign it? It's not a constant
Good practice is to not rewrite parameters and just copy them
I'd be curious to know why you believe that's good practice. Seems to me this only complicates code and only serves to allocate one extra bit of memory for no actual gain.
Alternatively you could wrap it under another component, and set the prop there.
6fdfb9c eventbridge: optimize user state command - AnatoleAM
[SevenTV/API] New branch created: chore/optimize\-user\-state\-query
using a dataloader for the userstate eventbridge command, which should fix OOM issues at scale
[Website] Branch ci/update\-locale was force-pushed to `e1273a4`
[API] Branch chore/optimize\-user\-state\-query was force-pushed to `bae1792`
@AnatoleAM controls are now next to the search input


Live input search:

Mutating might have some unintended side effects and immutability protects against this. It makes me uneasy when reassigning parameters :)
It will have no side effects here. Due to this being one of the most called functions, currently I don't want a change like this. It actually provides no tangible benefit.
@ayyybubu How long does it usually take to accept a request?
As I understand it, AnatoleAM is in charge here. Do all pull requests go through it?
And you can also see other requests, too, please.
#509
#499
Not really a fan of adding more clutter to the menu and shrinking the size of the search bar. All of this could be wrapped inside a single context menu.

Would it be possible to add an option to toggle the AM/PM for timestamps? or even toggle 7tv's control over timestamps and leave it like the default twitch setting
I tested this
current behaviour: I type "kek" in the search input -> shows kek emotes in 7TV tab and I have to click to FFZ or BTTV tab to see another kek emotes
what BTTV does: I type "kek" in the search input -> shows all kek emotes in the current tab from all sources, I don't need to switch tabs
[Website] Branch ci/update\-locale was force-pushed to `97c8960`
Added shields to the README and rearranged some things.
README Screenshot:

Not Applicable anymore
Not Applicable anymore
I've removed use of the incorrect hook usage. We still perform DOM query to find the location for the teleport
Is there an existing issue for this?
- [X] I have searched the existing issues
This feature does not exist in the latest nightly version
- [X] I have checked the latest nightly version
Feature Description
As a moderator i'm asking if bits possible to completly hide the "pin" button or make a popup asini if mi sure, since bits near of reply i missclick a not of time
I have a similar problem. For me, 7TV prevents that FFZ and BTTV emotes are being recognised. instead, in every chat, whether stream or clip, only the text is displayed instead of the emote.
When the user is timed out, the anchor and input elements are deleted, causing a bug that makes the menu appear at the top left. The input-container can serve as an anchor since it isn't deleted.
Is there an existing issue for this?
- [X] I have searched the existing issues
This feature does not exist in the latest nightly version
- [X] I have checked the latest nightly version
Feature Description
Add hints for custom emotes like the Twitch's emote in the image:

Description
This is a reference to the upstream version. There's no flatpack of this fork.
b26b153 fix:r remove flatpackref in artifacts (#217) - Nerixyz
b26b153 fix:r remove flatpackref in artifacts (#217) - Nerixyz
Or swap copy button position with pin button
This feature has been available since version 3.0.0.

Is there an existing issue for this?
- [X] I have searched the existing issues
This issue exists in the latest nightly version
- [X] I am using the latest nightly version
What browsers are you seeing the problem on?
Chrome, Firefox
Current Behavior
A channel has a 7TV emote named "Stare", which conflicts with the 7TV global emote "Stare". When using colon-completion for the emote, you correctly see the channel emote:

@lumynou5
1. Have you tested on Nightly? 2. is it possible to screen record a moving chat to see the scroll effect?Also, do you have any specific modification based on font size or padding or any style related modification?
I am using v3.0.6.1000 Nightly version and I can see smooth scrolling with no chatbox overlapping the chat
Y...
I just tried to use git bisect but can't reproduce in Chromium...
Because it seems not happening always, I don't know if it's Firefox's problem or I was just unlucky.
[Website] Branch ci/update\-locale was force-pushed to `2ff86b6`
Added a option to hide the Subscriber Leaderboard on top of chat.
This is in response to #458 and #467
Give each user 25-50 slots (more if subscribed, or more in general if anything) where they add any 7TV emote to (static and GIF alike) for use in any and all twitch channels. These emotes can be seen by both the viewer who used it and everyone else who has 7TV installed (of course, only the viewer can use it because it's their personalized emote). An optional part to this idea would be to add the ability to rename added emotes to anything the user wants [as long as it's TOS-friendly, of cou...
You'll be happy to hear that this feature already exists! Any 7TV subscriber can choose up to 5 (more may be allowed in the future) Personal Emotes, subject slightly higher moderation standards, for use in any chat globally on Twitch.
Just subscribe on 7tv.app, and add emotes to your "Personal Emotes" set, emotes which have not yet been approved for personal use may take some time to be verified, so you can filter on the search page to see only emotes which hav...
Looks like #481 already covers that
4b54db9 http eventbridge - AnatoleAM
3340323 use http server for eventbridge - AnatoleAM
@ZemyCode any updates on this PR?
[API] Branch chore/optimize\-user\-state\-query was force-pushed to `a758851`
1702c0f fix bad exit handle - AnatoleAM
26eb9c9 mongo cursor limit - AnatoleAM
[API] Branch chore/optimize\-user\-state\-query was force-pushed to `a1e3aba`
8629759 change queue timing - AnatoleAM
[API] Branch chore/optimize\-user\-state\-query was force-pushed to `8be55ce`
[Website] Branch ci/update\-locale was force-pushed to `1ac1324`
Added more clear steps for Windows and also added the License for a quicker overview.
Is there an existing issue for this?
- [X] I have searched the existing issues
This feature does not exist in the latest nightly version
- [X] I have checked the latest nightly version
Feature Description
Since the amount of available emote slots got increased again, we are at a point where the possibility of multiple emote sets being used at the same time would get very handy, especially when users want to replace emotes for Spooktober and Christmas.
This could be done by...
This is already possible through the website. Hit "Edit" on any emote set you have access to then hit "Add Origin" you can then have that sets emotes automatically be merged and synced into the base set.
[Website] Branch ci/update\-locale was force-pushed to `a2d23eb`
Thank you, I did not know that! But I will post another feature request expanding on this.
Is there an existing issue for this?
- [X] I have searched the existing issues
This feature does not exist in the latest nightly version
- [X] I have checked the latest nightly version
Feature Description
Since it is possible to group different emote sets into one active set, for the sake of a more clear overview, grouping the emotes not just by the plugin, but also by the name of the emote set.
For example, all the emotes from the emote set "forsen" could include all the ...
If I were to combine them into one menu, then I'd need these two:
https://fontawesome.com/icons/arrow-up-wide-short?f=classic&s=solid
https://fontawesome.com/icons/arrow-down-wide-short?f=classic&s=solid
I was thinking of adding a system preference option and detect the cycles by locale, but it felt maybe a bit overkill.
Closes #527