Can't compile Skytils 1.10.10

[glossy oyster]

Getting this error:

SkytilsMod/src/main/java/gg/skytils/skytilsmod/mixins/transformers/gui/MixinGuiIngameForge.java:46: error: highlightingItemStack has private access in GuiIngame
GuiIngameForgeHookKt.modifyItemHighlightPosition(args, highlightingItemStack);

This file last changed months ago, but I compiled 1.10.9 when the release came out just fine. Haven't tried downgrading to 1.10.9 and compiling yet, so I don't know if its a environment change that broke it in my system, but nothing relevant seems to be changed in Gradle configuration when looking at commits between 1.10.9-1.10.10, so I have no idea how this issue didn't occur before, because I have checked and GuiIngame#higlightingItemStack is, actually private, and not protected, therefore extending GuiIngame in the mixin should not let us access this field. I suspect a @Shadow field or another Accessor Mixin is required to access this field, but I'm not sure how it worked before at all. Maybe my gradle caches got corrupted or cleaned in my system and Skytils CI is still using a cache and thats the reason why it failed only on my system and just now instead of before?

I also don't have any idea how this does not cause an error in runtime - possibly I have another mod that has a Access Transformer configured to make the field public?

[terse otter]

imma see if I can replicate that I guess

[glossy oyster]

try running gradle with --refresh-dependencies --rerun-tasks --no-build-cache --no-daemon

it should run all tasks and bypass cache and regenerate forge jars, perhaps would make the error appear

[terse otter]

you're on unmodified 1.x or dev branch right?

[glossy oyster]

At the moment yes, i have git stash'ed my changes to see if they were the culprit with no luck. I have added an AccessorGuiIngame mixin as a workaround in the meantime to get a working jar till we can pinpoint the exact issue

[terse otter]

I'll be home in about 20 minutes so I can test in like 1 hour :D

[terse otter]

Gonna try 54a9148 on the dev branch, but should be identical with the 1.x branch

Waiting for intellij to import Gradle project

Unknown command-line option '--no-daemon'. when running gradle --refresh-dependencies --rerun-tasks --no-build-cache --no-daemon build so I'll simply remove it

no compile-time error, imma launch in my mc instance but without any mods to see if it's fine at runtime

tldr: works fine for me

[glossy oyster]

i assume you only removed the --no-daemon and kept the no cache flags?

i'm trying wiping my entire ~/.gradle in the home folder and the relevant build/ and .gradle/ folders in the project folder at the moment, already took a backup to restore in case it doesn't work, will update if it fixes the issue, altho im still not sure whats going on since the field seems private in my decompiled code

might try spinning a vm to ensure a completely fresh build later

[terse otter]

yeah, only removed the --no-daemon

[terse otter]

uuhh before you do that

GuiIngame#higlightingItemStack is actually protected, not private

Tho ig deleting the gradle caches fully and redownloading might fix it

And I think it has to be protected cause we're mixing GuiIngameForge which would need it to be protected otherwise it can't access it

tho tbh, I hate gradle so no clue how you'd actually go about fixing it

[glossy oyster]

it's still building at the moment after cleaning of all relevant gradle folders, ill see if it works

loom mightve generated a wrong forge jar with the field private or something possibly because it was saying its private

okay, it took more than 20 minutes to build but it worked

really weird, no idea what was the issue lol, regardless im happy that i can build it again, going to close the thread

[terse otter]

you can close threads here? crazy