#crash on terminal interface
1 messages · Page 1 of 1 (latest)
@rough relic uploaded a log, and here's the crash log
- Forge 11.15.1.2318 on 1.8.9 using 8 mods
- OptiFine L5
Possible Solutions:
- Update OptiFine from L5 to M5
Caused by hypixel using a 1.20 item in the Starts With terminal apparently
#general they are sending null packets
That cause some gui to bug out
Disable custom terminal gui
As well as NEU gui
Didn't know that item names can be null ngl
thought it'd just default to the item registry name or smth
Yeah
Hypixel did a funny
Made them render null items
Afaik it was hovering over these that made your game crash
banners
Ahh ic
yell at timedeo to stop making banners
fr
Pretty sure odtheking is wrong here, the error happens inside the vanilla's getDisplayName method, not in mod code. Check the stack traces more carefully.
Looking at the source code of ItemStack#getDisplayName, everything else besides ItemStack#getItem has a null check. So I'm pretty sure the root cause of the error is that ItemStack#getItem returns null.
I don't know why would ItemStack with a null Item make sense though, and since this never happened before the backend changes maintenance on 21st, I agree that this a fuckup in Hypixel's end, but mod's cant do anything even if they add null checks about ItemStack not being null and getDisplayName not returning null because the ItemStack is alreaady not null and the error happens INSIDE ItemStack class getDisplayName method (a.k.a vanilla code) and not mod code, and the error is caused by Item inside the ItemStack being null not the ItemStack itself.
The only way to fix it from mod's side would be to Mixin into ItemStack class and make getDisplayName return an empty string if ItemStack#item is null (or mixin into getItem method and return a default placeholder item if the item is null).
The part where odtheking says its in all menus are also wrong. This only affects starts with terminal in phase 3. I and my friends never crashed anywhere else.
For now, I recommend getting Polyfrost's CrashPatch mod so that those crashes won't close or interrupt you, you can just dismiss the errors and keep playing (re-open the terminal after dismissing the error)
Bump the crash limit to leave the world/close the game to the max in CrashPatch config temporarily till Hypixel fixes the issue
ItemStack#item was the material right?
Like paper, oak_log, diamond_sword and so on right?
Yea
I did not diagnose further but I'm %99 sure its because of item being null. Possibly what you said is correct and it sends 1.20 items, need confirmation though
Looking at the skytils code from ItemUtil (which should be identical to the vanilla function) the first thing it does is get the name for the material. Since the rest of the code is checked I'd also guess it's that
(And null stack shouldn't be an issue since that's what vanilla checks for before the call anyway and all mods as well)
Oh I did not realize Skytils has its own function to get display name, why is that the case? Then for Skytils the point where the error happens inside vanilla getDisplayName does not apply i guess
Okay yea I can't link the message and have it show up
But it's identical to the vanilla code and is interchangeable so it's gonna have an identical problem
Yes, either hypixel fixes the issue or skytils method and ItemStack's method (via a mixin) gets modified to return an empty string if ItemStack#getItem is null (or mixining into getItem directly and returning a placeholder item)
Or perhaps adding all the 1.20 items to the item registry but that would probably cause more issues than it solves
The issue arose from hypixel doing exactly that but on server side probably?
mixin into getItem is theoretically better cause it also fixes skytils ItemUtil one, but hypixel probably gonna fix (and any method that wants an unmodified version of the display name)
(but let's have hypixel fix it cause this should've never happened)
I'm going to try writing a mixin and return a placeholder item to see if it fixes the issue I guess
This will of course be temporary workaround that i will only use for myself to avoid crashpatch nagging me every time it happens
tbh if it's a 1.20 item issue that'd be amazing
Cause it means hypixel is working towards it
Or maybe a mixin not needed and I can just check if any item stack with null item exists inside a gui open event and if so close the menu and give a warning to player in chat
I mean if you do f7 you can't do starts with term or smth
It doesn't always happen
When it happens usually just dismissing the crashpatch message and reopening the menu works correctly
weird
The items in the menu are randomized so its probably sometimes you get 1.20 items and sometimes 1.8
I have had reports of people crashing in other guis with the same issue
and you are right its inside the minecraft class ItemStack but mods can still use their own method for it which would not cause that that issue (kotlin basic null saftey of not getting display name of null item can fix it)
Odtheking beat me to it 😦
Maybe it is fixed server-side now because I did like 20 runs other day and did not have any issues (specifically after the last 2 sb version changes in cowshed), will update here if it still seems to happen
had someone crash like 4 minutes ago
Ah, I guess i was just lucky other day then.
Thanks to CrashPatch i dont actually crash but the popup of error and having to dismiss it and reopen the terminal is still annoying.
I dont have issues in any other terminals or other menus so far.
Absolutely fire
You have a 1/ (something I can’t be assed to figure what) chance to roll the starts with B terminal
You were lucky ig
Yeah, I had it happen like 2 times today so it is not fixed sadly, I was just lucky other day. M7 was kind of annoying with all the bugs and annoying mechanics they have changed lately, list for reference:
- Goldor TNT doing knockback, not as much as annoying as others but definitely sucks. Maxor TNT also pushes you from the conveyor belt I think but i had that happen only a few times rarely, they at least made the vanilla skull attacks not do KB on last patch though so that's progress i guess.
- Simon Says (Device at Section 1 of Phase 3) breaking (songreaver said its a skytils bug, but it didnt used to happen before maintenance so even if a skytils bug its triggered by hypixel changing something, as usual)
- Of course, the bug on this thread, with starts with terminal causing people to crash.
- And finally add the average M7 servers suboptimal ticks per second to the mix.
Overall very annoying to play lol.
Hear me out
Quit till hypixel fixes its shit (never)
But yeah
M7 is ass
I was talking to a few of my friends and they were saying the same thing
M7 sucks to play and you should play m6 for cata xp till m7 is fixed
talks about changed mechanics
doesnt mention bonzo or stairs
Yeah those as well, those i wrote were just the issues off the top of my head that were specific to f7/m7 boss fight, bonzo pearls and stairs generally affects all floors (well bonzos mainly used for f7/m7 as well but pearls and stairs all floors)
In addition, those changes could be considered bug fixes, bonzo was to prevent people from lagging servers for carnival or something iirc - and you can still bonzo, theres new routes for pearls and you can still go through stairs its just more annoying (usually you have to ghost pick it), meanwhile crashing, ss breaking etc. are more critical issues (in my opinion) and tnt doing kb is the opposite of a bug fix because shelmet is supposed to prevent all knockback, they got rid of the whole "true knockback" thing long time ago.
All in all I think the admins only revert stuff like this if there's a huge community backslash, like the one time where they completely patched stonking then reverted, and then when they disabled using pearls in trap but reverted
I guess there wasn't enough backslash from community regarding bonzo, changed pearls or stairs to warrant a revert, maybe they dont even know that people complain about those issues lol, I wouldn't be suprised
Pretty sure term crash is gone (server side) now even though no patch notes, never had it happen for a few days if not more and newest st pre release fixed ss as well so that's good, only annoying thing left for me is TNT kb i'd say
Correct me if im wrong and you saw anyone crashing lately.
no crashes
but try walking up iron bars in dungeons
You can't anymore?
lag backs everywhere
Well there is no bomb defuse anymore and i dont know where else youd want to walk through bars
layers
tp maze
like seriously just start a run, in the entrance room there's some bars on the left
try and jump onto them
Well, it's probably for the better
I don't have any issue with them improving watch dog as long as it doesn't interfere with normal gameplay (like getting lag backed in snow layers in glacite tunnels was SO annoying)
it does
you can't go walk over bars
Well normal maze is fast enough
not in maze
like just at all
like normal iron bars that you could walk over in vanilla
you can't anymore
Ooh
I thought you meant walking through it like on bomb defuse my bad
So it just lags back while walking on top of iron bars?
Yeah that seems like an issue then
oddly enough, I think that's still fine
that or trying to jump over