#account for real rune lowest bin in Container Sell Value

1 messages · Page 1 of 1 (latest)

verbal steeple
#

I'm not really sure what's happening or what's wrong but right now if a rune is over 52m, the Container Sell Value just values it as 52m and only add 52m to the total container value, even if the rune is worth much more.
They are actually worth and sell at over 350m+ on lowest bin, so I'd like for them to be valued correctly when they are added up in my investments backpack.

tame condor
#

Based on the fact that both runes are 52m, it probably just picks a rune and gives that value to all runes

willow vine
#

It does the same for abicases

#

At least "show lowest bin price" suggest that

tame condor
#

It's based on the skyblock id iirc, so if the item has the same id it'll show up as same price

#

ig to fix it you'd need extra checks for certain items for example with runes you check like the rune level + rune type?

#

Actually nvm at least for abiphone it has seperate entries, or am I missunderstanding how the item works?

#

yea actually nvm, I was completely wrong with my assumption

#

"RUNE-MEOW_MUSIC-3":464000000

#

@verbal steeple does it also show the incorrect prices on the item itself? (Show Lowest Bin Prices needs to be enabled)

verbal steeple
#

i think im using neu’s lowest bin thing for the items themselves

tame condor
verbal steeple
#

oh ok yeah im using neu

#

i got of my pc cause im going to school so i cant check rn 😭 mb

tame condor
#

np

#

It's prob faster if I join the game myself but I can't be bothered xd

#

the thing is, from what I see it should work

verbal steeple
#

so it’s def picking a rune and applying it to all the fire sale/taylor runes or something

#

weird

tame condor
#

Imma see if I can figure it out

verbal steeple
#

alrighty, thanks

tame condor
#
{ench:[],HideFlags:254,SkullOwner:{Id:"35bcd175-8dc6-306c-a566-45e318814a12",Properties:{textures:[0:{Value:"ewogICJ0aW1lc3RhbXAiIDogMTcwMTUwOTIxMjExNiwKICAicHJvZmlsZUlkIiA6ICIyYzEwNjRmY2Q5MTc0MjgyODRlM2JmN2ZhYTdlM2UxYSIsCiAgInByb2ZpbGVOYW1lIiA6ICJOYWVtZSIsCiAgInNpZ25hdHVyZVJlcXVpcmVkIiA6IHRydWUsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS80Yzg2N2E1NzIzZDJlMGYyNGE3ZGM0YTljNzY3YTQ2NThkMTJmOTA3NWQ4MTVmNTFhMGU3ZjJlYTc1YmRlNDM0IgogICAgfQogIH0KfQ=="}]}},display:{Lore:[0:"§8Requires level 0",1:"§8Weapons",2:"",3:"§7Plays captivating meows when slaying",4:"§7an enemy. Obtained from Fire Sales.",5:"",6:"§7Apply this rune to weapons or fuse",7:"§7two together at the Runic Pedestal!",8:"",9:"§6§lLEGENDARY COSMETIC",10:"§8§m-----------------",11:"§7Seller: §a[VIP] Plasicul",12:"§7Buy it now: §6378,000,000 coins",13:"",14:"§7Ends in: §e13d",15:"",16:"§eClick to inspect!"],Name:"§f§f§e◆ Meow Music Rune III"},ExtraAttributes:{runes:{MEOW_MUSIC:3},id:"UNIQUE_RUNE",uuid:"d750fd4a-34ed-43e9-a3ca-0a6874ac9571",timestamp:1703059200000L}}
#

ohh I see the issue

#
{ench:[],HideFlags:254,SkullOwner:{Id:"fee7f27e-d2b6-3267-97e7-5a69f1038c9c",Properties:{textures:[0:{Value:"ewogICJ0aW1lc3RhbXAiIDogMTY1OTUxMDc3NzU4OSwKICAicHJvZmlsZUlkIiA6ICI5MThhMDI5NTU5ZGQ0Y2U2YjE2ZjdhNWQ1M2VmYjQxMiIsCiAgInByb2ZpbGVOYW1lIiA6ICJCZWV2ZWxvcGVyIiwKICAic2lnbmF0dXJlUmVxdWlyZWQiIDogdHJ1ZSwKICAidGV4dHVyZXMiIDogewogICAgIlNLSU4iIDogewogICAgICAidXJsIiA6ICJodHRwOi8vdGV4dHVyZXMubWluZWNyYWZ0Lm5ldC90ZXh0dXJlLzg3MjE3YTc5MTY4NWNmNGZiYjc4Njc0NzU2YTRmOTc5M2FlNWZkMDUyNWRhZTM2MmI0OTFjYzdhNDcyZWM2NGIiLAogICAgICAibWV0YWRhdGEiIDogewogICAgICAgICJtb2RlbCIgOiAic2xpbSIKICAgICAgfQogICAgfQogIH0KfQ=="}]}},display:{Lore:[0:"§8Requires level 0",1:"§8Chestplates",2:"",3:"§7Special look on the Crimson Isle!",4:"§7Obtained from Fire Sales.",5:"",6:"§7Apply this rune to chestplates or",7:"§7fuse two together at the Runic",8:"§7Pedestal!",9:"",10:"§6§lLEGENDARY COSMETIC",11:"§8§m-----------------",12:"§7Seller: §b[MVP§c+§b] Log1xMeister",13:"§7Buy it now: §61,499,999,999 coins",14:"",15:"§7Ends in: §e5d",16:"",17:"§eClick to inspect!"],Name:"§f§f§c◆ Grand Searing Rune III"},ExtraAttributes:{runes:{GRAND_SEARING:3},id:"RUNE"}}
#

yea it classifies as a UNIQUE_RUNE instead of a RUNE

tame condor
#

Okay I made a pr, if you can't wait for likely the next release and got a github account you can get it from here (And ig if you trust me)

tame condor
#

Okay has been merged so it'll be in the next release

verbal steeple