Attempt to clarify environment marker ev... | PyPA | Page 1

mighty vault Apr 26, 2026, 6:45 PM

#

what's the process for merging something into packaging.python.org?

#

(i had reviewed henry's writeup)

spiral dirge Apr 27, 2026, 11:01 AM

#

Generally just "at least 1 of the editors is willing to sign off on merging it". This has the quirk that when one of us writes a PR, it needs two editors to approve it (since the repo permissions are set up to disallow merging our own PRs).

mighty vault Apr 27, 2026, 10:42 PM

#

i think i'm producing more comple situations, like https://github.com/pypa/packaging.python.org/pull/2035

GitHub

Don't block PRs on linkcheck by konstin · Pull Request #2035 · py...

Fixes #1998
Currently, linkcheck is blocking PRs if any link in the project isn't accessible. Due to the high number of links, this regularly blocks unrelated PRs (see #2018 for a recent ex...

spiral dirge Apr 27, 2026, 11:16 PM

#

Yeah, I'm with @vague trout on that one - link rot hitting every PR is a pain, but expecting us to check links manually instead isn't a good answer

mighty vault Apr 27, 2026, 11:28 PM

#

i mean the link check still runs, it's just not blocking anymore

#

the problem is that the link check currently blocks any change anytime an unrelated page goes down

#

i'd like to file fixes to specs, but you currently run into an unclear approval process and technical hurdles like linkchecker rejecting valid PRs

vague trout Apr 28, 2026, 9:24 AM

#

mighty vault the problem is that the link check currently blocks any change anytime an unrela...

I'd like to fix this by only checking previously non-existent links (and having that blocking) instead of shifting the maintenance burden on the maintainers. I'm just not ready mentally to be responsible for checking something non-blocking as a part of each review. But if there's a proper automation that doesn't let more broken links pile up, that would be a good middle ground.

spiral dirge May 10, 2026, 10:11 PM

#

Bumping this, since the link check situation has been improved (thanks @mighty vault , @vague trout )

mighty vault May 11, 2026, 4:20 PM

#

looks like pradyun tried to merge it, but it needs an approval for the merge to go through?

#

(currently reading)

spiral dirge May 17, 2026, 2:13 PM

#

Thanks for that review @mighty vault - the unknown markers and extra == ... clarifications were two important issues to sort out.

I agree in spirit with the Graal Python change, but only went as far as dropping the Jython call out, as I'm not sure what platform.python_implementation() actually emits there (if they haven't patched the stdlib, it will likely be nonsense)

#Attempt to clarify environment marker ev...