#https://iscinumpy.dev/post/packaging-

1 messages · Page 1 of 1 (latest)

uneven hatch
#

There's a minor typo, but it took me out while reading through, so I figured it's worth at least mentioning, even if you ultimately decide not to fix them. Also figured I'd avoid clogging up the main chat via a thread; hope that's fine.

There are two codeblocks that look close to this:

def f(x: Version | str) -> str:
    if isinstance(Version, str):
        version = Version(version)
    return str(_TrimmedRelease(str(version)))

In both, the parameter should be called version, and the first argument to isinstance should be all-lowercase version, I think.

prisma sandal
#

Ahh, I thought I fixed the copy-paste errors there, thanks!

uneven hatch
#

No problem. Nice article, btw 😄

prisma sandal
#

The original version was worse, btw:

def f(x: version: Version | str) -> str:
    if isinstance(Version, str):
        version = Version(version)
    return str(_TrimmedRelease(str(version)))

is how it ended up somehow

#

I picked the wrong one to delete based on the ones above