#ninja, Windows, GitHub Actions
grave portal
Oh, joy, GitHub still have 20250309.1.0 images in the runner pool, so whether this passes or not is going to be intermittent for a while.
grave portal
🤦♀️ There's a ninja project on PyPI so you can declare a Windows-specific build dependency on it. (Although I still don't know what's different between my test setup and the one in dynamic-library that makes the venvstacks test wheels need that extra dep)
worn osprey
yeah, I am pretty sure meson-python pulls the ninja package regardless
the design makes sense, meson-python can declare it as a Python dependency, which Python package managers will fetch from PyPI
and downstream distributor, like Arch Linux, can simply remove the Python depedency in their build, and declare a native one instead
(it should probably be done with a patch, instead of a sed command, but eh 😅
grave portal
Hmm, my build was definitely failing, so now I'm wondering if meson-python moved that dep to an extra
grave portal
It looks like meson-python only ever had ninja as a test dependency: https://github.com/mesonbuild/meson-python/commit/839765dd67b1eddd5cd8c7ed08145e5335bf38d2
meson itself more recently gained it as a dedicated extra: https://github.com/mesonbuild/meson/commit/e1bb424d251d698cd2f70ebaa935cec1e0aad52d
Edit: although, for the distro case, I did see some references to it as a dynamic build dependency as well.
So I still don't know how the dynamic-library test case passed on Windows, but I'm happy I correctly worked out why the venvstacks one was failing.