installer PR 147 | PyPA | Page 1

wet patio Nov 16, 2022, 3:49 PM

#

Hiya, this mostly needs me to make time to look at installer.

vapid bronze Nov 16, 2022, 4:46 PM

#

Hi, so my approach is quite different from what you mentioned in installer#105, because that seemed not possible (without modifying WheelSource and WheelFile and adding corresponding methods to support this)

As for validate_record, I thought that traversing the zipinfo is the cheapest approach to make it "sound". The file hash and size validation is left to validate_all_files_match_record as you mentioned because that seems very expensive (for larger wheels) 😉

These words are here just for some background information 😊

vapid bronze Nov 26, 2022, 7:57 AM

#

Hi, sorry if interrupt. But it's been over a week or so, anything I can help to make progress?

wet patio Nov 26, 2022, 11:03 PM

#

Nope, but I've finally found the time to look through installer -- that PR now has a review. I really appreciate your patience on this, and I'll likely have time in the coming days for a quicker feedback cycle on this! :)

vapid bronze Nov 26, 2022, 11:37 PM

#

Thanks for the review, I'm making changes according to the review and will get back as fast as soon as I finished 😄

#installer PR 147