#X stuff

1 messages · Page 1 of 1 (latest)

autumn carbon
#

Interesting find, but it doesn't look like a direct cause.

stone bone
#

I narrowed it down to those 3 mods

autumn carbon
#

Thank you!

stone bone
#

With environmentx, relicex, wizard armor does not have attributes

#

same with spellblade armor

autumn carbon
#

I'm fairly confident this is an issue to be fixed on their side, since nor Wizards or SpellPower does anything non vanilla with attributes

stone bone
#

i think i have a solution, testing it right now

stone bone
#

Fixed it, it's as simple as moving all armor classes to Fabric project and renaming "getDefaultAttributeModifiers" to "getAttributeModifiers"

#

tried so many different things lol

#

Basically, you can't have armor items in the common project with architectury if you're using the combination of these 3 mods

#

@autumn carbon

autumn carbon
#

Could you explain why not?
Is there like a Fabric docs that mentions this?
I am trying to pinpoint wether or nor not this really is an issue in Wizards code

stone bone
#

I believe its because when a mod makes modifiers to the attribute modifiers of an item, doing so in fabric with respect to the itemstack's tags requires you to use the getAttributeModifiers method, which is only available in fabric API

#

Basically, in the code for PlayerEx and RelicEx, the author clears puts the attribute modifiers in the tags of the item, clears the attribute modifiers of the item via Mixin, and then sets the attributemodifiers of the item again via the getAttributeModifiers method

#

so i believe that it would be good practice to use the getAttributeModifiers method whenever possible when dealing with modifying attribute modifiers in Fabric items

autumn carbon
#

I am not sure that is a good idea.
I mean why is RelicEx touching items those don’t belong to it?

stone bone
#

Not entirely sure

#

It's working for me though, and it wasn't that hard to do