#UX #2287 & #2288 additional follow-up

95 messages ยท Page 1 of 1 (latest)

vernal agate
#

Requested by @dark gale to provide additional info.
Docker setup via compose on Komodo.

services:
  seerr:
    image: ghcr.io/seerr-team/seerr:develop
    init: true
    container_name: seerr
    environment:
      - LOG_LEVEL=debug
      - TZ=America/New_York
      - PORT=5055 #optional
    ports:
      - 5055:5055
    volumes:
      - ${DEFAULT_DOCKER_DATA}/seerr/config:/app/config
    healthcheck:
      test: wget --no-verbose --tries=1 --spider http://localhost:5055/api/v1/status || exit 1
      start_period: 20s
      timeout: 3s
      interval: 15s
      retries: 3
    #restart: unless-stopped

container starts with no issues.
both issues were initially found while using Chrome v143, both regular and Incognito. I've been able to consistently replicate both issues on Chrome.
Tried replicating on Firefox, and something different happens. On the Plex Sign-In, the "Google" login sits and spins, but pop-up window never closes.
Tried replicating on Edge InPrivate, and same effect.
Only with Chrome does it actually progress to bug #2288 initially reported

#

new symptom, while testing with firefox, the Plex pop-up window went away itself, but Seerr never progressed passed step 2. Clicking "Login with plex" again showed the pop-up again, then immediately closed.

dark gale
#

Were the different browsers tested with a fresh config everytime?

vernal agate
#

yes. each time I'm rm * -rf the mounted config directly and redeplolying from scratch

dark gale
vernal agate
#

clarification. I'm running the rm from the host itself, not within the container, so when the container starts, it's starting with a blank config folder

dark gale
#

This does sound like the browser not carrying over the cookie from plex login

#

Lets focus on one browser

#

Is Firefox set to strict mode?

vernal agate
#

negative

#

also, this is "Firefox Developer Edition", I'm not aware if it handling cookies differently, but who knows

dark gale
#

Lets try chrome then

#

Okay can you proceed to the step

#

That you initially did on the issue

#

And then send a full screenshot of the page (make sure to redact sensitive info)

vernal agate
#

give me 2m, I'll record a video

dark gale
#

Do ping me

#

Its like 4am here so I might not have discord opened

vernal agate
#

frak me. I appreciate the dialog, but if you need sleep, go get it. I can send it to you whenever

#

but I sent it direct to you, so whevener you're free, you can review

dark gale
vernal agate
#

done

dark gale
#

Can you press login a second time? Right after

#

What happens then

#

Also have browser console open

#

Oh look @silver plaza is here MoyaiSalute

silver plaza
vernal agate
dark gale
dark gale
vernal agate
#

lol. I just came up with a new symptom ๐Ÿ˜‰ Stand by, video coming.

dark gale
vernal agate
#

literally just said "F", and redoing everything with console open

vernal agate
#

lol. no worries, my fault

#

okay, so video shows me restarting container with no data. Going through setup, and signing in once. After that, you can see my mouse moving around, and i'm clicking everywhere in the background, and of course now it's not progressing to step 3 like it did when i randomly clicked earlier.
After several seconds, I click "Login with Plex" again, and this time it progresses to step 3.
Videos DM'd

dark gale
vernal agate
#

done

#

I don't want to spam Sysr3ll, should I still be CC'ing him with the videos?

dark gale
#

Okay so I see the issue now

#

So when you select from dropdown it doesnt save changes and button is greyed out until you type right?

#

After that it saves?

#

When you select from dropdown does it auto save (i can't remember how the codebase works rn and im too lazy to check lol)

dark gale
#

After scrolling down

#

Like press sync libraries

#

That should sync if saved

#

And let you select libraries

vernal agate
#

so. If it does auto-save, there's no onscreen indication or top-right notification that that happened. Scrolling down, the Continue button is still disabled.

#

and Library section is still empty

dark gale
#

If you didnt press sync libradies

#

It wouldnt auto sync

vernal agate
#

not auto sync, I mean just listing the libraries itself

#

those don't appear until you hit "Save Changes" button at the top

dark gale
vernal agate
#

let me take another video showing the "Plex Libraries" section.
Initially, there's nothing there.
After seelcting a server, still nothing there.
After doign the text dance and clicking "Save Changes", then the Libraries show up, unchecked.

dark gale
#

Can you try these steps

#
  1. Select server
  2. Then press sync libraries button
#
  1. Does the libraries show up?
vernal agate
#

so currently, the app doesn't do it in the steps you listed

dark gale
#

Sorry im a bit confused

vernal agate
#

only after I hit "Save Changes" do the libraries show up. You can see in the video I sent

dark gale
#

OH

#

I see the video

#

I will have to test the dropdwon thing. When I setup with plex today to test, I manually entered hostname

#

So could be a state bug

#

Let me really quickly grab my laptop

#

And setup plex

#

Seerr

#

With dropdwon

dark gale
#

I think i know what the issue is with dropdown

#

I have seen this reported on overseerr as well

#

Let me try a fix

vast zenithBOT
#

Fetching pull request #2289

vast zenithBOT
# vast zenith Fetching pull request #2289
PR #2289

fix(plex-settings): fix Plex preset selection not enabling save button

Description

Fixed an issue in the Plex settings page where selecting a server preset from the dropdown would populate the form fields but leave the "Save Changes" button disabled until the user manually modified a field. This was caused by not properly triggering Formik's validation. Form is now validated on mount and it properly triggers when a preset is selected.

  • Fixes #2287

How Has This Been Tested?

  • Setup a plex seerr instance
  • On step 3 selected a server from the presets

Screenshots / Logs (if applicable)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] I have read and followed the contribution guidelines.
  • [ ] Disclosed any use of AI (see our policy)
  • [ ] I have updated the documentation accordingly.
  • [X] All new and existing tests passed.
  • [X] Successful build pnpm build
  • [ ] Translation keys pnpm i18n:extract
  • [ ] Database migration (if required)
dark gale
#

And i figured out issue #2288

#

The reason is because

vast zenithBOT
#

Fetching pull request #2213

vast zenithBOT
# vast zenith Fetching pull request #2213
PR #2213

fix: disable automatic auth revalidation on auth pages

Description

Prevents unnecessary /api/v1/auth/me requests on login, setup, and password reset pages. These requests used to return 401/403 errors since no user would be logged in, spamming reverse proxy logs and triggering fail2ban rules for users running seerr behind reverse proxy/fail2ban setups.

This PR disables SWR's automatic revalidation (on mount, focus, and interval) when on auth pages, while keeping manual revalidation functional so login flow still works correctly.

  • Fixes #738

How Has This Been Tested?

  • Monitored the network logs when on the above mentioned auth pages

Screenshots / Logs (if applicable)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] I have read and followed the contribution guidelines.
  • [ ] Disclosed any use of AI (see our policy)
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [X] Successful build pnpm build
  • [ ] Translation keys pnpm i18n:extract
  • [ ] Database migration (if required)
dark gale
#

This fix

#

Forgot to account for the fact that plexLogin relies on swr revalidate

#

And i wasnt able to recreate because I was accidentally testing on 2.7.3 ๐Ÿ˜†

#

This is what happens when you try to do shit at 5am with no sleep ๐Ÿ—ฟ

silver plaza
#

TL;DR I guess you don't need me anymore for this @dark gale ?

dark gale
#

All of the issues are fixed now