Element Def Upcut does not work correctly

[unkempt urchin]

Summary: Element Def Upcut does not give Element Resistance/Defense as it implies in the Stat window. It still works like the old element resistance before the rework. To be short: it just gives 20% more Def just like the normal Def-Upcut. It was probably forgotten when they updated element resistance a few years ago.

Server: Any
Character: Any
Position: Any

Visual proof: /

Expected result: It should give 20% Elemental Resistance, similar to Suit element res and the shield awake.

Actual result: It just gives 20% more DEF

Additional comments: Informations provided by @steep plover

[steep plover]

then again, the items description literally says "adds +20% <ELEMENT> DEFENSE"
It does not say +20% <ELEMENT> resistance. So I doubt this is even a bug

[unkempt urchin]

it gives Element Resistance in the stat window, so that would be misleading
and it doesnt give defense in the stat window nor does it in flyffulator

[steep plover]

because the defense is only applied during calculations. Much like how element attack is listed separately.
Looks like another H window bug if you ask me.
When element resistances were still skill exclusive, suit element and cw armor resistance stacked in the H window too.
I wouldnt trust that window one bit

[unkempt urchin]

up

[unkempt urchin]

up

[unkempt urchin]

up

[steep plover]

Down 👀

[gleaming mauve]

I fixed the character window information by splitting element resistance and element defense. Later these items will get a rework, so they aren't removed when unequipping the suit, etc.

[unkempt urchin]

[steep plover]

I doesnt suit element also add elemental defense? To my knowledge, it does. It is in the same function that handles element attack, unless you split that when rewriting the code base.

For reference; the original code is found in this function:
void CMover::GetDamagePropertyFactor( CMover* pDefender, int* pnATKFactor, int* pnDEFFactor, int nParts )

and located in the MoverAttack.cpp file.

[gleaming mauve]

Yes suit element contributes to both elemental resistance and elemental defense, increasing with the upgrade's level