#Local file provider behaviour in v2.7.9

1 messages · Page 1 of 1 (latest)

slender stirrup
#

Hi, I'm trying to understand the local file provider behaviour in v2.7.9 and want to make sure I have it right before raising a bug.

My path is set to /media with the structure: Artist1/Album1 and Artist1/Album2.

My understanding is that ticking only "Sync Library Albums" should make Album1 and Album2 visible in the Albums tab. However, I'm finding that nothing appears in the Albums tab at all unless I also tick "Import tracks/files into the Music Assistant library" — at which point everything appears in both the Albums and Artists sections.

faint gate
#

yeah, that is actually correct. We should make those checkboxes dependent on the tracks on filesystem provider

#

albums are part of the tracks so without no tracks importing, nothing imports

slender stirrup
#

@faint gate Thanks for clearing this up for me 🙂 one other thing and this is just going to be maybe my OCD.. lol I have also made a Folder with all my playlist in the with the _Playlist so it not seachable.. I setup a new Local provider for playlist, I tick just the import playlist ( m3u files ). when I go back into this provider the import for Artist and Albums is ticked, I then see all the singal tracks / arists. making it a little messy for me.. again I might have this wrong and just getting a little OCD 😉

formal yoke
formal yoke
#

@faint gate re: your last comment, I've been going back and forth, specifically over the case where someone had sync checked for a provider and then unchecks it.

My working assumption is that we should clean up the db, removing everything that had previously been synced from the given folder. But if we return early then we wouldn't run _process_deletions so we'd just leave the db in the state it was up until the user unchecks the box (removing stuff from the folder isn't reflected in the db, adding stuff to the folder isn't added, and only one of those is even plausibly what a user would expect).

Unless there's some sort of one-time cleanup process to run as soon as they uncheck and save, and then we could return early on the normal / scheduled sync job? Or I'm thinking about this wrong / not seeing the big picture, which is also very plausible...

faint gate
#

hmmm, yeah now I get your point

#

I was more thinking that its rather inefficient to run the sync to then process false on each file but its also rather unusual that someone wants to add a filesystem provider to then not sync it...

#

If you uncheck it, we are not going to "desync" existing entries

formal yoke
#

Yeah. Just trying not to leave any foot-guns around...

#

If you uncheck it, we are not going to "desync" existing entries
Is that a statement of intent? As in, "we should not delete existing entries if someone unchecks the sync box"?

faint gate
#

Yeah I dont think we should unsync existing items if you uncheck it.
I think it should only determine if you want items to be synced

#

Otherwise you get into this whole rabbit hole

formal yoke
#

And if they want to clean up existing entries, delete the provider and re-add w/out the sync box checked?