#Hello guys! I would like a harsh critique of a...
native acorn
faint cove
GitHub 404s
solar arrow
Oh! My bad. It was in private mode. I've changed it to public.
ivory thunder
I don't have a ton of time to review, but I'll share a few thoughts at first glance. It looks really good overall!
- Not sure if deployments are automated, but you can set it them up with github actions
- Add shields/badges to the repo to indicate build status and stuff like that https://github.com/badges/shields
- The readme talks about deploying both on Vercel and Firebase. Probably could use a thorough review. https://www.makeareadme.com/
- Not to start a Yarn vs npm debate, but yarn was originally created because of security issues in npm, which were resolved a long time ago, so I don't really see the need for yarn since npm should have all the features you need.
- it should be "TV Shows" not "Tvshows"
- I think you can improve the design of the site. The dark gray text on a dark gray background is not ideal IMO, and some of the font size/spacing can be improved. Also the high of the TV show images varies and it makes the text not line up. I didn't look closely enough to see if you're using a component library, but something like https://daisyui.com/ could be nice
- For commit messages, I think they hardly matter for solo development projects. But, in a professional sense, evey commit would link back to an issue or PR, that describes more detail about the requirements for the change. Also, I never liked using words like "Add" or "Change" in commit messages, because it is a commit, we already know it is a code change. I like to avoid using verbs in general in commits.
