Data not added to queryParams | Angular Community | Page 1

jolly marsh Oct 17, 2022, 7:29 AM

#

Hello! I'm confused how to add filters to queryParams. Offset and Limit are added but data from "Filter" is not. What am I doing wrong here?

      private reports$ = combineLatest([this.reportListService.query$]).pipe(
    switchMap(([[filter, sort, limit, page]]: [[ReportFilters, any, any, any]]) => {
      const queryParams: any = {};

      this.mapDataToQueryParams(filter, queryParams, limit, page);
      this.sorting(sort, queryParams);
      console.log('filter', filter);
        // filter { createdTimestampFrom: "2021-12-31T22:00:00.000Z"
        // createdTimestampTo: "2022-12-30T22:00:00.000Z"
        // dateType: "CREATED" }
      console.log('params', queryParams);
        // params { offset: 0, limit: 20}

      return fromPromise(this.orderReportRes.query(queryParams));
    }),
    share()
  )

    public mapDataToQueryParams(filter: any, queryParams: any, limit: any, page: any) {
    if (page) {
      queryParams.offset = page.offset;
      queryParams.limit = page.limit;
    }
    if (limit) {
      queryParams.limit = limit;
    }
    if (filter) {
    queryParams.dateType = filters.dateType;
    queryParams.createdTimestampFrom = filters.createdTimestampFrom;
    queryParams.createdTimestampTo = filters.createdTimestampTo;
    }
  }
    ```

jolly marsh Oct 17, 2022, 7:50 AM

#

If I add this to the reports$ method it works. But why doesn't it work inside the "this.mapDataToQueryParams()"

      if (filter.dateType != null && filter.createdTimestampFrom != null && filter.createdTimestampTo != null) {
        console.log('inhere')
        queryParams.dateType = filter.dateType;
        queryParams.createdTimestampFrom = filter.createdTimestampFrom;
        queryParams.createdTimestampTo = filter.createdTimestampTo;
      }

left sparrow Oct 17, 2022, 7:52 AM

#

what do you do in this.sorting()?

quiet echo Oct 17, 2022, 7:58 AM

#

Try not to modify an object by its reference. It's better to change the mapDataToQueryParams in order to return the queryParams

jolly marsh Oct 17, 2022, 8:04 AM

#

In this.sorting() I do sorting.
So I should return queryParams from the mapDataToQueryParams ?

quiet echo Oct 17, 2022, 8:05 AM

#

Try also to type your objects
Example:

public mapDataToQueryParams(page: PageType, limit: LimitType, filter: FilterType): QueryParamType {
    return {
      ...(page ? page : null),
      ...(limit ? limit : null),
      ...(filter ? filter : null),
    };
  }

(code not tested)

jolly marsh Oct 17, 2022, 8:06 AM

#

Okay, thanks. I will try and modify the code

left sparrow Oct 17, 2022, 8:29 AM

#

jolly marsh In this.sorting() I do sorting. So I should return queryParams from the ``mapDat...

could you show the code? maybe something happens with queryParams. Or try to remove it just for testing

jolly marsh Oct 17, 2022, 8:34 AM

#

Sorting on first reload is not used. It starts with NULL

left sparrow Oct 17, 2022, 8:41 AM

#

so have you commented it out and checked the logs?

#Data not added to queryParams