#Expanding TBLs causing crashes

34 messages · Page 1 of 1 (latest)

tepid sableBOT
#

When having one mod with a table that is expanded and one that isn't, if the expanded one comes first the result will be truncated to the size of the smaller one.
This is a continuation of the problem dc had from over here since I don't want to clog up the modding chats

i.e.
Mod A (bonus tweaks) now has VISUAL tbl with the persona entries expanded to 999 (but otherwise no original entry edited)
Mod B has original VISUAL TBL (so only 464 entries for persona) and edits an enemy entry
when merging these, reloaded is truncating the persona entries back to 464

Jump

[Go to message!](#p5-modding-chat message)

cyan wasp
#

I don't really understand how expanding patches work. The problem is numWritten is the size of the patch, not the segment (which is expanded by this point) so the rest of the file is just never written

golden cedar
#

I know aemulus has code for expanding tbl (because it had its own format where you could just write patches, so you could patch, say, entry 560, and if the last valid entry was 350, aemulus would insert the dummy entries needed)

cyan wasp
#

I'm fairly sure it is meant to work with this. I just don't understand the code so I can't work out why it isn't working

#

I'll probably bother sewer in a bit in the hopes that he has an idea

golden cedar
golden cedar
#

hi im here to bother you in case it got lost in the sauce @cyan wasp

cyan wasp
#

I forgot, thanks for bothering me

#

I want to bother sewer but I think it's very late for him... I'll try and have a look during the day and if I can't work anything out I'll bother him this afternoon

#

(Timezones are so fun 🫠)

cyan wasp
#

@sharp helm I'm going to bother you now so I don't forget again. Do you remember how the binary patching stuff that tbl merging uses is meant to work with expanded entries (assuming it actually is meant to)?
It will work if the the expanded segment happens second but if it happens first the file gets truncated to the size of the samller one

#

I'm hoping you can save me the time of trying to work out how that decoder stuff works

sharp helm
#

I'll respond after I get up, eat and do work stuff.

cyan wasp
#

And then I'll respond to that tomorrow night 😄

sharp helm
#

(I just woke up, haha)

#

But yeah, I remember it working somewhat like that.

cyan wasp
#

and I'm just about to go to sleep

sharp helm
#

Been like 2 years but IIRC, if you extend the segment, it'd append raw, with a changed segment length.

If there's a way it can somehow truncate after applying another mod, it's probably unintended

#

I'd need to check the code myself, ahaha

#

(in other words am in same position as you, sans the fact that I remember a tiny bit of writing it)

#

I think the section lengths were handled inside the tbl merger specifically

cyan wasp
#

I saw that message DC lol

golden cedar
#

I plead the fifth

cyan wasp
#

Sorry it has been so long though, I haven't really been doing much modding stuff at all recently

#

I've not completely forgotten about it though, I do intend to look into it at some point. I'm guessing Sewer never did which is fine

viral pawn
#

Is there any progress about this?

#

A lot of people have been asking why it's crash and why mods never work to me sophiedead

#

good thing i was there to say that this is the issue

cyan wasp
#

There is not...

#

I haven't looked into it anymore, sorry

#

Maybe this weekend

viral pawn
#

it's ok haha