General & Development Help

[lyric spade]

so thats why i asked for specification

but i never want to run anything i dont need to

in case it fucks shit up

[shadow helm]

Understandable. But that's the correct one 👍

[lyric spade]

already on it

[shadow helm]

If that executes successfully, you should end up with 3 new run configurations:

[lyric spade]

i sure hope those will be named correctly

if not, i did something wrong

A problem occurred evaluating root project 'Ars-Configurare-1.19.2'.
> Could not get unknown property 'gecko_version' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

[shadow helm]

runData does your data generation (like recipe & texture.json files), runClient & runServer should be self-explanatory.
I'd suggest doing a runData first to be sure and then a runClient to see if everything works.
Then you can go wild!

Oh. The example addon might not have gotten the removal of geckolib.
I think you can check build.gradle and gradle.properties and wipe any mention of geckolib since ars bundles it's own after Bailey got fed up with breaking changes in patch versions (understandably so)

[radiant depot]

you can simply delete the implementation geckolib line

iirc nothing in the example use geckolib classes

[lyric spade]

attempt number 2

Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.hollingsworth.ars_nouveau:ars_nouveau-1.19.2:3.6.0.

this uh, looks like an ars nouveau version issue

[radiant depot]

you need to take the version written in the readme https://github.com/baileyholl/Ars-Nouveau

so 3.6.0.267

[lyric spade]

attempt number 3

on this episode of "Which Dependency Errors Next?" we watch as Riku slowly goes insane

nvm it succeeded

and its all named correctly i think

[shadow helm]

3 attempts is a quite reasonable number actually...
Or my standards have just slipped 🤔

[zealous zenith]

3 is rookie numbers for minecraft modding

[lyric spade]

the only reason is because i have previous modding experience in other languages

[shadow helm]

Or general java dev work, at least in a project older than 6 months

[lyric spade]

so i can somewhat understand the syntax... at least

though i can say getting my modpack to work in the first place

[shadow helm]

I didn't want to add that sticker but it's surprisingly fitting oO

[lyric spade]

was way, way, way harder

slap over 100 mods together with the most major content mods you could find and figure out how to make them work together

    at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:901)
    at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:719)
    at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
    at java.base/java.lang.module.Configuration.<init>(Configuration.java:140)
    at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:494)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:75)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:87)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.TransformationServicesHandler.discoverServices(TransformationServicesHandler.java:130)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:86)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:77)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
    at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
    at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)```

result of running runData

it returned with an exit code of 1

question is, can i ignore it or not

[radiant depot]

that happens when you don't run genIntelliJ runs after changing dependency stuff

not sure why

[lyric spade]

sigh

[shadow helm]

voice in the distance, slowly fading away
Foooooooooooooorgeeeeeeeeeee graaaaaaadleeeeeeeeeee

[lyric spade]

errrr

i ran the intellij runs thing

it did the same exact thing

so something else is wrong

[shadow helm]

shift + shift -> type invalidate caches & restart, do the thing, cross your fingers, try again

[lyric spade]

shift + shift???

[shadow helm]

double click with shift

[lyric spade]

???????

oh

press shift 2 times fast

nice shortcut

[shadow helm]

like, press shift quickly twice in intellij

aye

[lyric spade]

anyways, "do the thing" as in

run intellijruns?

[shadow helm]

after typing in invalidate caches in the shift + shift console it should offer you the option to do just that, do the invalidate, then let gradle import again, then let genIntelliJ run again, all while crossing your fingers and hoping the best

if you've got a devotional candle to the Omnissiah or whatever technological deity you prefer, now might be the time

[lyric spade]

well

i got a different error when running runData

but thats better than getting the same error

[radiant depot]

umh, maybe the mods.toml still have the geckolib required lines?

Will need to update that thing, it has been 4 months

[lyric spade]

and wheres that

i only know of gradle.properties and build.gradle

[shadow helm]

src\main\resources\META-INF

[radiant depot]

https://github.com/baileyholl/Ars-Nouveau-Example-Addon/blob/3a8e84a147bd200d6acaee17d5f9cfab4c555c4a/src/main/resources/META-INF/mods.toml#L63 delete this block

[lyric spade]

also

these shouldnt be "dependencies.an_addon" right?

rather they should be "dependencies.myaddon"

[radiant depot]

yes

it's written in the main mod file too, the mod id must match the id in the mods.toml

(assuming nobody deleted that comment, lmao)

[shadow helm]

I'd suggest doing an overall CTRL+SHIFT+R for an_addon with myaddon

[lyric spade]

STRG?

lol

[shadow helm]

Sorry, it's late and my brain's slipping. German for CTRL

[lyric spade]

ahhh that explains

dont worry my brain... should be slipping by now?

its 12:33 AM atm

where i live

[radiant depot]

it's only one hour difference

[lyric spade]

yeah thats fair

since im in Finland after all

do i need to do the whole invalidate thing again

[shadow helm]

Suddenly I've got a hundred questions about Finland in my head. Most importantly, if you know about Codefreeze and if you attended it or know someone who went there
(explanatory link: https://codefreeze.fi)

[shadow helm]

50/50. Try without, if it doesn't work, yes

[radiant depot]

It's usually needed only when you touch gradle stuff

[shadow helm]

If it still doesn't work we're back to candles/sacrifices/etc

[radiant depot]

and mods.toml is forge stuff

[lyric spade]

sadly i dont

however, from what i can tell, its something id probably like to attend if i ever got a chance to

[shadow helm]

Same. Just seems like it requires a lot of preparation clothing-wise that I'll never use again.
And a reasonably big part of my vacation budget 😁

[lyric spade]

that depends on your tolerance to the cold

and how long youll be spending outside

ohhhh

its in lapland

yeeeah

thats rather cold

heh...

ok yeah clearly it sorta kinda is outside

[shadow helm]

Not watching northern lights for at least half an hour to an hour when that's half my reason for traveling would feel like a waste, I think.
Also, they may claim that the husky ride's expensive as hell and no one ever did it, but if I'm going to Lapland then I'll sure as hell want to meet a bunch of good boys and girls and want to have them pull me through an amazing snow scape

[lyric spade]

yeah it is a waste

though, i must warn you

the northern lights are never truly predictable

you may not see them regardless

but its likely that you will

[shadow helm]

Back to topic though: Is it working now?

[lyric spade]

process finished with exit code 0

success

now to do runClient

[shadow helm]

Better set up time than I had for my initial run so far, nice!

[lyric spade]

oh thank god the music wasnt distorted nightmare fuel on the client run

it was when i made an examplemod based on a tutorial

it literally blasted me with the most eerie shit ever

kay so

a few issues in the mods list

(the CR at the end)

[shadow helm]

Is your version set in gradle.properties/build? Might also not be a thing in the actually build jar just during dev mode, not sure though

[shadow helm]

seems like a CR LF where it just expects a LF, probably, might want to check your IDE settings for that.
Also just a guess though

[lyric spade]

mod version is set as 0.0.1

[lyric spade]

???

[shadow helm]

The full explanation might take a while, but there's different styles for line ending encoding.
There's (if I remember correctly) the usual windows style with is CR LF (Carriage Return Line Feed) and there's the Linux way which is just LF (Line Feed).
If minecraft expects that line to end with just LF, it might render the CR like that

[lyric spade]

so what do i add for it to be fixed

[shadow helm]

Lower right corner of your IDE should show the style of line ending for that file and you should be able to configure line endings in file -> project settings

[lyric spade]

uhh kay

its CRLF

[radiant depot]

A dev-env thing

[shadow helm]

even better than project -> settings:

Can just click it.
Sometimes I really want to high five a JetBrains Dev

[lyric spade]

why is this IDE so intuitive

it feels almost wrong

yup that fixed it

guessing this is the part where i can start doing shit

[shadow helm]

Is this the moment to shill the fact that they also make (according to rumors, I haven't done C, C++, C# in a long while) a decent C# IDE?

[shadow helm]

Guessed correctly! Good luck!

[lyric spade]

i have a very strong suspicion that yes

pretty sure i almost used it, too

or at least their intellisense or smth?

[lyric spade]

the only problem is:
how does one go wild in... modifying another mods configs

how config do

or should i even modify ars nouveau's configs or just have my own

guessing i should have my own?

[shadow helm]

Well, you obviously want values for things that aren't (yet) in Ars Nouveaus config files, so I'd probably say that having them in your own config file is probably better

[lyric spade]

now the question is

do i make separate glyph files like ars does (which i personally hate)

or just... neatly format them into one file

[shadow helm]

I haven't caught up to all previous discussion when I came home from meeting the family, depending on the config you want to do it might even be something that Bailey could be willing to take a PR on 🤷‍♂️

He. Not going to weigh in on a matter of taste and preference.
I've learned that lesson from discussing colors with actually competent artists 😂

[lyric spade]

ask if you can do thing -> bailey tells you that no, you gotta make an addon -> learn how to make an addon -> get told bailey can do it

[bright shore]

ouch

[lyric spade]

👍

[shadow helm]

That's why I asked about the previous discussion. If it's something Bailey doesn't want in the main mod, that's what addons are for 😁

[lyric spade]

basically, i encountered an issue while making a modpack

that being that 10 glyph slots simply wasnt enough and invisible not working on all blocks is kind of a pain

so i looked for config options to change that

none were found

invisible working on all blocks sounds reasonably possible since intangible already kinda does that

even though it doesnt work on block entities (guh)

and ofcourse i want to change the 10 glyph slots

[shadow helm]

(may still lead to 3 addon devs talking at him to bloody consider the idea, him begrudingly allowing us to add it, only to then use it himself for his new armors and crafting the enchanters sword/bow/etc)
shakes fist at sky
That was a fun misunderstanding 😁

[lyric spade]

so is it possible for bailey to do it or not

[shadow helm]

yeaaaaaaahhhh that's a pretty hard limit.

[lyric spade]

does it sound reasonable enough

[lyric spade]

oh god

[bright shore]

I would absoluetly love the 10 glyph slots to be changed but that probably won't make it

[lyric spade]

how hardcoded is it....?

specifically, i want to change it via configs

not the default amount of 10

[zealous zenith]

the UI is pretty much why there is a limit

[lyric spade]

10 simply isnt enough to compete with the other mods

[zealous zenith]

10 fits neatly

[shadow helm]

Not even hard coded, (although, that, too, especially UI wise, far as I can recall) but I think it's also one of the core things the mod's kind of balanced around?

[bright shore]

there's no way to make it auto add more rows?
I mean that's a big ask but

[lyric spade]

thats why i mentioned having to work with ui code

[lyric spade]

i was gonna do exactly that

[zealous zenith]

it would be really hard for an addon to change the book UI

[bright shore]

sure, but modpack and addon makers alike should have the right to mess with it

[zealous zenith]

you would have to make your own spell expansion system

[shadow helm]

depends on what you compare it to 😄

[zealous zenith]

or rather id suggest that

like tome of blood does

[bright shore]

what do you mean by that?

[zealous zenith]

you would have to mixin the UIs in a ton of places

[shadow helm]

I think you would have to mix-in into the Open Book UI event to override it with your own Book UI instance? At least that'd be my first try

[lyric spade]

all major content mods from tech and magic on 1.19.2

[zealous zenith]

or just replace it yeah

[lyric spade]

combined

atm thats what its competing against

well, non-completely-busted content mods

but still powerful stuff

[zealous zenith]

I mean, what is your goal?

[shadow helm]

Big ask. You could help So-So with porting Omega to 1.19, that bumps the power ceiling of AN by quite a lot

[zealous zenith]

the addons add some pretty busted things

[bright shore]

me who was trying to port and stopped to join the conversation

LOL

[lyric spade]

my goal is to allow extreme spells like massive conjurations that then actually do something with those blocks

at the cost of massive amounts of mana

[bright shore]

I mean, it's not like ars doesn't compared to vanilla either, modded is just usually pretty busted

[shadow helm]

might have to change the mana system or add something to it, too, then

[bright shore]

why not just use addons?

the focus of block shaping plus all he addons lets you do all sorts of funky things

though I strongly agree that a way to get bigger spells would be fun

[lyric spade]

goddamnit i wanted omega since it looked like itd up the ceiling

[shadow helm]

true, but that's why we're playing modded anyways, right? 😁

[lyric spade]

no no i seriously need bigger spells

[bright shore]

ah what''s the problem with it lol

[lyric spade]

i, for example, tried to make it rain conjured mageblocks which then have lightning cast on them

[bright shore]

I was planning that in omega but I chickened out like a boring person

[lyric spade]

but there simply werent enough slots to make it happen

[shadow helm]

It's not on 1.19, would be my guess which is why I suggested helping with the port 😄

[lyric spade]

aoe conjure -> explosion -> delay -> lightning

[zealous zenith]

we have talked about ways to make bigger spells, it is mostly an interface/systems issue

[bright shore]

I'm still considering spell cloth that you can weave together ins ome kind of loom, that can take a spell each and chain them to be like a big spell

[lyric spade]

sadly the delay just wasnt big enough

and i couldnt amplify the lightning at all

[zealous zenith]

players can do a lot with the 10 glyph limit, and this mod is really for them

[lyric spade]

and the amount of conjured was too little for a meaningful effect

[zealous zenith]

its not for the playerbase that power play psi and hex

[lyric spade]

etc

[bright shore]

Ars code supports this too I've just been to busy

[zealous zenith]

make a focus that chains two together

ez

[shadow helm]

🤔 I actually like that idea
it's kinda like Tea's blood scrolls but feels like a more AN way of doing things

[lyric spade]

chains 2 spells together?

[zealous zenith]

ya

[lyric spade]

holy shit thats a decent idea

[zealous zenith]

fill page 1, fill page 2

focus appends them together

[bright shore]

that sound very fun

[lyric spade]

question is, on the main mod or on an addon

[zealous zenith]

that is a much easier addon to create than changing the existing book

[bright shore]

yea make that an addon item

[shadow helm]

could also still get back to So-Sos idea for a loom, because apart from the headache that is Gecko-Animation, that sounds like an absolutely amazing, awesome idea

[bright shore]

I... wasn't gonna animate mine

[zealous zenith]

lol

[bright shore]

I was also thinking through 3d spell related ideas with cursed contexts and stuff but so far it seems like a VERY overcomplicated and bad idea

if I ever do any animations it'll be some cursed player stuff to animate using the staff
I have big plans for the staff

[lyric spade]

though wait

[bright shore]

(read:pipe dream)

[shadow helm]

also cool about that idea: You could probably steal most of the code required for chaining spells with items from Tome of Blood

[lyric spade]

this still wouldnt allow for big spells with the conjured blocks

since that requires the block focus

[bright shore]

everything EXCEPT the book UI code already supports any size spell

[lyric spade]

and you cant have 2 focuses at once, can you?

[bright shore]

not the focus idea no

[zealous zenith]

Not without telling curio to add a second slot

[shadow helm]

bump up the amount of foci that can be equipped

[bright shore]

not unless you change that

you can

[zealous zenith]

You could make a custom book that chain casts

EVEN easier

[shadow helm]

that should be an already configurable value

[bright shore]

that too

or a necklace if you prefer
or a thread for armor if this is in 1.19

there are a lot of options I imagine

[lyric spade]

thread for armor seems... meh

necklace seems good

however botania and such has necklaces id like to have

sooo

[shadow helm]

Thread seems like a no-brainer taken thread slot, tbh, so probably not the best idea

[lyric spade]

huh

fair enough

[bright shore]

tier of thread could influence max glyphs it would copy from the other slot

3,6,10 or something

[shadow helm]

Like, we like threads because most choices are kinda valid and having one that feels required kinda goes against that. Which is fine, it's your addon, but at least sometimes I try my best to consider what Bailey and Goo were thinking when they did something

[bright shore]

or not, just an idea

[zealous zenith]

users are more likely to understand how to use it if it is its own item/book that they configure directly

foci and threads require invisible shenanigans that are not obvious to the user

[bright shore]

yea thread is probably a bad idea

but aything ca be made work if you implement it well

[lyric spade]

hmm

[bright shore]

but honestly yea a different book fits best

because think about it: the spells would end up being super different anyway

so that just makes the most sense

and it lets the other person see if someone has a 20 slot book lol

[zealous zenith]

the work is already done for you for the book UI, maybe some tweaking so it only has 1 castable slot but 2/3 selectable pages on the UI

[bright shore]

but the UI can be left untouched

[lyric spade]

on that note, it could have unique balancing

something more than just "haha more mana"

[bright shore]

yea I recommend a book like was suggested before

you could add an exponential cost to every extra amplify glyph lol
but that's a dumb idea

you could add discounts to random utility spells to encourage people to make complex things instead of just adding more aoes and delay harms and stuff

[lyric spade]

i was thinking of adding casting times to spells depending on size

or even a sacrifice to use the spells

[shadow helm]

might require a bit of fancy logic, but making "damaging" delays cost extra while utility delays for block manipulations don't could be useful and interesting.

Time and Sacrifice are also cool ideas.

[lyric spade]

perhaps merging the idea of for example allowing invis to affect all blocks could work with this

as in, having very slightly augmented effects

on certain glyphs

though

[bright shore]

no I just meant that each harming spell costs some percent more than the last, so you can't add harm a bunch of times and call it a day

don't touch delay it's a logic glyph

[lyric spade]

wouldnt i have to recolor the back of the book

while its being held

similarly to the other books

which add fancy new markings

also i dont know why but i feel like calling the book "Epitome"

[shadow helm]

for 1.19 with with a Spell Damage Thread, Drygmy familiar and earth robes + bangle it's most definitely a damage-ish glyph.
Which is the application I was thinking about touching.

Having it untouched for logic use but more expensive for straight up damage spam is where the logic could be tricky

[lyric spade]

ah isnt damage spam pretty much just poison

[bright shore]

not necessarily, just a method to say if a glyph is damaging type, and as you go through the spell you count up the number of those, and add some number to the number fo damaging spells (rounded though bc ints)

[lyric spade]

theres a whole load of damaging spells though

lightning, cut, wind shear, break, harm... the list goes on

and theres technical cases too

[shadow helm]

fair point, that's probably easier

[bright shore]

it was just a thought

[lyric spade]

like launch + gravity

[bright shore]

but I still think my idea is at least somewhat viable

[shadow helm]

only that it's not handled via poison but spell damage that can actually kill you 😁

[bright shore]

just make launch half a harming spell, still gains price because it has strong effects but less so

make everythig floats until the end lol

that's my favorite strat to calculate game blancing stuff

more fractins

[lyric spade]

if i waste a sacrifice to get a spell that doesnt even kill id be pissed

anyways

[shadow helm]

a lot more viable than trying to detect "good" and "bad" delays!
Government work is ruining me, I'm already thinking far to complicated...

Thanks for the eye opener though!

[bright shore]

yea no detecting delays seems bad, I only mentioned delay so you knew I wasn't dumb enough to forget them in an actual spell

sorry

[lyric spade]

so what should you sacrifice to disable all limits

i want there to be something that allows you to use it unlimited

[bright shore]

in fact I think delay and redstone and interact should all have discounts

and linger and break could have no change

and harm and wind shear and lightning and explosing and stuff could have exponentially increasing cost int he way I explained

[lyric spade]

but question is, what.

[bright shore]

nether star?

new item from a boss you add?

IDK

[lyric spade]

nether star empowers the next 5 casts

seems viable enough

[shadow helm]

that might interfere with the "MOAR BLOCK FLYING" idea though.
Eh. Let's see the new book, no need to think about unlaid eggs.

Also Cyberpunk finally finished re-downloading, hopefully I won't have corrupted sound anymore... 🤞

[lyric spade]

and as another option, increasing cast time trades off the discounts the higher you put it, with like 30s completely removing it

[radiant depot]

IDamageEffect interface

[lyric spade]

though 30s is a lot

mayhaps 15s or 20s as max

[radiant depot]

Added recently, one of the breaking changes

[lyric spade]

well, first

i need to get to the point where i even have a damn book

and a color scheme for that book

[shadow helm]

Then a colorable color scheme for that book 😉

[lyric spade]

next up: how make book

as in, how do i even get to the part where i can modify the book

cant modify something that... doesnt exist as an item yet

[bright shore]

what

what do you mean

modify how?

[lyric spade]

i should go off the base book, no?

[bright shore]

you'll want an item class that extends SpellBook and overrides the interaction stuff so you can make it cast the double spell

you'll register it like any other item

and I don't think you need to touch the Ars spellbooks themselves unless you mean to replace them which sounds lame

[lyric spade]

right, time to go check how java classes work

hold on

specifically, inheritance

[bright shore]

similar to C#, the hard part is how minecraft items and registering work

oh also EVERY method is virtual which is nice when modding lol

well, almost every

[lyric spade]

virtual as in?

i can just go funny override?

[bright shore]

By default, all the instance methods in Java are considered as the Virtual function except final, static, and private methods as these methods can be used to achieve polymorphism.

[radiant depot]

there is an example item in the addon

[bright shore]

yep you can override in your child class

[radiant depot]

so the deferred item registry is already prepared

[lyric spade]

ExampleCosmetic?

[bright shore]

I have a bound wither entity that extends from the normal wither and overrides a bunch of targeting related logic to attack the owner's enemies isntead of just the nearest friendly

[bright shore]

nice, so it's just the inheritance and casting logic to figure out

[lyric spade]

damnit i still havent fixed the "ExampleANAddon" file

[bright shore]

... I've been working on trying to get my mod to complile in 1.19 and hours later I still have over 500 errors lol

[shadow helm]

I think Forge put out a remapping script, did you find and run that?

[radiant depot]

that one would surely help for the forge things

another bit you need to do is a replace geckolib imports with the ars shadowed ones

[bright shore]

nope I never know where to find those

[bright shore]

yea I haven't even started with that just disabled all those classes for now

[radiant depot]

https://gist.github.com/amadornes/cead90457e766f6d4294cb6b812f91dc

[bright shore]

I'll try that thanks

now I'll merge the changes from that with my other changes and see if it's any better

down to 446 errors it helped a bit

[zealous zenith]

just make alex do it

[bright shore]

alex has better things to do than port the worst addon

sorry, second worst, forgot I started the new project

[shadow helm]

There's a non-zero chance that Tea's going to come in any second and fight you for the worst addon spot with ToB 😉

[radiant depot]

I can help with directions if you say which kind of errors you have

But do it now while i do the final checks for source gas

then it's time to sleep

[zealous zenith]

source gas!\

alex is making the most cursed addon for sure

[radiant depot]

Motoko Request

[bright shore]

oooh cool

I only have 1 thing I don't know how to do which is set up the geckolib dependency on the shaded ars one

[zealous zenith]

delete packages and reimport

[radiant depot]

replace in files

bernie.geckolib3 to bernie.ars_nouveau.geckolib3

[shadow helm]

if you don't have gecko in your dependencies anymore it should automatically only pick the new shaded ones

[bright shore]

oh

that worked lol

earlier when I tried I had a bonked build.gradle with the wrong ars and I never thought to try again after fixing it

🤦

[radiant depot]

for the gecko deprecation warnings, you can ignore them. Or check in Ars how they were changed

[bright shore]

does intellij have a delete unused imports function? I have a ton that I've forgotten to clean up and it's a problem

[radiant depot]

it's just refractorings made before the geckolib4 as warnings

yep

[zealous zenith]

turn on the optimize imports on the fly option

it auto cleans/imports for you

but only the files you enter

[bright shore]

I'll try that if I ever get this to compile lol

[bright shore]

um, how do object holders work in 1.19 and should I just go back to deferred registers?

[zealous zenith]

you should use deferred registers

[bright shore]

ok

they're better anyway

hmm, did potion jars and/or potion mixers change a bit?

[zealous zenith]

yes

everything uses a potionData wrapper or something like that

[bright shore]

I see

I'll have to figure out the mixer and amplifier again then

aaand now that I'm replacing eveything with deferred registers my registry handler has over 800 errors LOL

[bright shore]

this feels like progress but I can't tell for sure until I get rid of them all and try to launch the game

which will have to be tomorrow unfortunately

[quiet roost]

Looking at SourceManager in the API. That is not working yet is it?

[radiant depot]

wdym

[quiet roost]

SourceManager does not appear to be in use yet

[radiant depot]

It's called thru SourceUtil

[quiet roost]

Yeah... But the Ars blocks aren't in the map it has. So I'm unsure why its there, if you have to call SourceUtil anyway...

[radiant depot]

Umh, bouncing to @zealous zenith since i have no idea why it was made like that in the first place

[zealous zenith]

It’s used for moving sources from Ars Creo, what are you trying to do?

You might be seeing some of the leftover code for backwards addon compat

[quiet roost]

Just trying to move some source. Was trying to use the api code, but it appears I have to use SourceUtil instead

which is fine I supposed. Just a bit confusing

[zealous zenith]

Ye it’s due for a refactor, it all changed when adding moveable source

[bright shore]

um, I just got this error, but I never made a tag for any of these...
any idea what might be wrong

[07Jan2023 12:44:00.435] [Worker-Main-3/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag [arsomega:potion_extender (from main), arsomega:potion_amplifier (from main), arsomega:potion_relay (from main), arsomega:potion_bottler (from main)] as it is missing following references: arsomega:potion_extender (from main), 
    arsomega:potion_amplifier (from main), 
    arsomega:potion_relay (from main), 
    arsomega:potion_bottler (from main)

[zealous zenith]

didnt make a tag for potion_extender?

did you delete the tag but are trying to load it in code?

[bright shore]

I don't remember ever having such a tag

ooooh wait it's likely ars code loading it

I might've put tag instead of item in a recipe

?

[radiant depot]

possible?

it would give a warning tho

not a crash

[bright shore]

well I have no ideas

it's not a crash

it's just an error in the log

[zealous zenith]

just ctrl + shift + F to pull up the text search and search the string

[radiant depot]

oh, then it's possible

[bright shore]

I was going through to see which of my recips needed fixing

[radiant depot]

you should try to use datagen for recipes

[zealous zenith]

breaking tags is really bad in 1.19

[radiant depot]

but maybe it's a bit late

[zealous zenith]

it cascades and breaks everything

now you can break the entire ability to mine blocks if you break the mineable tag

[bright shore]

pppppj

[radiant depot]

someone did in FC, probably Soaryn

[bright shore]

*oooh

blocks/mineable has the item sin the tag

🤦

[zealous zenith]

lol

yeah you would have broken the ability to mine blocks

its customary for all 1.19 ports now

[bright shore]

?

do I need to change something related to those tags again?

I also messed up all the resource locations of my rituals which is gonna take forever to fix cause I have so many 😦

unless, does intellij let me find and replace in a certain folder?

that might help lol

[radiant depot]

kinda

replace in files

[bright shore]

how

[radiant depot]

you can set a scope

[bright shore]

nice

there's an open files option, do I do that or is there a better way of choosing them?

[radiant depot]

right click on a directory, you have the replace in files option from there

from the project tree

[bright shore]

that seems easier

I'll remember that next time

that was so much easier than when I did like 80 glyphs by hand 🤦 )

only like 50 glyphs but still

[radiant depot]

you can probably use it to update the glyph models for example

[bright shore]

... ?

I thought they didn't have any in 1.18 so I'd need to make them

[radiant depot]

since you just need to replace the same words in all the files

[bright shore]

oh yea that part

the item model

how does the model in the book work though?

does it just use the item model?

this is embarassing, I forgot to close the place with my function before doing the find and replace

so I caused a stack overflow

oops

[radiant depot]

yep, it's the item model

[bright shore]

oooh nice

that's not so bad then

[radiant depot]

so you can do layering and animated textures on glyphs

i mean, you could even in 1.18

[bright shore]

too bad I'm so bad at art then

[radiant depot]

but you needed to toggle a bool

[bright shore]

frick

I made the glyphs use ritual names

oops

LOL

[radiant depot]

anyway for advanced amplify this is what i use

public static void addAugments(){
for (AbstractSpellPart spell : ArsNouveauAPI.getInstance().getSpellpartMap().values().stream().filter(s -> s instanceof AbstractEffect).toList()) {
if (spell.compatibleAugments.contains(AugmentAmplify.INSTANCE)){
spell.compatibleAugments.add(AugmentAmplifyTwo.INSTANCE);
spell.compatibleAugments.add(AugmentAmplifyThree.INSTANCE);
}
}
}

[bright shore]

I have something like that but I have a follow up question

how on earth do I balance it limit wise

[radiant depot]

private void setup(final FMLCommonSetupEvent event) {
event.enqueueWork(() ->{
ArsNouveauRegistry.addAugments();
});
}

oh, sorry

[bright shore]

can't someone just put 2 amplfy, 2 amplfiy 2s, and 2 amplfiy 3s? and have 6 amplify glyphs

[radiant depot]

wrong one

i'm dumb

lol

[bright shore]

even if you do limit them based on the amp confic

whiich also IDK how to do

so right now my advanced amplify is uncapped lol

which is obv bad

[radiant depot]

i have to check if my fork of tmg actually limits

and if not, how to

[bright shore]

I'm hoping the amp limit can be total of any amp type

so like if you use an amp 3 you can only add 1 other amp regardless of strength

but IDK if ars is built that way

if not I'll request it that's sorta ncessary if me and TMG are to coexist on 1.19 ever

[radiant depot]

umh, no. i don't think you can do that

[bright shore]

what do you mean

[radiant depot]

with the current code

would need something like a tag check

the limits are an hash map

based on the glyph rl

[bright shore]

huh

wait how do limits work right now?

... where on earth is amplify added?

I don't see amplify in default augment limits

[radiant depot]

don't panic, it's still @Override
protected void addDefaultAugmentLimits(Map<ResourceLocation, Integer> defaults) {
defaults.put(AugmentAmplify.INSTANCE.getRegistryName(), 2);
}

[bright shore]

that's so much worse

[radiant depot]

each glyph have their own map

[bright shore]

wait no hold on

I can check the map and edit it afterwards then? if it doesn't get locked?

once they finish registering these values normally

I can add my amplify based on a copy of normal amplify if it's there

but after the config is read, like int he loading finished stage or something

[radiant depot]

yeah

[bright shore]

so I just dupe that

that sounds easy

[radiant depot]

for the "same default config" is easy

[bright shore]

as long as it's not immutable or anything

[radiant depot]

it's the "can't mix amps" that's weird

[bright shore]

ooooh yea

ok but I can just mixin the checker that reads this

and use my things there instead

the problem ofc being

then it will play bad with TMG

yea, definitely a map of tags instead of glyphs would help here

since if anyone limits AOE it should also limit my AOE types too, no?

also, quick question

where the heck does explode get the amplify limit from?

oh wait nevermind I see it

🤦

dang the mixin looks hard

[radiant depot]

Might actually be not so simple

[bright shore]

doesn't matter I'm planning to mixin ActionAugmentationPolicyValidator

question

[radiant depot]

augment limits is not a map after init

i mean, not a public one

[bright shore]

can a mixin change the value of a parameter to a different object, and have the rest of the method use that parameter instead? if you inject at head?

[radiant depot]

maybe redirect?

[bright shore]

how does that work?

[radiant depot]

if you use mixinExtras, bundled with ars, you should be able to make them more compatible with others

[bright shore]

that sounds useful

what do you recommend I do?

[radiant depot]

https://github.com/LlamaLad7/MixinExtras/wiki

needs
annotationProcessor("com.github.LlamaLad7:MixinExtras:0.1.1")

[bright shore]

ok

[radiant depot]

also the maven { url 'https://jitpack.io' }

[bright shore]

um, I don't see how mixin extras affects what I'm trying to do

or a redirect for that matter

what are you suggesting I do exactly?

I need to change this to count custom things as part of normal ones, and also remain compatible with other addons messing with this for some reason:

@Override
    protected void validatePhrase(SpellPhrase phrase, List<SpellValidationError> errors) {
        // No validation of augments without the effect present
        AbstractSpellPart action = phrase.getAction();
        if (action != null) {
            phrase.getAugmentPositionMap().forEach((augmentTag, augments) -> {
                int limit = action.getAugmentLimit(augmentTag);
                if (augments.size() > limit) {
                    // Iterate, but skip until the limit, then mark the rest.
                    for (int i = limit; i < augments.size(); i++) {
                        errors.add(new ActionAugmentationPolicyValidationError(
                                augments.get(i).position,
                                augments.get(i).spellPart,
                                action,
                                limit
                        ));
                    }
                }
            });
        }
    }

there doesn't seem to be a good way to do this but my first thought is just make a fake phrase being passed in where all my augments have the key of base ars augments because the map is different

IDK if that'll be bad for performance actually, but... I don't see how else I can remain compatible with other things that wanna do the same thing

[radiant depot]

which line were you planning to change?

[bright shore]

... before the first one is my current idea which kinda sucks lol

the thing is, in the foreach all the logic is based on the key
so my thinking is leave that alone and just funk up the keys so my things use the keys of base ars augments instead, for only this method

is that a terrible idea?

[radiant depot]

i think you can mixin redirect on action.getAugmentLimit

[bright shore]

I could

wait no

I can't

cause they won't all be counted together

[radiant depot]

check the parameter, if it's your glyph then check the instance's augment limit for amplify and return that one

[bright shore]

I'd need to mixin the entire loop away too which is bad

[bright shore]

yea but then they're sitll separate

[radiant depot]

oh, still thinking to tmg?

[bright shore]

?

the foreach loop counts based on tag

so unless I modify either the loop or the tag in the augment position map, my amplifies will still use a separate counter

and I'm not mixin in the position map cause other validators might use that

so mixining to make an entire fake spell phrase with a map I can control seems best so far

forEach((augmentTag, augments) -> {
                int limit = action.getAugmentLimit(augmentTag);
                if (augments.size() > limit) {

see?

hmm

can't I use @warm nestdifyVariable to change the value of the argument when the function enters?

ooops why did that ping

sorry

is that even a thing on forge? I thought mixin worked the same in both loaders but I can only find examples on fabric lol

[radiant depot]

it should be

forge simply uses less mixins since there's the api

[bright shore]

I mean there is also a fabric API but it seems less in depth

alright, time to give this a try

... are you kidding me

the spell prhase constructor has private access

do you recall how to fix that? been a while since I had to work around private constuctors

[shadow helm]

something something access transformer? I think you need to grab the exact method name through the IntelliJ Minecraft modding plugin and paste that into your Access transformer config

[bright shore]

doesn't let me cause it's not a minecraft class

IDK if that just means I have to do it manually or if it can't be done

but the plugin can't copy the access transform stuff

[radiant depot]

I'd start to consider doing it later as a PR to Ars

[bright shore]

boring

does @ Nullable in a parameter change the method signature?

or how does that work

[radiant depot]

that should be just a compiler thing

[shadow helm]

shouldn't

[bright shore]

I'm trying to get the constructor via reflection but IDK what I'm doing lol

[shadow helm]

should just be a piece of syntactic sugar to tell you that it might be nullable

[bright shore]

oh god it has a list

um

wait can I just get all constructors and then find mine and call it a day?

since it only has the one

[shadow helm]

No one does when they're fucking with reflection... shudder

[shadow helm]

until someone else reflects a new constructor there. But yeah, might be fine for your use case since there probably won't be an addon-addon? Still, PRing in a protected or public is probably easier

[bright shore]

then I can just do a quick check if a few parameters match and pray nobody's that crazy

also make a PR

but I want to have somehting working quickly

and setting up a workspace for a PR is pain

so unless one of y'all do it I'm gonna procrastinate it for way too long

[zealous zenith]

alternatively delete advanced amplify and embrace limits and restrictions

[bright shore]

https://tenor.com/view/no-way-dude-no-oh-bugs-bunny-bugs-gif-22941840

anyway this is me embracing the new limits and making advanced amplify play nicely with them

smh

ok test 1

there's a 90+% chance it blows up

it's a mess of reflection and mixins

... it's not compiling, gradle broke itself

bruh I didn't even touch it

oooh I messed up the access transforms somehow

no idea how but I did

[radiant depot]

My policy now is to never touch AT unless it's more than 3 things on different classes for something

Anyway my versions of TMG probably will skip amplify variants

[bright shore]

for real?

I mean I'm not gonna be too disappointed by that
but what does the original author think?

[radiant depot]

You would just need to fight Derr versions

Which is the official and released for 1.19.2

[bright shore]

ah

what do they do right now?

I'm curious

[radiant depot]

Ignore the problem of amp limits from what I can see

[bright shore]

...what

oops index out of bounds exception, I used the wrong get constructors

[bright shore]

as in, they each have separate limits?
or are they straight up unbounded

[radiant depot]

Unbound

Can't even remember if it was intended or @desert horizon simply stopped there and forgot

[bright shore]

lol

[desert horizon]

Half right. Amp 3 is supposed to be able to break all power limiters.

[bright shore]

aaand crash, forgot to set accessible and it's private

[bright shore]

ok, but, like, why so many of them?

[desert horizon]

Wdym?

[bright shore]

alex said they don't respect the amplify cap

I'm making advanced amplify share the cap of amplifies

that makes the most sense to me

erm

drat

so, well, it broke the way the book display stuff

😦

[desert horizon]

Intended to do that with 2 but didn't get there yet. 3 is supposed to disregard limits.

[bright shore]

huh

that seems ridiculous

and then you judge me for omega being OP

[desert horizon]

Well, maybe I need to stratify more.

[bright shore]

the logic works though

it just doesn't stop you placing more

in the book

sigh

so close

[desert horizon]

Conceptually I have tiers 4 and 5 to work with. Tier 4 is intended to be power on a level with say Apotheosis, Mekanism, etc. Tier 5 is world breaking power.

[bright shore]

what

since when

that's new I thougth amplify 2 was tier 2 and amplify 3 was tier 3

[desert horizon]

Not actually tiers, just conceptual groups

[radiant depot]

The real op mod was tmg, every one was fooled

[bright shore]

I kept saying

[desert horizon]

Muwahahahaha

[bright shore]

mine adds op in the form of cool new spells and options and combos

TMG just spams power everywhere

I was planning even more sophisticated things like a spread out form of linger

so that large explosions could both be more TPS friendly, AND hit a wider area

many less explosions spread out in a better way

[desert horizon]

I intend it to be possible, but expensive, to snipe single targets for one hit massive damage without an elaborate combo.

Much more expensive than the intended combo methods.

Polar Ray, my main combat spell on the AN server, is too costly to spam.

Miss shots really suck.

[bright shore]

conceptually I feel like TMG and Omega will never play nicely together lol

[radiant depot]

Well, if you add too much mana the limits Derr though of becomes a lot less limiting

Even without counting omega damage spells

The focus of mana gives 3000 mana

[desert horizon]

What about regen rate?

[bright shore]

lowers it, I recommend the regne focus actually

adds tons of regen

[desert horizon]

Even if you have 3000 mana, that just means a bigger magazine with slower reload.

[bright shore]

genocide in a bottle

[radiant depot]

Mana regen potion amplified

[bright shore]

oh god potions

I added the potion amplifier

that sounds FUN

[radiant depot]

Will surely help a lot

[bright shore]

ah shoot I put the error at the beginning instead of the end somehow

... IDK how though

😦

I'm considering adding some filters and similar myself and just marking TMG as incompatible

but that's too scummy I wouldn't actually do that

so plan B is to add a config option to rebalance TMG and have it enabled by default
and make the changes I want if TMG is loaded

or is that also a bad idea?
I feel like Omega is big enough to justify that, it's almost an overhaul of ars at this point

[desert horizon]

Maybe we need to refactor.

[bright shore]

what do you mean

[desert horizon]

We have a few areas of overlap, either already present or in the pipe.

[bright shore]

quite a few

[desert horizon]

Filter interface is part of core Ars API now, so not a lot to worry about there.

[bright shore]

only in 1.19 which makes me a little sad

oh my god I DID IT!!!!
I'm so happy right now

[radiant depot]

What is the check?

[bright shore]

same one

I just had to fix the index

[radiant depot]

I was thinking that you can check the RL string for "amplify"

[bright shore]

it needs to be

phrase.getFirstPosition() + i + 1

[bright shore]

eh?

[radiant depot]

So it will take all 4 the amplifies

[bright shore]

I wasn't gonna do that that seems weird

[desert horizon]

A thought on amplify limits: is it glyph count or maximum amplify stat?

[bright shore]

I just check for my specific amplifies and make them use the amplify limit

[bright shore]

max amplify stat, why

[desert horizon]

Do amplify arrows break the limit?

[radiant depot]

It should

[bright shore]

no idea never tried

[radiant depot]

It's on glyph count

Otherwise my focus and armor wouldn't be able to work

[desert horizon]

😕

Playing on the server, I think I almost nailed the balance for amp2 perfectly, maybe it needs just slightly higher cost.

[radiant depot]

Anyway, when Bailey merges the splits PR remember to update the ars source.

[desert horizon]

It's almost unusable when you're fresh into tier 2, and remains a little awkward to use until you have good gear. Amp 3 is awkward to use with endgame gear.

[bright shore]

the amplfiies in TMG are gonna drive me mad
I have no idea how to make them work with omega

[radiant depot]

So you can check how to adjust the splitting, shouldn't break anything existing

[bright shore]

splitting?

[radiant depot]

[desert horizon]

How do your amplifies work exactly?

[bright shore]

what changed then

[desert horizon]

Rather, what's the point of contention?

[bright shore]

ah

just that I focused on making better glyphs

[radiant depot]

Spread like multishot now all start from same spot, instead of spawning them at different offsets that go forward

[bright shore]

and also that I have an advanced amplify with a cost much higher than the amp 2 cost was last I checked

(whcih was a while ago)

so mixing amp 3 with my glyphs is insanity

[desert horizon]

The amp2 cost is 4x base amp cost, maybe I should bump it to 5.

[radiant depot]

It should be pretty crazy with your burst form that doubles the splits

[bright shore]

advanced amplify is 9x cost...

[desert horizon]

Amp3 is 16x base amp cost for +4 amplify.

[bright shore]

see the problem?

[desert horizon]

Yeah, there's a scaling difference.

[bright shore]

huge one

[desert horizon]

Classic modpack hell, like trying to balance Mekanism with other FE mods ...

[bright shore]

ye but as devs we have some extra control here

[desert horizon]

Hmm.

[bright shore]

I'd need to modify amp2 to be 9x (replace advanced amplify), amp3 to be 40x, and make advanced amplify a tier four +6 amplify for 70x the cost

how does that sound?

except I was gonn ahave a tier 4 +3 amp glyph in my mod and now IDK where that would go here

[desert horizon]

Amp3 is a +4 amp glyph -.-

[bright shore]

I know

hence 40x the cost, so 10x the cost per amp

[desert horizon]

I was using a quadratic scale, so if amp2 was 9x then amp3 would be 81x

[bright shore]

stay as tier four and be +8 ampklify for 100x the cost? seems super dumb but would work

that means both our mods combined would add 5 tiers of amps

I'd add a config option to not do any changes

and a config option for a less OP mode that nerfs everything after amp3 so that the max is much lower

[bright shore]

yea but that doesn't work with my balancing

anyway that grows way too fast

I honesty think this fits best

or at least with only small tweaks

[desert horizon]

well, I was considering things like turret spells with mana values in the 18000 range

[bright shore]

good god

I guess that might happen

but I'm not balancing omega around that

and remember my proposal moves my things after amp3 as an amp4 and amp5 instead of bieng the amp2 and amp2.5 equivalents they will be in base omega

so it can't grow as fast regardless

[desert horizon]

hmm...

[radiant depot]

Amplify ^ ♾️ when?

[desert horizon]

parametric glyphs when?

[bright shore]

https://tenor.com/view/never-harrypotter-angry-fire-no-gif-4751988

I just had either the best or worst idea for an augment

[desert horizon]

legacy glyphs are another category I'm looking at...

[bright shore]

one to make the damage ignore i-frames

[desert horizon]

augment? I'd make it an effect

[bright shore]

which ones? most removed glyphs are potion effects which don't fit very well

I only see speed, aquatic, and regen making sense and omega adds a nerfed version of regen

[bright shore]

that would certainly be more balanced but less fun

LOL

[radiant depot]

It's as easy to make as easy to break balance, lol

[desert horizon]

either an instant effect that resets the target's iframe timer or a 'potion' that does so for a time

[radiant depot]

Realistically it only lift the delay requirement

[bright shore]

Oh an effect to reset the I frame timer sounds interesting

[radiant depot]

But if used as an effect it makes dots deadly

[bright shore]

Yea but then spells stack better making it VERY OP lol

[radiant depot]

I removed the iframes on a chimera and used a few linger harm

You could see the bar dropping steadly

[desert horizon]

with the changes that have happened though I seriously have looked at using discount rings + " go BRRRR" as a bossfight strategy 😛

[bright shore]

Doesn’t work because I frames lol

An augment to half or even quarter damage but ignore iframes seems semi-balanced to me

[desert horizon]

I don't expect it to work in that sense, but extra hits still deal knockback if possible, and I don't expect them all to hit

[bright shore]

Maybe a glyph could also reset the iframe timer but that would be pretty OP so would need some other limit

[radiant depot]

My hellfire resets the iframe

But requires the target to heal

It's a strategy a lot of people doesn't seem to know

I added a caster tome for it, at most it deals 40 damage iirc

[desert horizon]

Another coexistence idea: what if only your stronger effects refuse to validate against my amplify augments?

That also doesn't address the (admittedly minor) problem of wanting to add some more general utility glyphs like flatten, furrow, strip, etc.

The trouble with utility stuff is the 10 entry book limit 😛

but the idea with go brrr is not that you're dealing high damage, it's that you're keeping up constant pressure

[radiant depot]

Strip?

If you mean axe strip, it's now a feature

idk what furrow is

[desert horizon]

axeshear, not to be confused with a hamdrill

furrow is what you do with a hoe on dirt

[bright shore]

nah that's lame

[bright shore]

elaborate?

[radiant depot]

https://github.com/Alexthw46/Ars-Elemental/blob/b8412da7d4d54b7e31abedee09c57662fb2c507c/src/main/java/alexthw/ars_elemental/event/DamageEvents.java#L106

[bright shore]

LOL

so hellfire heal harm can be spammed for tons of damage?

[radiant depot]

ignite+focus then alternate spam

it's what i call Crazy Diamond

https://tenor.com/view/crazy-diamond-gif-23631368

"It's not unfair if i heal you everytime"

[desert horizon]

as an aside, is anyone else having issues with Enigmatica 6 dying with a native exception during load?

or is it just my hardware is still busted?

[bright shore]

how do break tools work in 1.19.2?

[desert horizon]

you mean for itself?

[bright shore]

no I mean in minecraft

how do I mark a block as being broken by pickaxe?

do I use the same tag as 1.18 or did it change again?

[radiant depot]

same

[bright shore]

ok

[radiant depot]

void addPickMineable(int level, Block... blocks) {
for (Block block : blocks) {
tag(BlockTags.MINEABLE_WITH_PICKAXE).add(block);
switch (level) {
case (1) -> tag(BlockTags.NEEDS_STONE_TOOL).add(block);
case (2) -> tag(BlockTags.NEEDS_IRON_TOOL).add(block);
case (3) -> tag(BlockTags.NEEDS_DIAMOND_TOOL).add(block);
case (4) -> tag(Tags.Blocks.NEEDS_NETHERITE_TOOL).add(block);
}
}

    } for a datagen for example

[bright shore]

makes sense

[desert horizon]

tags replaced mining level?

[radiant depot]

yep, since 1.18

[bright shore]

yep it makes me sad

😦

[desert horizon]

hmm, wonder what that's done to Tetra

[radiant depot]

probably a mixin on higher level and a tag to int converter?

[desert horizon]

those blocks that need silk + hammer 6 though

[radiant depot]

you mean the ruins?

[desert horizon]

yeah

[radiant depot]

those were reworked i heard

haven't played with tetra since 1.16 tho, no idea how

[desert horizon]

I still haven't got my head out of 1.16 mode tbh

kinda one of those golden age releases

ok... what dependency versions should I build against for 1.19.2?

currently targeting 3.2.10.193

[radiant depot]

at least 3.6.0.267

i would say the latest, but github is offline

and maven doesn't respond either

[desert horizon]

oh btw, you like my stateless build number trick?

[bright shore]

ooof

[desert horizon]

🇴🇴🇫!

[radiant depot]

Anyway, if in your servers GitHub work, check Ars Nouveau readme for the latest version

It will contain any push to the repo, even unreleased stuff

[desert horizon]

it seems to be working for me

base Ars doesn't have the glyph templates for all colors?

[radiant depot]

Just for the three it adds

Method, Effects, Augments

[desert horizon]

I only saw the one for augments as glyph_template.png

[radiant depot]

Maybe they only are in the example mod repo?

That template is probably the one used for the press back in the days

[desert horizon]

That was yet another different template, without a border color.

[radiant depot]

Pretty sure they are in the example repo at least

[desert horizon]

They are. I kinda meant your additional two colors.

[radiant depot]

Oh, the red one is in the tmg fork

[desert horizon]

Just thinking out loud, but at a sort of meta level to standardize things maybe the templates should be in core Ars and glyphs in general converted to layers?

[radiant depot]

It's an extra layer of work to make the models but is possible

Oh, actually

You could simply layer the color mask

Instead of the icon on the template

[desert horizon]

🤨

[radiant depot]

Umh, no. It wouldn't work well cause tint color is applied with code

So back at the first idea

You would make only the icon part right?

[desert horizon]

Is there any more complexity to simple layering than just adding more layer entries to the model JSON?

I was also going to layer the include/exclude and tier markings.

[radiant depot]

The glyphs in my fork of tmg are made with layers

Template + icon + allow/deny icon

Not sure if I did it with elemental filters foo

The issue with them is that's a bit more annoying to make the JSON and the texture

[desert horizon]

I'm basically redoing the work myself rather than accepting a pull... maybe I'm just pigheaded about it but ¯_(ツ)_/¯

that way I also learn the ropes

[radiant depot]

I need to remember and remake the propagate template. I had one but screwed the file when I tried different colors

[desert horizon]

propagate? ... oh, continuation-form?

[radiant depot]

Trend started with Omega, yeah

Recast the spell as a different form

I add the ones for the forms I add

[desert horizon]

from the top or the continuation?

[radiant depot]

While omega have the vanilla ones

[desert horizon]

I assume the continuation

[radiant depot]

The continuation, yeah

Just like rune, linger and chain. It's the subform family

[desert horizon]

oh btw... I'm wondering if we should do something to the default public constructor for SpellContext specifically to deliberately break code that creates a new SpellContext and copies known properties instead of cloning

TMG is not the only mod that needs to play a little bit of catch up there

[radiant depot]

https://github.com/Alexthw46/TooManyGlyphs/tree/1.19/src/main/resources/assets/toomanyglyphs/models/item

[bright shore]

do any other addons add forms? so I can add their propagate forms as optional dependencies sometime

I think TMG adds ray and lay on hands, anything else to be aware of?

[bright shore]

um why do my rituals show up this way? that seems wrong

[bright shore]

how do glyph recipes work in 1.19.2?

[desert horizon]

scribing table recipes?

they take a collection of items and an xp cost

in datagen it looks like

        recipes.add(get(EffectChaining.INSTANCE).withItem(ItemsRegistry.MANIPULATION_ESSENCE).withItem(Items.CHAIN, 3).withItem(Items.LAPIS_BLOCK, 1).withItem(Items.REDSTONE_BLOCK, 1).withItem(BlockRegistry.SOURCE_GEM_BLOCK, 1));

the resulting JSON unrolls the counted items

[bright shore]

um, I've been doing them manually

I just mean, like, where do I put it?

does location still matter? did in 1.18.2

[desert horizon]

I think it's flexible? mine are under data/toomanyglyphs/recipes/

[desert horizon]

Did I hear something about glyph tags?

[radiant depot]

Useless protip for easing the 1.19.3+ port in the future, if you have a lot of items that start as "new Item.Properties().tab().etc" convert that common code to a method. 1.19.3 removed the tab part so having a common source will be faster to fix.

[bright shore]

Ok

[bright shore]

possibly a few new augments: stasis, stagger, and spread

[radiant depot]

https://github.com/Alexthw46/Ars-Elemental/blob/1.19.1/src/main/java/alexthw/ars_elemental/api/item/SpellPrismLens.java
It should be pretty easy to use for making compat lenses

Only thing is that it will require a dummy item when elemental is not loaded.
Not sure how I could abstract it to not require to register an item

Unless I do the registration, like Ars currently do

In that case avoiding classloading is easier

@bright shore for example for a missile lens

[radiant depot]

Oh sorry, actual example
https://github.com/Alexthw46/Ars-Elemental/blob/1.19.1/src/main/java/alexthw/ars_elemental/common/blocks/prism/ArcPrismLens.java

The abstract class simply setup the tooltip etc.

[zealous zenith]

didnt realize you added datagen examples to the example mod alex

very based

rip I dont have the vazkii emotes anmyore

[radiant depot]

yeah, it's a very basic datagen. Especially for the Ars providers, i don't remember if i added the vanilla ones too

but the gradle is set to auto-merge the files, so no need of copy pasting from generated to src

[zealous zenith]

it regenerates the AN ones tho

[radiant depot]

and it will also remove the files not needed

uh, if it does then maybe there's a call to super

[zealous zenith]

oh nvm it doesnt call super

rip the crush recipe list is protected

[radiant depot]

time for a temporary reflection

[zealous zenith]

just made them public, now to wait for build + gradle

https://tenor.com/view/interstellar-cost-little-maneuver-51years-51-gif-24426899

[radiant depot]

nice, so i will be able to access my elemental dev world again

lmao

that damn wall spell

[zealous zenith]

that was pushed last night

[radiant depot]

wasn't built to maven tho

idk why

[zealous zenith]

oh weird

[zealous zenith]

this copy task runs at runtiome?

do not like

[radiant depot]

well, it doesn't really copy in src

simply adds the generated folder as sources afaik

the issue is when the same file is in both paths

[shadow helm]

@scenic oak https://github.com/baileyholl/Ars-Nouveau/blob/3ac0dd16a69caed4c9944429f676f851669c4f05/src/main/java/com/hollingsworth/arsnouveau/api/spell/SpellResolver.java#L61
should have the mana check you've been looking for

[scenic oak]

I did find that, I can't find where canCast is used

[shadow helm]

You can check for that in GitHub by clicking onCast and then references:

Although it's far easier if you have the sources locally and use an actual IDE

Basically leads you to these onCast methods: https://github.com/baileyholl/Ars-Nouveau/blob/3ac0dd16a69caed4c9944429f676f851669c4f05/src/main/java/com/hollingsworth/arsnouveau/api/spell/SpellResolver.java#L95

[scenic oak]

Unfortunately I'm at school rn

[scenic oak]

Yeah, but then where are those used xd
Basically I need to find a call path from the use method from the spell book to the enoughMana function

[radiant depot]

Mana expense code is different between 1.18 and 1.19

A bit, not too much, but remember to check you are in the right branch

So for example https://github.com/baileyholl/Ars-Nouveau/blob/1.18.x/src/main/java/com/hollingsworth/arsnouveau/api/spell/SpellResolver.java

[shadow helm]

Or from where it's called:
https://github.com/baileyholl/Ars-Nouveau/blob/52347786b0f02b6502abe698a43f47fab2f58ad8/src/main/java/com/hollingsworth/arsnouveau/api/spell/ISpellCaster.java#L145

[radiant depot]

The path should be something like spellbook item use -> call ICaster use -> validate spell -> call onCastOnXXX -> check for mana

[shadow helm]

I think the validate spell also happens in onCast, at least in 1.19. Might be different for 1.18, would have to recheck and can't currently

[radiant depot]

Ah, possible, yeah

The main difference is that the checks for Mana usage are a bit different and the order too, since in 1.18 you hear the cast sound even when you have no mana

So that's either a desync or validation happening way before Mana check

[scenic oak]

Oh I found it, it's done in common so yeah, it's done on server and client (I'm pretty sure)

https://github.com/baileyholl/Ars-Nouveau/blob/52347786b0f02b6502abe698a43f47fab2f58ad8/src/main/java/com/hollingsworth/arsnouveau/api/spell/SpellResolver.java#L99

[shadow helm]

opens IDE
sees all the red gradle failures
"Maybe I don't want to mod today and would rather do some monster hunting!"

[bright shore]

um, if glow particles always have an alpha of 1, why are they almost invisible when they have r,g, and b values of 1? Shouldn't they be black?
I don't understand what's happening there

???

[radiant depot]

Additive color

[bright shore]

are all minecraft particles additive color?

or how does that get set?

[radiant depot]

Start from transparent, get to 255 white

Umh, no idea on how particles actually work tbh

[bright shore]

ok but

I tried tracing where the color stuff goes

[radiant depot]

There are ways to make them not additive anyway

[bright shore]

and it just... sets the color of the particle without ever converting out from additive color

I wanted to make a non additive particle similar to the magelight glow

and now I have no idea how

[zealous zenith]

you would need a custom rendertype/shader

[radiant depot]

You kinda need to start by the rendertype

So back to what might be still called embers render type

[bright shore]

oh

I gotta make a knockoff of this:

static final ParticleRenderType EMBER_RENDER = new ParticleRenderType() {
        public void begin(BufferBuilder buffer, TextureManager textureManager) {
            Minecraft.getInstance().gameRenderer.lightTexture().turnOnLightLayer();
            RenderSystem.enableBlend();
            RenderSystem.enableCull();
            RenderSystem.setShaderTexture(0, TextureAtlas.LOCATION_PARTICLES);
            RenderSystem.enableDepthTest();
            RenderSystem.depthMask(false);
            RenderSystem.blendFunc(SourceFactor.SRC_ALPHA.value, DestFactor.ONE.value);
            buffer.begin(Mode.QUADS, DefaultVertexFormat.PARTICLE);
        }

        public void end(Tesselator tessellator) {
            tessellator.end();
        }

        public String toString() {
            return "ars_nouveau:em_rend";
        }
    };

with different properties?

[radiant depot]

It might be tied to the blend part

[bright shore]

I can't tell all this rendering stuff seems like a huge rabbit hole

[radiant depot]

https://tenor.com/view/yes-yep-yup-its-is-nod-gif-16786631

[bright shore]

I wonder if defaultBlendFunc would be enough to work lol

if I implement all the other stuff the same I can test

if that helps

[bright shore]

I've managed to 4 times in a row mess up the tile entity and not even get the renderer to load lol

awesome! that worked! just gotta reduce the randomness a lot lol

[radiant depot]

Welp

How should the right one look in your mind?

[bright shore]

still pretty white

instead of a random number from 0 to 255 it should pick from like 200 to 255 since it's so jarring rn

this is hilarious though

looks a bit like that right now

which is too much

[zealous zenith]

thats no blend?

looks very upsetting

lol

the black particle is nice

[bright shore]

yea I did all this bc I wanted black magelights for the demonic light glyph

if you add black magelights next updade I will be a little sad lol

[zealous zenith]

I wont

doesnt really fit AN theme

[bright shore]

I figured not, it's very... unusual

[radiant depot]

The problem with black particles is that you can spot the pixels more easily

It kinda works for that orb cause the actual particle is small

[bright shore]

I guess? IDK I like the black magelight honestly

an augment to make projectiles render like that would be hilarious but sounds like too much work to do ATM

[radiant depot]

Def something hard to hack in