#Dungeon Realm has a critical bug for looting (Fix script)

42 messages · Page 1 of 1 (latest)

upper plaza
#

Issue Summary

The dungeon mob reward drop system is controlled through DungeonMobValidator.java (https://github.com/RobertSkalko/dungeon_realm/blob/306b2c1025a4ba8f9003f33baaa4aa8d2c71bd42/src/main/java/com/robertx22/dungeon_realm/main/DungeonMobValidator.java#L9), which determines whether dungeon mobs drop rewards when killed. Currently, there's an issue where certain higher-rarity mobs (exclude Common rarity) and bosses and elite mobs are not dropping rewards properly when killed in dungeons.
Specifically, the following mob types are affected:

MapBossMB.java
EliteMobMB.java
BossMB.java

The problem is that these mob types do not have isDungeonMob set to true, unlike MobMB.java (https://github.com/RobertSkalko/dungeon_realm/blob/306b2c1025a4ba8f9003f33baaa4aa8d2c71bd42/src/main/java/com/robertx22/dungeon_realm/database/data_blocks/mobs/MobMB.java#L41), which prevents them from dropping rewards normally when killed in dungeons.

Problem

All dungeon bosses and uber bosses are not dropping rewards when killed. Additionally, even regular dungeon mobs that have grades or are classified as elite mobs are failing to drop rewards properly.

Script Explain

This script serves as a runtime patch that dynamically corrects the isDungeonMob flag for all mob types (including MapBossMB, EliteMobMB, BossMB, etc.) when they're damaged in dungeons, ensuring they will properly drop rewards when killed, regardless of their original configuration. (Only in dungeon_realm:dungeon dimension)

#

@cosmic spindle Dungeon Realm has a critical bug

cosmic spindle
#

Thanks for the report @upper plaza. @uneven bear actually already PRd this fix. It'll be fixed next update

#

def a critical bug

#

that im surprised no one brought up earlier lol

tranquil agate
#

i think i might have mentioned it but i forgot

#

i definitely noticed it

#

it's smth with like a lot of the guaranteed high-rarity mob spawns in maps

steady delta
tranquil agate
#

it's tough to see/remember if it isn't put in a post

harsh ferry
#

how can i implement such script in my SP world?

restive kelp
#

may I know how to use the script above it? Thanks

upper plaza
#

In minecraft instance folder

restive kelp
#

i have just test it, it seems only map boss could drop items. Uber boss still dont drop any of them except 3 relics

restive kelp
upper plaza
restive kelp
# upper plaza In my world uber boss also drop items.

me and my friends have tried 4 uber maps, all the map bosses drop 20+ items, but the uber boss still drops nothing. We even tried all killing the mobs to increase the exploration rarity (tho it seems it won't change the drop rate of Uber Boss i guess).

We both put the script into the kubejs/server_scripts folder. Cannot figure out why tho.

upper plaza
#

Or LAN?

restive kelp
#

my friend host a server

restive kelp
upper plaza
#

or /kubejs reload server_scripts

restive kelp
upper plaza
#

Such as rune

#

I can't think of a solution at the moment, but I will look into it.

#

If you kill Arachnarch and other Blue Sky bosses by force, you can make them drop rewards, but it seems too hard-coded, so I'll think of a way to do it.

harsh ferry
upper plaza
#

and run same command

#

/kubejs reload server_scripts

loud coyote
#

Oh so this is why I didn't get anything from my first Uber boss kill... unlucky

kindred blade
#

An admin of my server added this config change, but the boss Tongpi the Sculptor, Starlit Crusher, Arachnarch seems to have bugged drops still (see picture); watchers eyes are dropping (from another boss)

#

Does anyone know how watchers eyes are calculated? Ive heard 1/4 chance base thrown around, and i assume the +chance relics are multiplicative?

#

other ubers drop this assortment

cosmic spindle
#

This is fixed next update btw

limpid crag
amber pelican