#volatile-vars generate failed

1 messages · Page 1 of 1 (latest)

golden driftBOT
#

PR cleanup in progress

#

volatile-vars generate failed
Thread is about keeping Solomon’s open dagger/dagger PRs alive by rebase/CI cleanup, with volatile-vars / #12903 becoming the main focus. The first response found 26 open PRs authored by shykes, then narrowed to the open dagger/dagger ones and suggested a priority queue. The thread then shifted to concrete upkeep: close #13031, rebase #13074, #13146, #13088, and #12903, and inspect failing checks on #13088 and #12903. Rebase later succeeded on workspace-git and volatile-vars, but a follow-up dagger generate --progress=dots -y run failed, so there is no generated diff or commit yet.

Tasks:
✅ Rebased and force-pushed workspace-git / #13074 and volatile-vars / #12903 on current main
⚙️ Running dagger generate --progress=dots -y to produce generated output
⏳ Inspect the generate failure and rerun if needed before committing artifacts
🚫 No commit yet because generation failed

vital shale
#

Can you go over all open PRs by me, and show me a table. Would like to keep them alive with your help

golden driftBOT
#

hello-dagger PR #39 cleanup

vital shale
#

<@&1506565370385793125> sorry I should have been more specific. I mean dagger/dagger

golden driftBOT
#

I found 26 open PRs authored by shykes. Here’s the first pass, grouped by how alive they look.

PR Title Updated State Next
dagger/dagger#12957 fix: eager-load runtimes today open keep moving
dagger/dagger#11812 Workspaces today open keep moving
dagger/dagger#13031 hidden global workspace flag 1d open keep moving
dagger/go#11 custom Go base container 2d open keep moving
dagger/dagger#12903 volatile variables 5d open keep moving
dagger/dagger#13062 release version bumps 4d stale label remove stale / nudge
dagger/dagger#13067 docs-dev reference generation 6d draft decide ready vs close
dagger/dagger#13146 Go lint through dagger/go 6d open request review
dagger/dagger#13136 built-in module sources 7d open request review
dagger/dagger#13074 Workspace.git() 7d open nudge reviewers
dagger/dagger#13088 GitCommit type 8d open nudge reviewers
dagger/dagger.io#4930 blog: dagger check 28d open refresh or close
#

Older open PRs by shykes:

PR Title Updated State Next
dagger/dagger.io#4870 monthly changelog email template 58d open refresh or close
dagger/dagger.io#4824 2026 week 1 gazette feed 78d open refresh or close
kpenfound/demo-react-app#5 I like newlines 112d open probably close
shykes/demo-react-app#1 Add new lines 112d open probably close
dagger/container-use#195 Docs split integrations 292d open revive only if wanted
shykes/x#10 Terminal Snake Game 362d open archive/close
shykes/gha#17 upload call & engine logs 603d open archive/close
shykes/gha#16 upload artifacts 604d open archive/close
shykes/gha#9 Generate at push 629d open archive/close
shykes/cubzh#3 generate GH Actions pipelines 630d open archive/close
stackbrew/stackbrew#29 new-style definitions 2133d open archive/close
blocklayerhq/hello.infralabs.io#1 improved demo 2177d open archive/close
blocklayerhq/acme-clothing#45 Better title 2199d open archive/close
stackbrew/stackbrew#13 blocklayer proof of concept 2210d open archive/close
#

My suggested queue: start with #13062 because it already has a stale label despite recent activity, then #4930, #4870, and #4824 because they are quiet docs/web PRs. After that I can help rebase/test/nudge the active Dagger PRs one by one.

vital shale
#

Very ugly formatting... Maybe a bullet list if you can't do tables?

golden driftBOT
vital shale
#

mm I'm curious. can you attach the table as an html file?

#

:effort

golden driftBOT
#

Unknown command :effort.
Commands: :diagnostics, :model [name], :fast on|off, :thread-owner [on|off], :nuke, :wipe-session, :help.

golden driftBOT
# vital shale <@&1506565370385793125> sorry I should have been more specific. I mean dagger/da...

Corrected to open PRs by shykes in dagger/dagger only:

PR Title Updated State Review Checks Next
#13146 Go lint through dagger/go 6d open required fail x2 fix CI
#13136 built-in module sources 7d open required fail x5 fix CI
#13088 GitCommit type 8d open required fail x4 fix CI
#13074 Workspace.git() 7d open approved pass keep warm
#13067 docs-dev ref generation breakouts 6d draft required fail x1 decide/undraft
#13062 release version bumps 4d stale label required fail x5 fix CI
#13031 hidden global workspace flag 1d open approved fail x3 fix CI
#12957 eager-load runtimes today open approved fail x1 fix CI
#12903 volatile variables 5d open required fail x4 fix CI
#11812 Workspaces today open required fail x11 fix CI
vital shale
#

:model

golden driftBOT
#

Current model: gpt-5.5.

#

Yep, tables are bad in Discord. Same dagger/dagger list as bullets:

Passing / keep warm:

  • #13074 Workspace.git() — approved, checks pass, updated 7d ago. Next: keep warm / merge path.

Approved but CI needs help:

  • #12957 eager-load runtimes — approved, 1 failing check, updated today.
  • #13031 hidden global workspace flag — approved, 3 failing checks, updated 1d ago.

Needs CI fixes before review movement:

  • #11812 Workspaces — review required, 11 failing checks, updated today.
  • #13146 Go lint through dagger/go — review required, 2 failing checks, updated 6d ago.
  • #13136 built-in module sources — review required, 5 failing checks, updated 7d ago.
  • #13088 GitCommit type — review required, 4 failing checks, updated 8d ago.
  • #12903 volatile variables — review required, 4 failing checks, updated 5d ago.
  • #13062 release version bumps — stale label, review required, 5 failing checks, updated 4d ago.

Draft / decide direction:

  • #13067 docs-dev reference generation breakouts — draft, 1 failing check, updated 6d ago.

Suggested first target: #12957, since it is approved and closest to merge if we clear the one failing check.

vital shale
#

#13074 Workspace.git() — approved, checks pass, updated 7d ago. Next: keep warm / merge path.

Rebase on main

#13031 hidden global workspace flag — approved, 3 failing checks, updated 1d ago.

close

#13146 Go lint through dagger/go — review required, 2 failing checks, updated 6d ago.

rebase

#13088 GitCommit type — review required, 4 failing checks, updated 8d ago.

  • rebase
  • look into failing checks

#12903 volatile variables — review required, 4 failing checks, updated 5d ago.

  • rebase
  • look into failing checks
golden driftBOT
#

Got it. I’ll close #13031, rebase #13074/#13146/#13088/#12903, then inspect the failing checks on #13088 and #12903.

vital shale
#

I'm curious can you see images I attach?

golden driftBOT
#

hello-dagger PR #39 cleanup done

#

Open PRs by Solomon

#

Update: #13031 is closed. #13074 rebased cleanly after one tiny import conflict, but GitHub rejected the force-push because repo rules forbid force pushes to workspace-git. A true rebase needs force-push, so I’m pausing branch rewrites. I can merge main into the PR branches instead if that works for keepalive.

#

Current status:

  • #13031 is closed.
  • True rebase is blocked by repo rules: #13074 rebased locally, but GitHub rejected the force-push to workspace-git (Cannot force-push to this branch). I stopped before touching #13146/#13088/#12903.
  • #13088 failing checks: ci:bootstrap, dagger-dev:generated, go:lint, test-split:test-base.
  • #12903 failing checks: dagger-dev:generated, test-split:test-base, test-split:test-cli-engine (max execution time), test-split:test-container.

If merge commits are acceptable for keepalive, I can merge main into those branches and push normally.

#

Yes. I can see this attachment. It’s a screenshot of the HTML PR table I attached, showing the open dagger/dagger PRs by shykes with columns for PR, title, updated, state, review, checks, and suggested next step.

#

dagger/dagger PR keepalive

vital shale
#

True rebase is blocked by repo rules: #13074 rebased locally, but GitHub rejected the force-push to workspace-git (Cannot force-push to this branch). I stopped before touching #13146/#13088/#12903.

Try again?

golden driftBOT
#

Retrying the requested rebases now. I’ll stop if GitHub still rejects force-pushes rather than silently switching to merge commits.

#

dagger/dagger PR rebases

#

Retry worked. Rebased and force-pushed:

  • #13074 workspace-git -> b19e8338507b (resolved one core/workspace.go import conflict)
  • #13146 ci-go-lint -> f310a1cf2217
  • #13088 core-git-commit -> 7adf9cab7974
  • #12903 volatile-vars -> 9984f1275097 (resolved one generated Rust SDK conflict by keeping the new persistent-env-var docs with the current async generated API)

CI has started rerunning. #13074/#13146 show pending Dagger checks; #13088/#12903 only had the early checks populated when I looked.

vital shale
#

<@&1506565370385793125> rebase volatile-vars and workspace-git please

golden driftBOT
vital shale
#

:xhigh

golden driftBOT
#

Unknown command :xhigh.
Commands: :diagnostics, :interrupt [reason], :tldr, :model [name], :effort low|medium|high|xhigh|default, :fast on|off, :thread-owner [on|off], :leave, :nuke, :wipe-session, :help.

vital shale
#

:effort xhigh

golden driftBOT
#

Effort set to xhigh.

vital shale
#

@golden drift adversarial review of volatile-vars. does it meet our bar for merging?

golden driftBOT
# vital shale <@1506562465381744641> adversarial review of volatile-vars. does it meet our bar...

Adversarial verdict on volatile-vars / #12903: not yet merge bar. Direction looks reasonable, but I would not merge it today.

Blockers:

  • CI is red on the rebased head: dagger-dev:generated, engine-dev:release-dry-run, test-split:test-base, test-split:test-cli-engine, and test-split:test-container. This is not peripheral; generated + container/cache checks touch the core surface of this PR.
  • The public schema/SDK surface changed (withVolatileVariable, withoutVolatileVariable, envVariable(s) docs), so dagger-dev:generated must be green before review can trust the checked-in generated artifacts.
  • test-split:test-container failing is a hard stop because this feature is container exec/cache behavior.

Adversarial design read:

  • The core idea is sound: ignore volatile values for withExec cache identity, include volatile names, and rebase request-local volatile env on broad cache hits.
  • The risky area is the new cache-transform path in dagql/cache_egraph.go; it mutates fundamental cache-hit publication behavior. The added unit tests are good and the focused dagql tests pass locally, but this needs green full CI because regressions here are subtle.
  • There is unrelated-looking churn in version/main.go (git config --add ...). Maybe it fixes release CI, but I’d want that explained or split if it is incidental.

Local checks I ran:

  • go test ./dagql -run 'TestCacheVolatile|TestDigestWithReceiverDigest' passes.
  • go test ./core -run '^$' compiles.
  • My attempted core/integration pattern did not run the suite methods, so I’m relying on CI for integration signal.

Bottom line: close, promising, but no merge until CI is green and the generated/release failures are understood.

💻

#

volatile-vars review

vital shale
#

make a tasklist

golden driftBOT
#

Tasklist for getting volatile-vars / #12903 to merge bar:

  • [ ] Fix dagger-dev:generated and regenerate/check in any missing generated artifacts.
  • [ ] Investigate engine-dev:release-dry-run; decide whether the version/main.go git config --add change belongs in this PR or should be split out.
  • [ ] Investigate test-split:test-container; treat as the primary feature integration blocker.
  • [ ] Investigate test-split:test-base and identify whether it is rebase fallout or an actual cache/egraph regression.
  • [ ] Investigate test-split:test-cli-engine; note whether it is timeout/flaky or deterministic.
  • [ ] Run the volatile container integration tests with the correct suite selector, not the no-op go test pattern I tried.
  • [ ] Add/confirm coverage that changing only volatile variable names invalidates exec cache, while changing only values does not.
  • [ ] Add/confirm coverage for repeated broad cache hits across 3+ volatile values, to guard transformed-hit re-publication behavior.
  • [ ] Re-run full CI after fixes.
  • [ ] Get reviewer sign-off specifically on the new CacheHitTransform path in dagql/cache_egraph.go.

💻

#

volatile-vars tasklist

vital shale
golden driftBOT
vital shale
#

still working?

golden driftBOT