#go.mod noise

1 messages · Page 1 of 1 (latest)

tiny wharf
#

I'm guessing it would've been related to this particular change, which seems like we're running go mod tidy unconditionally? https://github.com/dagger/dagger/pull/11962/changes#diff-799c62755e728b5e47da423b829e747704c507f45304124573a13beef8187f90R185

GitHub

Summary
This PR changes the Go SDK codegen to split dependency types into their own files instead of inlining everything into a single internal/dagger/dagger.gen.go.
Before: All types (core API + e...

flat vessel
#

yup it appears so

tiny wharf
#

Would you know if this is something we want to keep going forward?

flat vessel
#

Whatever the most idiomatic and least annoying behavior, that's what we want 🙂 First step is to determine with full confidence what that is

#

let me ping @upper seal and @sharp venture (France timezone) for their take when they wake up

#

other <@&946480760016207902> might have an opinion also

tiny wharf
#

Thanks heaps!

flat vessel
#

@tiny wharf would you be willing to file a issue github discussion describing the problem you experience, and what you would expect the correct behavior to be?

tiny wharf
#

Sure thing, will do soon

tiny wharf
tiny wharf
upper seal
#

@tiny wharf We answered with @sharp venture

flat vessel
#

go.mod noise