Non deterministic codegen in GO SDK

[drifting walrus]

Hi team I raised this github issue on this a little while back.
We are seeing that the MarshalJSON and UnmarshalJSON functions for one of the module types is reordered every now and then.
Wondering if we can get someone to look into it.

[drifting walrus]

@errant lagoon tagging you for brevity 🙂

[errant lagoon]

tking a look first thing tomorrow 🙏

[drifting walrus]

Thanks Guillaume 🙂

[errant lagoon]

PR: https://github.com/dagger/dagger/pull/11871

[drifting walrus]

thank you!!

will review it later today but I'm sure you've covered it

[errant lagoon]

please do 🙏

[drifting walrus]

A Guillame a few questions on your PR just to confirm my understanding... the issue is caused because several tokens have the same position ? In my tests I thought it was because the token position was unstable - but it is very likely that I was doing something wrong 🙂

The other question, if the order of the objects is already presorted by name, would a StableSort achieve the same result as the tie breaker method you proposed ?

Thanks!

[errant lagoon]

Mmmh, I think you're right, on both points !

I should have fully tested on your repro and better read your text, I was multitasking, my bad, you already did all the debugging work ahah, thanks for all this amazing work you did 🙏

Let me update tomorrow and retry on your repro, with an integration test out of it 😇

[errant lagoon]

Update: re-pushed with the proper fix, the one you suggested, and added a similar integration test, as your repro (and fully tested against your repro ahah 👼) 🙏

[drifting walrus]

Ahh amazing Guillaume! Thank you so much 🙂

[errant lagoon]

Updating the integration test to have a deterministic repro (needed to add more elements to always trigger the fail evey 2 runs, but I think I got it). Tibor made some good comments on how to cleanly fix it, I'll update the PR again 🙏

[drifting walrus]

Yeah very nice work 🙂

[errant lagoon]

PR has been merged 🙏✅