Update from 0.18.0 to 0.19.10 issue

[devout flicker]

Hello everyone,

Got a quick question here. I am bumping my dagger version from 0.18.8 to 0.19.10 and i am having an issue executing a module from my private github repo.

When i try bump the version on the project and use the new engine version i get an error

TypeError: app() takes 0 positional arguments but 2 were given

In /runtime script. I am using python sdk. And this happens during module load both locally and on my CI (jenkins deployed on aws)

If anyone has any insights or some pointers i would appreciate it, thanks

[empty crown]

@iron island @vapid condor is that a known issue in the python sdk? Doesn't ring a bell for me..

[vapid condor]

Not at all, is app something inside the module code?

If you can open an issue with a repro that would be very helpful 🙂

[devout flicker]

bash-3.2$ dagger functions
✔️ connect 0.2s
✘ load module: . 3.7s ERROR
┇ initializing module › ModuleSource.asModule ›
✘ asModule getModDef 0.5s ERROR
Traceback (most recent call last):
File "/runtime", line 8, in <module>
sys.exit(app(None, "--register" in sys.argv[1:]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: app() takes 0 positional arguments but 2 were given

Strange thing js that i dont have any app() in my module that would be called when module is initiated 🤔

[wise hull]

@devout flicker seems like somehow your generated python code hasn't been correctly updated. If you see your sdk/src/dagger/mod/cli.py file, it should have this app defintiion def app(mod: Module | None = None, register: bool = False) -> int | None:

looks like your sdk/runtime/template/runtime.py and sdk/src/dagger/mod/cli.py are somehow mismatching.

What I'd recommend is to remove the generated sdk folder entirely in your project and call dagger develop again so the right code is generated

I've unsuccessfuly tried reproducing by going to v0.18.8 to v0.19.10 locally with a newly created module.

[devout flicker]

Ok i tried it, removed everything generated and then hit dagger develop but sdk was not generated this time, just dagger_gen.py