#I'm confused about moduleSource.

1 messages ยท Page 1 of 1 (latest)

amber kayak
#
Doc(`The directory containing the module configuration and source code (source code may be in a subdir).`).

https://github.com/dagger/dagger/blob/0042c00677b8b3aeb580cc703df1c99de8bc5992/core/schema/modulesource.go#L228

But the code does this:

https://github.com/dagger/dagger/blob/0042c00677b8b3aeb580cc703df1c99de8bc5992/core/schema/modulesource.go#L1446-L1459

It basically first checks modSrc.SourceSubpath and only if it is empty does it use modSrc.SourceRootSubpath.

But SourceSubpath documentation says:

    // SourceSubpath is the relative path from the context dir to the dir containing the module's source code
lime flint
#

Yeah seems like it diverged at some point

amber kayak
#

so who's correct ?

lime flint
#

i mean the implementation is always correct since that's what actually happens ๐Ÿ˜„

#

I'm not totally sure who uses it

#

perhaps SDKs?

amber kayak
#

i was hoping the documentation was correct ๐Ÿ˜„