What goes into a release?

[frigid bear]

How do you decide what goes into a release?

I was hoping this would get released since it was merged.

https://github.com/dagger/dagger/pull/11585

But looking thru the release notes I see it hasn’t made it in.

Thank you.

[cinder patrol]

if it got merged then it's in the release. Probably just omission in the release note.

[frigid bear]

Aren't release notes auto-generated too? Is there way to know for sure that it is in the release?

[cinder patrol]

you can look at the git tag from the release

[frigid bear]

Ya perfect, thanks!

[cinder patrol]

but we release from main so it's impossible not to release something once it's merged (unless the commit is reverted for some reason)

[open widget]

@cinder patrol I cannot find this breaking change in the change logs

• break: https://github.com/dagger/dagger/pull/11050
• chglog: https://github.com/dagger/dagger/blob/main/.changes/v0.19.0.md (that it should be in based on your comments in this thread, I've poked around more and cannot find it)
  This one's making me look bad :[

[static geyser]

@open widget it's not a breaking change from the engine PoV if you don't upgrade your module version. That API change is safeguarded behind a view

[open widget]

It's labeled as a breaking change in GitHub labels, alongside other breaking changes in the same release, that did get mentioned in the release notes. It does seem to have been missed, correct?

We don't use modules, we use the SDK. For SDK users, this is a very impactful breaking change, WithDirectory gets used a lot

If I speak directly to the engine with GraphQL, this would be a breaking change for my queries. To me, that is the engine changing it's contract with developers.

I can see how modules handle that for users, but I would not say that makes this not a breaking change in general, the api schema changed

[cinder patrol]

@open widget yes we did miss it in the release note, sorry.