celest holly
I am sure you guys have many GitHub notifications so you might have missed it, but I'm reaching out as a followup to the work on the issue: https://github.com/dagger/dagger/issues/9326#issuecomment-3323159321
I need some help to better understand the next steps. If you want, we can continue commenting out on the GitHub issue, or we can move the conversation here if you want 🙂
blissful girder
I am sure you guys have many GitHub notifications so you might have missed it, b...
ack Nikola. Will bring it back to the team today. They'll surely check out the updates sometime this week 🙏
celest holly
Thank you!
celest holly
Hey @blissful girder , I created a PR on our fork: https://github.com/G-Research/dagger/pull/1
The reason I didn't create a PR directly on the official repo is because we are still testing it internally, making sure that everything works as expected.
However, it would be very beneficial if someone can take a look in the meantime, so we can paralelize the work.
The integration test proves that the feature works, now, having someone provide suggestions about the way we did it would allow us to modify the code based on the feedback from your team 😄 Please let us know if you'd prefer for us to create a PR to the upstream (dagger/dagger) instea of our fork.
blissful girder
Hey <@336241811179962368> , I created a PR on our fork: https://github.com/G-Res...
Thx Nikola! really appreciate the effort. I'd say to go ahead and open a draft PR against our repo with the latest changes rebased so it's easier to review. The PR you linked seems to be a bit behind main and currently shows an excessive amount of changes.
Once the PR is in our repo, it'll be easier for our team to review and start the bikeshedding there 🙏
celest holly
Thank you for your quick response!