#Future GraphQL validation rules changes after dependency bump on engine

1 messages · Page 1 of 1 (latest)

languid yoke
#

Creating a 🧵 so we can save the context for later

outer minnow
#

I don't have any coverage right now for enums, I could add a few integration tests for built in enums today

languid yoke
#

That would be ideal so we can verify that this PR isn't breaking anything

languid yoke
#

Future GraphQL validation rules changes after dependency bump on engine

outer minnow
#

Any real use-case for any of the built-in enums I can use for a test?

languid yoke
outer minnow
#

Ah I don't think I can copy that right now, I still need to add the custom enum support

#

So I'm just adding a quick test for now that grabs the opposite NetworkProtocol

#

So If I pass UDP I should get back TDP

outer minnow
#

I'm trying to make this fail on purpose

#

and it's passing when I run dagger call test specific --race --pkg="./core/integration" --run="TestPhp"

#

hold on, hold on... it's failing on CI... so my command is wrong.

#

There we go. I was writing TestPhp instead ofTestPHP

outer minnow
#

Okay bad news, good news and gooder news down the road:

  • bad: The PHP SDK cannot take built-in enums as arguments currently: https://github.com/dagger/dagger/pull/11063

  • good: It's already broken so your PR can't break it

  • gooder: I will have to get enum support working sooner than expected (might as well get custom enums while I'm at it)

GitHub
PHP: Test built-in enums by charjr · Pull Request #11063 · dagger...

What am I doing wrong here? It seems locally to be passing, but clearly should not be.