#no worries. I'm done for the day ๐ Let
1 messages ยท Page 1 of 1 (latest)
Okay, gave your branch a quick test locally, it worked nicely.
Ideally, I'd like to add some integration tests for this change too.
This is where I'd want to add some tests: dagger/core/integration/module_php_test.go
It would look similar to each of those tests which are calling functions from here: dagger/core/integration/testdata/modules/php/list-kind/src/ListKind.php
I would want to add something like capitilizeNestedStrings.
I can do this in a second PR after yours but if you're up for it, go for it. I'd be happy to help. ๐