module name conflicts | Dagger | Page 1

gusty bison Jun 12, 2025, 1:22 PM

#

that does seem odd. not sure if it's related, but I found out recently it's somewhat easy to end up with name conflicts in dagger shell, because it also serves module dependencies of any module ref that you use. I wonder if dagger develop is somehow hitting that same path?

not sure why simply renaming would trigger it when it worked with the same name before

gritty yew Jun 12, 2025, 3:30 PM

#

Loading dependencies has moved to the engine, it's not specific to shell, but it's an option you have to turn on with Module.Serve() and develop doesn't serve the module.

gusty bison Jun 12, 2025, 3:35 PM

#

@gritty yew here's the issue i'm talking about - it's in initializeModule which impacts shell in particular since that gets called when you use a module ref: https://github.com/dagger/dagger/pull/10562#discussion_r2139015116

#

but yeah, dagger develop probably isn't

gritty yew Jun 12, 2025, 3:36 PM

#

Yeah, but Serve(.... includeDependencies: true) is used in more places and that's what's loading the dependencies.

gusty bison Jun 12, 2025, 3:39 PM

#

feel like that's splitting hairs - i'm pointing out that includeDependencies: true is maybe being used in a place where it shouldn't be, and that path gets called by shell in a situation where it was maybe not intended

gritty yew Jun 12, 2025, 3:40 PM

#

That's possible yes, it was added by Connor for LLM and I personally haven't thought about the full implications of it. But I don't think it's unintentionally being called by dagger develop.

gusty bison Jun 12, 2025, 3:41 PM

#

yeah agree, seems unrelated to the original issue thinkspin

gritty yew Jun 12, 2025, 3:44 PM

#

dagger develop does have a new thing collectLocalModulesRecursive, but I think it needs to be opt-in with -r.

#

Curious if you get the same error with something simple like: dagger -c '.core | module-source . | context-directory | entries'.

#

Oh wait, I think I have an idea here. dagger develop now also does client generation, not just module generation, and client generation also loads dependencies.

#

So I think that error is comming from client generation in moduleSourceGeneratedContextDirectory, which I would expect to show with:

dagger -c '.core | module-source . | generated-context-directory | entries`

#module name conflicts