GHA

[wind topaz]

i get an error in my generated github action from the following golang dagger

package main

import (
    "context"
    "dagger/nocdkp/internal/dagger"
)

type Nocdkp struct{}

func (m *Nocdkp) Generate() *dagger.Directory {
    return dag.
        Gha().
        WithWorkflow(
            dag.Gha().Workflow("Test suite", dagger.GhaWorkflowOpts{
                OnPush: true,
            }).
                WithJob(dag.Gha().Job("test", "test", dagger.GhaJobOpts{
                    Runner: []string{"ubuntu-latest"},
                },
                ),
                ),
        ).
        Generate()
}

func (m *Nocdkp) Test(ctx context.Context) (string, error) {
    return dag.Goreleaser().Test().Output(ctx)
}

[fossil geode]

cc @granite spear

[halcyon pier]

Probably @frank depot ..

@wind topaz do you specifically want to setup a dev dagger engine? Or are you OK to run this generated pipeline with a stable version of dagger?

[fossil geode]

seems like I jinxed it after my comment about re-usable modules in dagger/dagger 😄

per the snippet above, seems like this shouldn't be trying to start a dev engine 👀

@wind topaz what GHA version of the module are you using? shykes/gha? or the dagger/dagger one?

[halcyon pier]

that looks like dagger/dagger

you can tell because it's so complicatedpowerful 😛

[wind topaz]

dagger.json

{
  "name": "nocdkp",
  "engineVersion": "v0.16.3",
  "sdk": {
    "source": "go"
  },
  "dependencies": [
    {
      "name": "gha",
      "source": "github.com/dagger/dagger/modules/gha@v0.15.2",
      "pin": "b13f2c640a019a0197765e8d5cea1cc96786c487"
    },
    {
      "name": "goreleaser",
      "source": "github.com/goreleaser/goreleaser@v2.7.0",
      "pin": "8aacb197877091cea0d18523ad672eb99087b18d"
    }
  ],
  "source": ".dagger"
}

[wind topaz]

when i tried shykes/gha it failed during the install process: #github message

[fossil geode]

thx 🙏 checking now

[wind topaz]

i am running dagger call generate -o . to generate the workflows

[wind topaz]

hmm i just want a stable version of dagger i think

[fossil geode]

try making this change

                WithJob(dag.Gha().Job("test", "test", dagger.GhaJobOpts{
                    DaggerVersion: "latest",
                    Runner:        []string{"ubuntu-latest"},
                },

specifically DaggerVersion: "latest"

that should avoid the start-dagger-dev job that you see in GHA. Thats' coming from here: https://github.com/dagger/dagger/blob/b13f2c640a019a0197765e8d5cea1cc96786c487/modules/gha/steps.go#L38-L64

[wind topaz]

Amazing thanks for the fast response, this is one of the best developer communities handsdown!

NICE i got past that point now 🙂

[halcyon pier]

@fossil geode do you agree "latest" should be the default? Otherwise it indeed is not super reusable

[fossil geode]

Yes, 100%

[halcyon pier]

it was the default for shykes/gha just saying 😛

[fossil geode]

I'll send a PR later to fix that 🙏

[fossil geode]

woot! just realized the module works ok in main but we haven't released a new version 🙏

@wind topaz if you use the v0.16.3 version of the module, that should be fixed: https://daggerverse.dev/mod/github.com/dagger/dagger/modules/gha@79ec03c4a2c8add7f8f6465c7ef0bf13200cbfff

[frank depot]

https://github.com/dagger/dagger/pull/9385

i think i fixed this here

[fossil geode]

Yep, it was fixed. It was an old published daggerverse version