#Custom maven settings.xml

1 messages · Page 1 of 1 (latest)

cinder sable
#

🤔
The more I'm thinking about that, the less I'm thinking this is the right place.
I started to experiment with the sdk.config:

    "config": {
      "buildTool": "maven",
      "jvmLanguage": "java"
    }

And for that, that looks great. Because it's a configuration of the module itself. And this is independent to where you are running it.
But regarding the maven settings, that's the opposite. It's a global configuration, that is specific to the machine you are running it. The exact same module on two machines might need in one case a specific settings, and on the other not.
And this is something that shouldn't be in the dagger.json of the module, something not committed in the repository and not shared with other module's users.

#

That's for the sdk config, I'll look at the other aspect of the mentionned PR that is about Git config, to see if there's way we can extend it to look at maven settings, in a kind of global way

hollow palm
#

That's a good point. I was thinking something like "useLocalM2Settings": "true" and you'd pull in the settings.xml from ~/.m2/settings.xml. However, I understand that "local" may mean different things in different context and that may be hard to determine.