#Shell: lazy arguments

1 messages · Page 1 of 1 (latest)

snow hedge
#

@wheat turret, what was it that made you want to not serialize state in the chain?

wheat turret
#

Oh I remember it was for shell completion

#

Lol it took me a moment to remember

#

But I think the current approach works fine actually

snow hedge
#

I'm having an issue with PortForward because of the serialization. I'm trying to patch it with a new method on the QueryBuilder to not re-marshal an argument that's already marshalled. But I'm duplicating stuff that the query builder already does (marshaling arguments).

#

So I feel the itch again to make these arguments lazy until the end. It's a bigger change though, that's why I'm going this other route.

snow hedge
#

@wheat turret, what would you use as key for a command's state? A random id right? What would you use for that? I have an idea that it's best if we don't bring buildkit's identity.NewID into the CLI.

wheat turret
#

yeah good idea

#

i know go 1.24 has a new utility for this

#

but we're not yet on it

#

(on my todo list)

#

um, i would probably just identity.NewID for "now", i'll try getting 1.24 into our dev

wheat turret