What is the recommended way to specify imagePullSecrets in the dagger Helm chart?

[velvet hearth]

👋 We are using a private with your Helm chart.

Specifying the image is quite straightforward in the values.yaml file: https://github.com/dagger/dagger/blob/main/helm/dagger/values.yaml#L43

However I cannot find how to specify the imagePullSecrets so our private image can be pulled in the DaemonSet.

Is there a way to do that at the moment?

[dawn kiln]

(just by looking at the values, have not yet used that chart) looks like that property is not exposed so you could change it with helm postRender hook, or maybe add it to a service-account that you could reference via existingServiceAccount

[barren isle]

this. Even though the chart could be updated, I think it might be better to add the imagePullSecrets to the corresponding serviceAccount that's currently being used to pull the image so that way you don't have to do it for each resource 🙏

[velvet hearth]

I wish I did not have to create a service account myself outside the chart but I got it working using the existingServiceAccount value. Thanks!

I still think it would be a good parameter to add to the values either in the ServiceAccount creation logic or the as its own parameter to specify in the DaemonSet/StatefulSets.

[barren isle]

SGTM! any chance you'd like to submit a PR to add that feature?

[velvet hearth]

Can do! Adding to my todo list for this week 🙂

[velvet hearth]

Here it is! https://github.com/dagger/dagger/pull/9609