[Solved] Gitlab CI "Query.secret has no such argument" | Dagger | Page 1

cosmic pasture Feb 13, 2025, 12:55 PM

#

We're running dagger in Gitlab CI, it was running previously. I do not believe anything has changed in the environment and we just ran into this error.

This is running using the PHP SDK.

1   : [4.8s] | Error: input: query:
1   : [4.8s] | query{secret(uri:"env://CI_REGISTRY_PASSWORD"){id}}
1   : [4.8s] | 
1   : [4.8s] | error: parse selections: parse field "secret": Query.secret has no such argument: "uri"
1   : [4.8s] | 
1   : publish --registry=registry.gitlab.com --username=gitlab-ci-token --password=CI_REGISTRY_PASSWORD

Is this:

A known issue in Dagger?
An unknown issue in the Dagger PHP SDK?
An issue specific to our setup?

chrome bay Feb 13, 2025, 12:58 PM

#

are your cli and engine versions matched?

#

we hit this ourselves lol, ideally this should have neatly broken

cosmic pasture Feb 13, 2025, 1:29 PM

#

Ah thank you for the quick response!

I believe that is what we're hitting, I'll let you know

cosmic pasture Feb 13, 2025, 3:38 PM

#

So that was the solution. Thank you 🙂

It fixed an issue and lead straight to another issue...

We got a 422 Unprocessable Entity on 0.15.4 like this help thread

We figured, it may be that it depends on a dagger module which was a bit outdated.

We tried updating the module.

Now I'm trying to install the updated version in our bigger project.

Error: failed to get module SDK: input: moduleSource.withContextDirectory.asModule failed to create module: select: failed to update module dependencies: failed to load module "my-project" dependency "sai" config: failed to decode module config: unmarshal module config: unmarshal module config: json: cannot unmarshal object into Go struct field alias.sdk of type string

This reminded me of this recent PR: update sdk field in dagger.json from string to struct #9454

Has anything changed in how a dagger.json should look in the latest version?

GitHub

chore(mod): update sdk field in dagger.json from string to struct b...

This (is a WIP) stab at updating the dagger.json's sdk field from a string to a struct.
fixes #9156
I am opening this PR to collect initial feedback while I am trying to figure out how we c...

chrome bay Feb 13, 2025, 3:41 PM

#

this'll be caused by using the new sdk.source in a dagger.json in a version that doesn't support it

#

now this is a bug yup - the engineVersion should have been bumped to v0.15.4 automatically when changing to sdk.source

#

and you would get a clearer error i think

#

we saw this in https://github.com/dagger/dagger/issues/9576

cosmic pasture Feb 13, 2025, 3:52 PM

#

Just a quick sanity check, does this look right to you?

{
  "name": "my-project",
  "engineVersion": "v0.15.4",
  "sdk": {
    "source":  "php"
  },
  "dependencies": [
    {
      "name": "sai",
      "source": "https://github.com/sai-php/sai",
      "pin": "99b3babcf77d0f203b9f307418731b86687e4789"
    }
  ],
  "source": "dagger"
}

This is a project where the dagger.json is located adjacent to a dagger/ directory

chrome bay Feb 13, 2025, 4:08 PM

#

yeah, that looks good 👀

serene stream Feb 14, 2025, 1:06 AM

#

Confirming that the engine version was bumped to 0.15.4 in my case too.

cosmic pasture Feb 14, 2025, 12:31 PM

#

This may be an issue in the PHP SDK, as simply updating to the latest version of dagger has broken unchanged php modules

#

Is there any behaviour that had to be updated in the core SDKs for the upgrade?

#

@serene stream What SDK were you using when you ran into the 422?

chrome bay Feb 14, 2025, 1:18 PM

#

cosmic pasture So that was the solution. Thank you 🙂 It fixed *an issue* and lead straight t...

🤔 @cosmic pasture are you still having this specific problem

#

even with matching client<->engine?

chrome bay Feb 14, 2025, 1:18 PM

#

cosmic pasture This may be an issue in the PHP SDK, as simply updating to the latest version of...

nothing in the php sdk should have needed updating afaict

timber lark Feb 14, 2025, 1:35 PM

#

issue is happening locally; where the engine matches the cli

#

:~/git/dag/php$ dagger version
dagger v0.15.4 (registry.dagger.io/engine:v0.15.4) linux/amd64
:~/git/dag/php$ docker ps | grep dagger
e161842740b9   registry.dagger.io/engine:v0.15.4                 "dagger-entrypoint.s…"   24 hours ago   Up 24 hours                                                                                           dagger-engine-v0.15.4

chrome bay Feb 14, 2025, 1:40 PM

#

okay so i can get the 422 error to happen

#

but just to clarify, are you also still seeing the "cannot unmarshal object into Go struct field alias.sdk of type string"

chrome bay Feb 14, 2025, 1:59 PM

#

okay, so for the 422 error we're getting the php sdk is producing an invalid query 😦

📎 message.txt

#

withKind defeinitely needs an arg there

#

any ideas why it does that?

#

yeah, this happens while trying to install the typedef for this: https://github.com/sai-php/sai/blob/99b3babcf77d0f203b9f307418731b86687e4789/dagger/src/PHPContainer.php#L25-L29

#

it should be withKind(STRING_KIND)

#

i'm kinda confused how that's even possible

timber lark Feb 14, 2025, 2:29 PM

#

I am as well; was studying the source code and it requires an argument to that function; it'd throw a PHP error if one wasn't passed

chrome bay Feb 14, 2025, 2:29 PM

#

yeah okay

#

it's this https://github.com/dagger/dagger/pull/9436/files#r1927571228

#

if i revert that change it works

#

I thought we established that that wasn't needed though? #php message

#

🤔

timber lark Feb 14, 2025, 2:32 PM

#

I don't think my module uses enums either, so it wouldn't be triggering that :/

chrome bay Feb 14, 2025, 2:32 PM

#

that is what it is - the enum used is the TypeDefKind enum

#

used during module registration

timber lark Feb 14, 2025, 2:33 PM

#

oooh; so it's blowing up on the built in emum

chrome bay Feb 14, 2025, 2:33 PM

#

yeah exactly

timber lark Feb 14, 2025, 2:33 PM

#

so all scalar types will be broken

chrome bay Feb 14, 2025, 2:35 PM

#

yeah lol looks like i screwed that up

#

trying to decipher where the arg gets lost

timber lark Feb 14, 2025, 2:36 PM

#

two levels down

#

    protected function setArgument(string $argumentName, $argumentValue)
    {
        if (is_scalar($argumentValue) || is_array($argumentValue) || $argumentValue instanceof RawObject) {
            $this->argumentsList[$argumentName] = $argumentValue;
        }

        return $this;
    }

#

a backed enum isn't a scalar, array or raw object

chrome bay Feb 14, 2025, 2:37 PM

#

oh where's that?

timber lark Feb 14, 2025, 2:37 PM

#

grand parent class

chrome bay Feb 14, 2025, 2:40 PM

#

i'm clearly missing something, isn't the grandparent class? https://github.com/carnage/php-graphql-client/blob/7c28f461a0a3e86983ff769b8e1fa876ebc133cc/src/QueryBuilder/AbstractQueryBuilder.php

timber lark Feb 14, 2025, 2:41 PM

#

I don't think it's using that version

chrome bay Feb 14, 2025, 2:41 PM

#

facepalm that would indeed explain the issue i guess

timber lark Feb 14, 2025, 2:41 PM

#

the version I'm seeing is an older verison of that dependency I think

chrome bay Feb 14, 2025, 2:42 PM

#

altho https://github.com/dagger/dagger/blob/64b952da1d8d253fa9191d48216d682f38cb8d49/sdk/php/composer.json#L14-L14

GitHub

dagger/sdk/php/composer.json at 64b952da1d8d253fa9191d48216d682f38c...

An engine to run your pipelines in containers. Contribute to dagger/dagger development by creating an account on GitHub.

chrome bay Feb 14, 2025, 2:42 PM

#

chrome bay i'm clearly missing something, isn't the grandparent class? https://github.com/c...

the lock file points to this version

#

ohhh

#

but sai isn't

timber lark Feb 14, 2025, 2:45 PM

#

ah

#

I think we might need to bump the minimum version in the php SDK to 1.14.1

#

as your change doesn't work with 1.14.0

chrome bay Feb 14, 2025, 2:45 PM

#

ohhhh

timber lark Feb 14, 2025, 2:45 PM

#

it's currently allowing any 1.14.x verison

chrome bay Feb 14, 2025, 2:46 PM

#

right right, sorry, i think i remember looking at the changelog and not seeing it in there 😱

#

okay, at least it's an easy fix then

timber lark Feb 14, 2025, 2:46 PM

#

yep

chrome bay Feb 14, 2025, 2:47 PM

#

i can bump it?

timber lark Feb 14, 2025, 2:47 PM

#

glad we've not totally hosed the PHP SDK ~5 days before my PHP UK talk 🤣

#

go for it

chrome bay Feb 14, 2025, 2:47 PM

#

honestly kinda sad to not be going lol 😦

#

i'm not even a php dev 😄 it would just be fun to catch up

timber lark Feb 14, 2025, 2:48 PM

#

if you're around in London, there's a pre conf social

chrome bay Feb 14, 2025, 2:49 PM

#

i'm actually based in brum, so sadly not

#

hm, okay, so the problem is that we can fix this, but v0.15.4 is hosed for php support

#

this is not great, so close to your talk 🤔

#

when is your talk?

timber lark Feb 14, 2025, 2:51 PM

#

Wed 19th

chrome bay Feb 14, 2025, 2:51 PM

#

okay, i might look into running an emergency release, gimme a moment to consult

timber lark Feb 14, 2025, 2:52 PM

#

I'm going to try something else first

chrome bay Feb 14, 2025, 2:53 PM

#

it may just be possible to bump the sai dep?

timber lark Feb 14, 2025, 2:53 PM

#

deleted the composer lock from sai

#

that forced it to update

#

I wonder if we should consider adding composer.lock to the default module .gitignore

chrome bay Feb 14, 2025, 2:55 PM

#

okay! awesome, so the problem seems to be for updating older modules, but new dagger inits should fetch the newest dep right?

timber lark Feb 14, 2025, 2:55 PM

#

and maybe even removing it when initilising the module

chrome bay Feb 14, 2025, 2:56 PM

#

my main concern is i want to make sure users running the php guide after your talk won't hit this 😆

timber lark Feb 14, 2025, 2:56 PM

#

yes a brand new module will work

chrome bay Feb 14, 2025, 2:56 PM

#

pr here: https://github.com/dagger/dagger/pull/9589

#

okay, i'll hold off on an emergency release then, the next v0.16.0 release is aimed for wednesday 🙏

timber lark Feb 14, 2025, 2:59 PM

#

that's bumped a few other deps; might be worth testing it against a few existing projects before merge

chrome bay Feb 14, 2025, 2:59 PM

#

do you have a collection that you tend to use?\

timber lark Feb 14, 2025, 2:59 PM

#

I've only got my projects currently

#

Paul has the work he's been doing for symfony though

#

I'm thinking that we probably want to make changes to the SDK to ignore the module composer.lock - it's going to cause issues any time a dependecy in the SDK gets bumped

cosmic pasture Feb 14, 2025, 3:11 PM

#

Sorry I wasn't around to help, I had an urgent appointment to get to. I'm catching up but it looks like I missed the action

timber lark Feb 14, 2025, 3:11 PM

#

yeah, we dived in and figured it out :p

chrome bay Feb 14, 2025, 3:11 PM

#

cosmic pasture Sorry I wasn't around to help, I had an urgent appointment to get to. I'm catchi...

i'm sure they'll be a next time 😛

timber lark Feb 14, 2025, 3:13 PM

#

cosmic pasture Sorry I wasn't around to help, I had an urgent appointment to get to. I'm catchi...

if you want to do a bit more testing around the issue and make sure that new modules work with 15.4 and with the dependency change in the PR; that'd make me happier that we've fixed the problem

cosmic pasture Feb 14, 2025, 3:25 PM

#

Right, so the issue was us getting caught by the composer.lock snag again?

cosmic pasture Feb 14, 2025, 3:27 PM

#

chrome bay i'm sure they'll be a next time 😛

Standard developer life 🫡

chrome bay Feb 14, 2025, 3:29 PM

#

cosmic pasture Right, so the issue was us getting caught by the composer.lock snag again?

yeah, when we were working out how to handle the BackedEnum, we did it against the 0.14.1 version of the lib - but the min version is just 0.14.0, so it needs bumping

#

i guess this is a more generic problem though

#

we solve this in the go sdk by updating all the deps to minimum version in sdk/go/go.mod

#

maybe that could work here too?

#

(assuming we remember to keep composer.json up to date)

timber lark Feb 14, 2025, 3:30 PM

#

no the module has it's own lock

#

at best it blows up as it cant resolve an installable set of packages from the lock

chrome bay Feb 14, 2025, 3:31 PM

#

yeah that's what i mean - for go modules, we bump the module's go.mod min versions to the embedded known "good versions" that appear in sdk/go/go.mod

timber lark Feb 14, 2025, 3:31 PM

#

hmmm

serene stream Feb 18, 2025, 3:54 AM

#

cosmic pasture <@1276388183197880321> What SDK were you using when you ran into the 422?

Yo, sorry for the late reply, it was the Go SDK.

cosmic pasture Feb 18, 2025, 9:54 AM

#

serene stream Yo, sorry for the late reply, it was the Go SDK.

That's completely fine, I was just curious if your issue was the same as ours 🙂

timber lark Feb 19, 2025, 4:41 PM

#

Still busy at PHPUK, so I've not had chance to test this properly; but got one of the composer team to assist with the problem and came up with this as a solution: https://github.com/dagger/dagger/pull/9625

GitHub

[PHP] Update composer call to update generated code dependencies by...

Solve issue where we update a dependency in the generated code and the module composer.lock prevents that dependency from being updated.
Thanks to @naderman for the assist.

#[Solved] Gitlab CI "Query.secret has no such argument"