windows terminal | Dagger | Page 1

slow magnet Jan 10, 2025, 1:38 PM

#

this works fine for dagger call

slow magnet Jan 10, 2025, 4:29 PM

#

also cc @raven plume

slow magnet Jan 13, 2025, 10:36 AM

#

Hi @untold sapphire happy Monday. would you have few mins to allow me to show what is happening with windows terminal thing.

untold sapphire Jan 13, 2025, 10:44 AM

#

hm

#

happy monday 😛

#

this is for https://github.com/dagger/dagger/pull/9334?

GitHub

fix: avoid restoring stdout after making stdin raw by jedevc · Pull...

This just looks like a typo from #9244 - I don't think we actually intend to do this?

#

?

#

so applying this change causes the weird exit behavior you see?

slow magnet Jan 13, 2025, 10:50 AM

#

yeah

#

it works fine with dagger call but I see that issue with dagger shell

#

after I type in exit and click enter, the terminal prints exit 0, and then print the container object and then clears the terminal. but it keeps it there until I click anykey again

#

so i am wondering if stdin is waiting for that keypress 🤷‍♂️, but i am not familar with the TUI stuff there.

untold sapphire Jan 13, 2025, 10:58 AM

#

but on main it works?

slow magnet Jan 13, 2025, 10:58 AM

#

let me quickly try to be double sure

#

also, this works fine on mac, but only a prob on win]

#

ok.

does not work with main.
hangs until key-pressed with branch.

untold sapphire Jan 13, 2025, 11:38 AM

#

yeah, okay, that's weird

#

but there's no difference between main and the pr?

slow magnet Jan 13, 2025, 11:39 AM

#

on main, it seems like the original issue itself was not fixed. I was shuffling computers to test on windows, so can't rule out a possibility that I tested with a wrong compiled version of dagger-client originally.

#

now that I am testing it, with main - it seems original issue is not fixed. with PR, this weird behavior only on exit on shell.

#

given you have spent so much time on TUI, i am really hopeful that once you see what is happening, you might be able to either tell where the issue is or atleast point me in a direction to debug this more

untold sapphire Jan 13, 2025, 11:40 AM

#

okay, the weird behavior seems weird, but definitely better than it not working at all

slow magnet Jan 13, 2025, 11:41 AM

#

i added log statements in tui code, but couldn't figure out where is it getting stuck.

untold sapphire Jan 13, 2025, 11:41 AM

#

it's potentially restoring the terminal, and getting an empty screen

#

the process might not be running anymore

slow magnet Jan 13, 2025, 11:41 AM

#

but when i press any key, its restored correctly?

untold sapphire Jan 13, 2025, 11:42 AM

#

🤷‍♀️ could just be the shell rendering it fully then?

slow magnet Jan 13, 2025, 11:43 AM

#

how about let me do a small recording and share it here.

#

or if you think we can live with this and just merge that fix, that works as well 🙂

untold sapphire Jan 13, 2025, 11:45 AM

#

eh, i think we can live with this 😄 but a screen recording would be good too

slow magnet Jan 13, 2025, 12:02 PM

#

#windows terminal